From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914A3C433E2 for ; Mon, 14 Sep 2020 04:43:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06953208C7 for ; Mon, 14 Sep 2020 04:43:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0QW8JJtT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="pkK+i4OK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="pkK+i4OK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06953208C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TiO96e/940ePwSUYAIEiKY915Dd4ewwYPgcB3QRKgVo=; b=0QW8JJtT6nC7GhBSFXdWJgIkq hTGwB/0QeYFYNC+46lDThjgENiLKQvASqitv7LfL302+ZTH9sTpct+iUQagCiDtMEWazEloECGqQv 18At5ZCBkGITN0XCk9gKS3/gamMPz75IOdjUVF0HF7OyGaEiMojsGNV3q6GR/CnUAbFzOP2P6igVG Zx9q9ilotYuzU22gBm6ULQ6eS3iV+EYiWDmaqb2q/DOBl+xONiyiSPLJ/8fYhOt2GqzDj1BPyhvE/ nBQIyMExWdhP4IsLg84vF69XRNeE7aPvgCCgHAW7G6f5zS/7gZGEOzHUDlPwlWm4+N6we0CD1Zhf3 mUhBqzDKQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHgJ8-0004TQ-RN; Mon, 14 Sep 2020 04:41:38 +0000 Received: from mail-eopbgr80053.outbound.protection.outlook.com ([40.107.8.53] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHgJ5-0004T1-37 for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 04:41:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=no3aEZIVfafDU0g1Vk+0rY3v5K8/boxynHwzHfkOnWg=; b=pkK+i4OKvrweczoaFGIFPdMFt7pcEvTsGVv7ENNyEeGOglLZuHEX7Zv6daFNa0tpbR/gL+9SrnfHUO4Fmi/V7P9pqrHIwyli9UXgaTx+Xry4yQLrhQ8m/JGeN6wHf9oF53vMKLFwnwzCdJdb0pGLnsC7GRc/UPThlFPnZsXGso4= Received: from AM6P192CA0062.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::39) by AM0PR08MB4403.eurprd08.prod.outlook.com (2603:10a6:208:141::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Mon, 14 Sep 2020 04:41:28 +0000 Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::67) by AM6P192CA0062.outlook.office365.com (2603:10a6:209:82::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Mon, 14 Sep 2020 04:41:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Mon, 14 Sep 2020 04:41:28 +0000 Received: ("Tessian outbound 7161e0c2a082:v64"); Mon, 14 Sep 2020 04:41:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 36a9696eb03fc44d X-CR-MTA-TID: 64aa7808 Received: from 56a215cdb72a.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 81BDDEF5-363D-41BD-AEBD-133AFB83078C.1; Mon, 14 Sep 2020 04:41:23 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 56a215cdb72a.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Sep 2020 04:41:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kWuij2RUpXWstfI/uPQ45FBrQhjIv3htvR+5LHunBJ9qZPi7tALJnv3hdbsYzFYWcGjhfAKglxpPi8q/ybHSX+VlwmytxJQgoYd/Wr3f/HymMbRXYMS/vhqE8p5o/T8agwyFTi3oLAvVh/0Yunj4rpgXATjh31JDw7H/6YBcB0al2TtsBYrr1BQOu3JYDxwEcfJVFK6QqvjjfFNgsCqO70Dtz9HOSEj75llZmqhC8/KJ4S+F/5Cq1i708wlnC9j4rvlpbHXqvNuyP9k/Vt2xljXsogs0Wn7jZuYmPOmLGRIC/tciihJkXN18GKM3B/hFHX6IeYc/sckCUFx/7bOl5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=no3aEZIVfafDU0g1Vk+0rY3v5K8/boxynHwzHfkOnWg=; b=T6aW06gCLqxkHkfooTZvt1K8NPUGszNiDKCS1jSz9jnb+xTN2jWH36EVOGFszm+kPQTQmjijxS0Evq5Iyu5JXdUf2IomFFlCvS8a60VeOw45LRf4JDmH4f5l1Ee2PGTcJwnPTDoinN0yulFoDBV7mhc/T0f7OsBuDndgNLbewNU2/z/Dt//WdX3qvbQSU4gHTJ6DnIXOKDCRs0qGq9ggwu2zE59VPITpueUhTm0/QE+7u0g2ju/HNNeQfFpI889hwDqNXa7SoxKjiBIAjFgbFP4Q8N/tzHAHi8IWbGjFJXZ37Fv4TyQ3lRrrJNQEX0IC7WpbzgrTQzT0Rv6Ai+kRgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=no3aEZIVfafDU0g1Vk+0rY3v5K8/boxynHwzHfkOnWg=; b=pkK+i4OKvrweczoaFGIFPdMFt7pcEvTsGVv7ENNyEeGOglLZuHEX7Zv6daFNa0tpbR/gL+9SrnfHUO4Fmi/V7P9pqrHIwyli9UXgaTx+Xry4yQLrhQ8m/JGeN6wHf9oF53vMKLFwnwzCdJdb0pGLnsC7GRc/UPThlFPnZsXGso4= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from DB6PR0802MB2598.eurprd08.prod.outlook.com (2603:10a6:4:97::20) by DB8PR08MB4171.eurprd08.prod.outlook.com (2603:10a6:10:a4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Mon, 14 Sep 2020 04:41:20 +0000 Received: from DB6PR0802MB2598.eurprd08.prod.outlook.com ([fe80::5807:d5a5:e875:484c]) by DB6PR0802MB2598.eurprd08.prod.outlook.com ([fe80::5807:d5a5:e875:484c%10]) with mapi id 15.20.3370.019; Mon, 14 Sep 2020 04:41:19 +0000 Date: Mon, 14 Sep 2020 12:41:13 +0800 From: "james qian wang (Arm Technology China)" To: Robin Murphy Subject: Re: [PATCH] drm/komeda: Drop local dma_parms Message-ID: <20200914044113.GA1918670@jamwan02-TSP300> References: <8de297b5b916628c77b99068fb5aac1a69eed6f5.1599164796.git.robin.murphy@arm.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SG2PR02CA0071.apcprd02.prod.outlook.com (2603:1096:4:54::35) To DB6PR0802MB2598.eurprd08.prod.outlook.com (2603:10a6:4:97::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (203.126.0.112) by SG2PR02CA0071.apcprd02.prod.outlook.com (2603:1096:4:54::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.17 via Frontend Transport; Mon, 14 Sep 2020 04:41:18 +0000 X-Originating-IP: [203.126.0.112] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b241ca4f-8158-4d58-c571-08d858687224 X-MS-TrafficTypeDiagnostic: DB8PR08MB4171:|AM0PR08MB4403: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:813;OLM:813; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wO0XOMUkU92G+yV0cGTFJu6ayv2BKmSlsfrVdzWhB7fKLf2ulr6K6MLwgkdfjizjWZQLBRWcULdxzhcvIbLg3vwEqJXVeTVE4Z07nzCMR5A7WeVpXGkyf3N9Qj8ptralLeHCqHYfuina2czlakWPodydnBGUO1ZuI+2+VwuhKO7HKU1BBvxFrIZ92T03j8XLrxX7zlFy2Vv5HGmHATiTWQ+WuBIr6uHxFmFBsfHLQtg8FOL6TXG5JHXpcFhhptyReHcXVzopP8WVfZ4lYBbtZi8eHYcmCC95e6Iq9kC/znOHixFipZV3VwU6FSCOAWQau1T5np549n844uSeClYBG0oLnMnblGfpvNVKiaU/BEA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2598.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(7916004)(346002)(136003)(396003)(376002)(39850400004)(366004)(52116002)(478600001)(6486002)(5660300002)(53546011)(6496006)(6862004)(83380400001)(66946007)(966005)(4326008)(316002)(33716001)(86362001)(6636002)(66476007)(2906002)(66556008)(9686003)(6666004)(1076003)(16526019)(186003)(956004)(33656002)(26005)(8676002)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: NLk40NzefRRo3Tp5XYDNzi3qggI4sK/jzXWAWim5Hcu+T/+egv/n3p+zbXjpy/c8t0oldGn/ivRoUqGfeiufzLNWsxurEguDmCkw8ynaYtZEScnyrYvRyq8PYUD+CAtByXcTpdXEzk78vWI4MPStrZRRZl085TH8M2Clzp32vxFi9iD0imqW7MuDVdUj1Pxvce92W9ls0tuW0JVFDrWMZP866BZdEbq1IcnUGJ/pBsIaSiCuHYfYmVAgpNfI2hg75sdW/5UyJng/YKZ4+j6noxOmVVaMRlmKH8AKVgSij+GbI12Lb8S82u4zefBDLioSXc6K1qi/sxLMVPefWUIhaFljxQPdkjTMfbE1tayQ9mJQCTUVxcKT4Sl5UyqvMoM5akixf+DxKgLrRLJWk+TrYO5Pp/lnsGAgkyyuysBQ+qkvQ/E4+jVs6KhHPbjo/qvIKRTDeo3SPkpwcRKeP/i+dMmZ53466kh47Hj3mhC/ZYLOvsG+26CeqlAqJ/ekedcrNaab4/6YmDReiYgSokqlnFPX3ilJuS4YoxfO7pluVLRUfKC72jU38W3uQJNT7NNWDYKbGbSOhv6+62KakDNRhfTBwTpLzmpPkwxJzmPyOltTkC5vO5hMFu/Hq1AQM7f6wc0qxrIlFaS1RAHCJUOJ/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4171 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d3612934-7985-4ae4-2b0e-08d858686c93 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BgpyHG7B2PBp9155ROWuL25jV6Y6/m7b29yp8y3XseEdpmrEGXiflJLhSlAkeoPSpLryb9I4W/Wk8PkzJdryNtnUWb7UEGq4YyX6hCIaodNrbYicjDm91+zpMCXJpds9kzwyPVznueEh3ZXRTByT+7GQPTSdeo8C7G8TqC89JLoxJXT6qXWm9+nJP3Xdw3bU4P87+O7/DaeTI9PFbjo9xzrmmVYYlcglWRZwc4FE23SJGxUpBS8xdN/bDB+uuSQBmElwITL2ovXBkwyTuFPOhSEkjgwv221HtAwgXbd8oblMrDcprXkccK3CGQIlEdlrPdVEVKyFT+tv7Hs21GxhFQM3YJYF4riWm2S3w4soepzpHqh9EPdpxOt3NF9fZHxvUKhpmHRHqZY1N+I6yn/X9JJ220obAHA08BIOuAJidF4hPbf1WIaofJtt5rlLE8RQ X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(7916004)(4636009)(39860400002)(376002)(346002)(136003)(396003)(46966005)(8936002)(316002)(956004)(478600001)(36906005)(5660300002)(336012)(16526019)(33656002)(186003)(70206006)(6666004)(8676002)(26005)(6636002)(4326008)(70586007)(2906002)(83380400001)(6496006)(81166007)(6862004)(966005)(82310400003)(86362001)(53546011)(356005)(47076004)(6486002)(9686003)(33716001)(1076003)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2020 04:41:28.6921 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b241ca4f-8158-4d58-c571-08d858687224 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4403 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_004135_144132_E48DC6D7 X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mihail.atanassov@arm.com, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, malidp@foss.arm.com, lowry.li@arm.com, nd@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 10:26:50PM +0100, Robin Murphy wrote: > On 2020-09-03 21:36, Robin Murphy wrote: > > Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms > > for platform devices"), struct platform_device already provides a > > dma_parms structure, so we can save allocating another one. > > > > Signed-off-by: Robin Murphy > > --- > > > > FYI, get_maintainer.pl seems to be choking on your L: entry somehow, > > since it just shows " (open list:ARM KOMEDA DRM-KMS DRIVER)" without the > > description or address, not sure what's up with that. > > > > drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 - > > drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 -- > > 2 files changed, 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > > index 1d767473ba8a..e7bb905062d9 100644 > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > > @@ -261,7 +261,6 @@ struct komeda_dev *komeda_dev_create(struct device *dev) > > goto disable_clk; > > } > > > > - dev->dma_parms = &mdev->dma_parms; > > dma_set_max_seg_size(dev, DMA_BIT_MASK(32)); > > Oops, I missed my "Also the DMA segment size is simply a size, not a > bitmask" bit here - ideally this should be changed to UINT_MAX while we're > cleaning up. Maybe that could just be fixed up when applying, but let me > know if you'd like a resend. Don't worry, I can fix it when applying. :) And thank you for this patch. Reviewed-by: James Qian Wang > Cheers, > Robin. > > > mdev->iommu = iommu_get_domain_for_dev(mdev->dev); > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > > index ce27f2f27c24..5b536f0cb548 100644 > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > > @@ -163,8 +163,6 @@ struct komeda_dev { > > struct device *dev; > > /** @reg_base: the base address of komeda io space */ > > u32 __iomem *reg_base; > > - /** @dma_parms: the dma parameters of komeda */ > > - struct device_dma_parameters dma_parms; > > > > /** @chip: the basic chip information */ > > struct komeda_chip_info chip; > > -- > > 2.28.0.dirty > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel