From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB46C43461 for ; Mon, 14 Sep 2020 05:54:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9EC320639 for ; Mon, 14 Sep 2020 05:54:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MsNWuUWZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o/X10V9O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9EC320639 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pg4fAxUxoolYfMbWEDZWozS1pr33PUR7o4QCeWDYHho=; b=MsNWuUWZtuwno4pZD19Pyfehm Ts8QwU3y3izzdLPVRmJfs0J6TR8WctXMeLenPulZy9TUxVslmXrZ91Lnfb79PS8K44LfJ5FFNoHtG eS3fNLfpPMcAXqJE0BUB2a5mOXBsQxpMRebGz1SOefffvxYPb+RyTkYh69OtEUvF99XPRG2H2mWfb 0kh2ra6bZXGEcOho363mCdKUEwT50EwVgAksqlQq242vlm15TvnVl0TZVgYeTtJCrakN6HbyW040I aJQt3P5Soxyai85fhfxCWvvDVbs3n1jNP6DeVBowrvRaz2R+xqm7NjdjrELY8UmqnhBXWKTFi2Qgv mD5D5wVXw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHhQY-000141-9T; Mon, 14 Sep 2020 05:53:22 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHhQW-00013S-4q for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 05:53:20 +0000 Received: by mail-pf1-x442.google.com with SMTP id d6so11662930pfn.9 for ; Sun, 13 Sep 2020 22:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Fu+Unq5S6ACh7iYsqq0q6WI21x0YuOKv2but7DIYHco=; b=o/X10V9OrT4RY5VME92I67Ty5nMf/YdeZnF4osFSsDvxrcqLjrieCBh/BuQxCo8Odl GJZ05F1zlzMzPte84nYm6xExf0+97izmbQT/DvQDBpukvyTFRGYw/bKTb7f17HFk3UKO 9X9DHs7/l17ZiTa+qrC2r9b3xbn4yek/kHH/pA0x5R7sdm90rlo0rTgD2XfEwf61RbS2 L9lbVMniijOCyro99DIa0Tu2eW+hu4jZvOk/qaqYXomiyItVwy8g4LStZkTl/4a1TdZM dYAFaYEA/ld9TZBMvtPvAljAsSNRXLaDHXBwMQECCJVDbH4qqZ7JaVVqMo2bJCAnIJsV o3jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Fu+Unq5S6ACh7iYsqq0q6WI21x0YuOKv2but7DIYHco=; b=a05bP9nHurLNBub3uql8SBWS0xG5ncsTFNAqKrt9c0sgGOBMenaB3wPcDvQGvJHD8x TszMSWlUqIKRW/HNJpse23NdZDWB7LL86r5+/Kw9/pfD7GblNeBY46BfAT5O+w+qpNVY Bcqk1LQ6ET1NQmlzuDn6FawEHyEeAOTG2lDrcoC+1uoqBADI2O1ZVs7yO/lkliJop7Dz vSqMvR3Xdm5bs2TWNiKOFM8fWullvLsn36uz/ZoPKaUBRZ13xqsNAfKxivSKWwTNAvrM zAtNNOprySmpeSLlmmneCMbL4l1H0XNXhEPK+Oe0ba4X4mwB0DxJ9R1NvNukRPolRWFN Jg7w== X-Gm-Message-State: AOAM5311p+W3ROcYCrBcytnuzgY6GXdTDCMvewISwePap4+V4KSqfKKu k8YneM2LfdYwvoA8ph2op8A= X-Google-Smtp-Source: ABdhPJwtLsRNLtWA3y2GtumiwQhYjfTb+m+yPk/jEtTINjVXfSq6KN2ZYqJ/Sw2Ya7XHIe8ichHrsw== X-Received: by 2002:aa7:86d3:: with SMTP id h19mr12315138pfo.84.1600062797975; Sun, 13 Sep 2020 22:53:17 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id m21sm8836737pfo.13.2020.09.13.22.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 22:53:17 -0700 (PDT) Date: Sun, 13 Sep 2020 22:53:15 -0700 From: Dmitry Torokhov To: Fengping Yu Subject: Re: [PATCH v18 2/3] drivers: input:keyboard: Add mtk keypad driver Message-ID: <20200914055315.GJ1665100@dtor-ws> References: <20200909072159.14888-1-fengping.yu@mediatek.com> <20200909072159.14888-3-fengping.yu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200909072159.14888-3-fengping.yu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_015320_231384_F40A3E40 X-CRM114-Status: GOOD ( 12.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Marco Felsch , linux-kernel@vger.kernel.org, Rob Herring , linux-input@vger.kernel.org, Yingjoe Chen , Andy Shevchenko , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fengping, On Wed, Sep 09, 2020 at 03:22:00PM +0800, Fengping Yu wrote: > From: "fengping.yu" > > This patch adds matrix keypad support for Mediatek SoCs. I am generally happy with the driver, however I do not believe this will be the only Mediatek driver ever. Do you think we could rename it to mt6779-keypad.c and use mt6779_keypad_ as prefix for function names? Thanks! -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel