From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37AB6C433E2 for ; Mon, 14 Sep 2020 06:52:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8977207EA for ; Mon, 14 Sep 2020 06:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PQWYCVAY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JA5RE3JQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8977207EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YQluswEHDDqyXrw4XoXmVmQNGXxjRaN0nNttDf1Pwpg=; b=PQWYCVAYrCdCOFo+x1klA7o9g BzlJTyeCuWCcGzdaLHxA3XV8whfi43J9jqxm4Gd8lnIyc6PGlfA6w2k8mtzbNSLu2e/CdAf47iq44 NguI5+4vkK2zQohXS4rMcG1AkPfk4A1ZEYq1+TvmjKUJE/nhT9dU7go4p9SE2uj+kUgn/zTDDIi6G XRDq4Je7QZurqZX/QH89gLxKFP4yFy9aUuy1SgjH7gsvmyos0K+m4SzIcO5Rtol79hMm16K32TPda WJKWVHXCT3d2sPqNjYp39oY9RPDtY8dDTfs5ntXs/C90cXtEG0nAzrsD/AQbiO6S52SlxoRSOBUPD mlTZLPr+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHiKl-0006ld-TD; Mon, 14 Sep 2020 06:51:27 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHiKi-0006l8-VR for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 06:51:25 +0000 Received: by mail-pj1-x1042.google.com with SMTP id gf14so4828877pjb.5 for ; Sun, 13 Sep 2020 23:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p2zmhweX1z0dNfm8y+V4dmpOWaiz24f2OWgMEDZh9Uw=; b=JA5RE3JQFRWUgky8bJ++/ylRWzlPa795/PoQp/GRAeY4zRe6dd/gikgApfrvM77ZP9 VE+8eQaBsHwiNNkVKrfLpxJqobDFgUdczaEsEEMyie174TMmKaeMekVJ3QsL0dr9neut qstvoZZTvLr/82mboW3vQB0YExvKiE8OCEtQKartUtpYc/kSB6XOl1tKvEn6rjLjqS/j 5wVKOAmv04YnXbH5ssOLxESOEY1fkldO3p7bZcYSCAufq8b1WNQSGE7Mgvjka09TPH5T t2T4SVlSENRfvz73UrzVwzErY9qQej+LL/MhvNyVlmzH5ewVH6Gwx30Pw6keYPtxm94T GElw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p2zmhweX1z0dNfm8y+V4dmpOWaiz24f2OWgMEDZh9Uw=; b=GcomCCOghIZVpXz7YIzJzIDrDwrazdP0cmwp44eJlTfDx/lnXMI6X9psBQrD44pFi/ 1CLKYwWjJmeaIj7jr6oBoJUZJhqGRiJHIk4fl9z86/KEOmw2OWMPbuIgaDvBr+O4HwJz mDrAZhWU+MwR5ceJtJ3mmHO6hm3a9niPmkDVEsTNtlljDrgGymchHgUTzIA3szgOl0ij z5EdlyJQSPfhFRDGMLBtBwa4fw0pocS4N3Y9ykozudMN3evlRBjhFaAlfdd08ACSGO+3 O3njPHg3DPMnFFTZlANJKW/yUNXHjLix91Knt7geZ8zdm2ydztOBU4lWGzxvMbl+8wlB Sttw== X-Gm-Message-State: AOAM5308BTnZkU3EiiurATmrgVUAMZVwaffUdPOUIBbtM0u66bbpwbs5 6zPSuisVDLiFIs9wCMEfidU= X-Google-Smtp-Source: ABdhPJwWQWUWdJOIsiYLs+DGdeyQF4Qu/H4TexwkwBK7MatQTCrW9RF8gSna/yxW0MIsFq4stO8QnA== X-Received: by 2002:a17:90b:317:: with SMTP id ay23mr12523401pjb.68.1600066282946; Sun, 13 Sep 2020 23:51:22 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id x5sm7437688pgf.65.2020.09.13.23.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 23:51:22 -0700 (PDT) Date: Sun, 13 Sep 2020 23:51:20 -0700 From: Dmitry Torokhov To: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/4] Input: ep93xx_keypad - Fix handling of platform_get_irq() error Message-ID: <20200914065120.GR1665100@dtor-ws> References: <20200828145744.3636-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200828145744.3636-1-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_025125_139176_18CC974B X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, Maxime Ripard , linux-input@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Fri, Aug 28, 2020 at 04:57:41PM +0200, Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. platform_get_irq() is a bit of a mess. Historically we allowed defining interrupt resource with r->start == 0 and for such cases non-OF non-ACPI code will return 0 from platform_get_irq() to indicate that IRQ is not assigned. We either need to stop doing this in platform_get_irq(), or the conditions in this patch and followups should be "irq <= 0" and we need to make sure we do not accidentally return 0 from probe ... Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel