From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7A8AC43461 for ; Mon, 14 Sep 2020 09:42:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E7B920759 for ; Mon, 14 Sep 2020 09:42:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OTR9crcQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AGEBogUO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E7B920759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AuURhM2v0gWvnPKJoRr81EtctjzUAhtnNUih7KUSQ58=; b=OTR9crcQZCf40KGiMCISUa4+e 3UBNXjW2vESUaZShhEKS3YTKHOVgRDxgq1LDz/DA23Rci5FCmDVnYee05kNe5VxjmVn7XTfg9POgI zFL1AkXRVFz+4TDRTuvsc7mKBRDk7/1v7Z6v98HuIs67NeGYpaKzIVpwiiABhsV6FQ/gAO5c/EUcs spKLwHFR1i7804Moc4nPEMhD6UpDpT4JpgR3nd+kbCEMKbMjl9TeVhvMY3Y+6nKpP6sCUocpClktH equAAbcRovjKFDlm3earZSd+ScOgdUExRiuC2B6iY/WhKHo3lFpGRXVrX9ICJnR+0COSy28qEtMab CeMOzhUuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHkyM-00072V-9B; Mon, 14 Sep 2020 09:40:30 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHkyK-00071w-6k; Mon, 14 Sep 2020 09:40:29 +0000 Received: by mail-wm1-x344.google.com with SMTP id y15so10544955wmi.0; Mon, 14 Sep 2020 02:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Oa/d3xtFztG+1F7w19dQiVtlu9Ybx4E8vqCz+GkkWv0=; b=AGEBogUO2qjGXPbZL1EyaiB+BBFdsiMZWEuO1LtyMcB/4AwV2jHRX/lx/vkvFTCu6S quL/QSsqfW7UgmZaDc+s4XoJcrVFOUJXNZwCBJ5KF/3a9DTZo3RdxFVm616Jhn5/+DbW 3ZH0279gI7YaGB03iQA5ug9qCvEeWVNrk8cNmdwNiL1AaUFzCo/OWlCgxUIH6T4D22oc jOYa6I4oWrVTYQ6PYtum9T8Hd9kXrCtdjWiv+wjzKcv7mzn3KbYsYHUIqOWT5duJFnAO JSTkurAw3D8DUKteYEqHtAvh9YMTk653PtUL6rzmKvPT2lbeU3hUN9ocdWo31K6P4BZP 78xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Oa/d3xtFztG+1F7w19dQiVtlu9Ybx4E8vqCz+GkkWv0=; b=ctynP81qdAS24Prr14sRGyJL850C0+hjKIxmQl+j6Vj5evvMISC7yHwXRB9JrqQFLi JF1qunCFC1+RwYNymMltEzTtPPCyBuAEh0wic0gMQa1AqjlHoORcRxBJrMi3ToGosOLJ XNu8/YqeXd2vLWfPd7cyslnPR45fPPO90RnnCZlBZkZY2dHMWCsZAScjH02/B4Td+1L0 tXZVb9sPILH6LwRNfPBbwrM6QM0KOXC54ufElAww2bMe6kr26rDQqt8+PGx2V+xBwhVh lkS8kVdS1wAn+I/F2tb20Hme9or0ccW9+pNFtDoZojbK2eFZ0HjBAqkGboOualyma5CX Zisw== X-Gm-Message-State: AOAM533OnSQRIGU2QmNlBByT31liTB5YjqdFGUI9paREfYmdwT43kA3f KV20vsJ+3yMQ99VWK7Z5MKY= X-Google-Smtp-Source: ABdhPJx3EnwiLrRH4iajYzlGQZXDgrJVsN38lzsgiKh9dSdXDiV118y36fEPOvkrSFv+GaJ0WV5JbQ== X-Received: by 2002:a05:600c:2207:: with SMTP id z7mr14294699wml.42.1600076426625; Mon, 14 Sep 2020 02:40:26 -0700 (PDT) Received: from BV030612LT (oi48z9.static.otenet.gr. [79.129.51.141]) by smtp.gmail.com with ESMTPSA id u13sm19261555wrm.77.2020.09.14.02.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 02:40:25 -0700 (PDT) Date: Mon, 14 Sep 2020 12:40:22 +0300 From: Cristian Ciocaltea To: Marc Zyngier Subject: Re: [PATCH v6 2/3] irqchip: Add Actions Semi Owl SIRQ controller Message-ID: <20200914094022.GA12167@BV030612LT> References: <1167b847f6fe1da3834aeaadf5710ddac54f06a0.1599552438.git.cristian.ciocaltea@gmail.com> <20200914070227.GA4491@BV030612LT> <20200914085154.GA8474@BV030612LT> <0cdd2fd4e09c7e51b8b48be914c6846f@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0cdd2fd4e09c7e51b8b48be914c6846f@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_054028_258463_DE377622 X-CRM114-Status: GOOD ( 34.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, parthiban@linumiz.com, Parthiban Nallathambi , Jason Cooper , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Manivannan Sadhasivam , Thomas Gleixner , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org, Saravanan Sekar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 10:19:31AM +0100, Marc Zyngier wrote: > On 2020-09-14 09:51, Cristian Ciocaltea wrote: > > On Mon, Sep 14, 2020 at 09:07:18AM +0100, Marc Zyngier wrote: > > > Cristian, > > > > > > On 2020-09-14 08:02, Cristian Ciocaltea wrote: > > > > Hi Marc, > > > > > > > > On Fri, Sep 11, 2020 at 05:22:41PM +0100, Marc Zyngier wrote: > > > > > On 2020-09-08 09:20, Cristian Ciocaltea wrote: > > > > > > This interrupt controller is found in the Actions Semi Owl SoCs (S500, > > > > > > S700 and S900) and provides support for handling up to 3 external > > > > > > interrupt lines. > > > > > > > > > > > > Each line can be independently configured as interrupt and triggers on > > > > > > either of the edges or either of the levels. Additionally, each line > > > > > > can also be masked individually. > > > > > > > > > > > > The patch is based on the work started by Parthiban Nallathambi: > > > > > > https://lore.kernel.org/lkml/20181126100356.2840578-1-pn@denx.de/ > > > > > > > > > > > > Signed-off-by: Parthiban Nallathambi > > > > > > Signed-off-by: Saravanan Sekar > > > > > > [cristi: optimized DT, various fixes/cleanups/improvements] > > > > > > Signed-off-by: Cristian Ciocaltea > > > > > > > > > > Who is the author of these patches? If this is a co-development, > > > > > please > > > > > use the relevant tags. Otherwise, the author of the patch must come as > > > > > the first SoB. > > > > > > > > I took the authorship for the driver patch, as mentioned in the cover > > > > letter. So, if I understand correctly, my SoB should be moved on top and > > > > I assume I also need to drop the related comment line. > > > > > > Not quite. Please look at > > > Documentation/process/submitting-patches.rst. > > > > Yes, I have read it, but most probably I missed the information that > > clarifies this authorship change handling. > > > > > If Parthiban and Saravanan haven't authored anything in this patch, > > > then drop them from the SoB list. > > > > Sorry I haven't properly explained this before! > > > > Their contributions to the driver code stopped in 2018, when v3 of the > > patch series has been submitted. > > > > > If they have contributed to the > > > patch (which I expect), then their SoB must be preceded by their own > > > Co-developed-by: tag. > > > > Starting with v4, the work has been done exclusively by myself. > > > > > To sum it up, it probably should look like: > > > > > > Co-developed-by: Parthiban Nallathambi > > > Signed-off-by: Parthiban Nallathambi > > > Co-developed-by: Saravanan Sekar > > > Signed-off-by: Saravanan Sekar > > > Signed-off-by: Cristian Ciocaltea > > > > > > This is of course an assumption, and you should check it with the > > > individuals above. > > > > I have recently contacted Parthiban and he agreed that I can take the > > authorship. So I should proceed with the 1st approach? > > The authorship of the patch is one thing, acknowledging the work done > by others is another. As you said above, you started by contributing to > an existing series, instead of writing it from scratch. You changed it > to a degree where it makes sense for you to be the author of the patches, > but it doesn't invalidate the contributions made by others before you. > > Unless the two other contributors explicitly say they'd rather not be > named, I don't see how you can avoid mentioning them. I just want to do the right thing and follow the recommended procedure. That's why I initially kept all the SoBs, but obviously I still missed some bits and pieces, as you have pointed out. So I will add the indicated Co-developed-by tags and resend the series. > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... Thanks a lot for all the clarifications, Cristi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel