From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E25C43461 for ; Mon, 14 Sep 2020 17:56:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3497020757 for ; Mon, 14 Sep 2020 17:56:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SfGqSeQ2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cuUAU+84" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3497020757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gO1DInmd5QE7OVgvQFQXTzQ9B92Axx2giK1oC8aIgG0=; b=SfGqSeQ2j/sxniviCjhvG4Hhi YkC0xpqq2di5x/uwQ8ONZsCFcwlpCS4w2F2ypeb5N+Sy+WR6iAzaX7Qy5oMgr+BhwyYcpnn96aSDk oi6K5cIE8wiJEOvrYv+PgCih/Lg8oUjyPmmFcVE8/b4/v9nSe3ikpgD2PceRvy2etlKYvQy/Lbqmg U7ro0ztcZfMJYOKj+9vwhdN0m3shPn+YB1c6E3ZL/VE5O7gnzq4u4o3WQzHfW+rc24YA6vAKTSRVP cvCzI+peURE7tMFrm6IEVSAR5QHbdyUIMSLGe++P/1WY5j4dtjcI2dy9QeBGuzr66cGD+Ckn8eVE/ 3nbcD44hg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHshI-0007Kj-Ml; Mon, 14 Sep 2020 17:55:24 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHshF-0007K3-OA for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 17:55:22 +0000 Received: by mail-wr1-x443.google.com with SMTP id w5so565109wrp.8 for ; Mon, 14 Sep 2020 10:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ElTPUcJchCYTclnWFUBApUOoz+YOl4EkZJsBh9Oqm7M=; b=cuUAU+84+bcCRcYFw24CLpKHuNITQXf7p1urQVL6RK2/oJ82K5sGJ7v8hFQl8OLRzW BpJ5DH1ife5I/JNXJXeJag5YfpeHRzta3aRoyoWgrxYpHfo3Bxh9Q1RdHFp767MxpMiN kBgTYshqVFgh5dLQzQo00R9KpldmpYXljcrUx9bF5marV5dhEmtXDOdP06ailrdgGxN7 cCH3A+LIVosl9ceKMEf97poi7u4ALax9x1gN3UaYI5CxPpruirn0WDgdZduFgslniK0V Y1ajWQwkeV9DWZLtvtizhbT7e2v3GsHQhj+HAOTjqB664Ibm4Hy2TcNd0c6hSFpigaDL juvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ElTPUcJchCYTclnWFUBApUOoz+YOl4EkZJsBh9Oqm7M=; b=qvYRDCp5W4+Ckx6vceAZtT/wFO3yxtBUIAflzeYVulKj5odSg0dtY88pbe0558SDG8 Rase3JFX4fvb5ql2HxXlkVpibHbRtN2PhLBnpGrmn8/xu1OheGdRvGAaOLIll+u2NWMl 61ggo7dUcjOxRtXolENAGlphKdDkAecD9tBXVpX7tmYTSHC3ggG6MF5yULQc/L4E9qy/ yzeGQDh4S+BPPl3Lq0m/mKk8DY7aBHm2dBu/cuB/Vkgzrfg4JYPIqEs1Pdyjh6W5SqMU eyuD9Wx5YQ2NPM3vrA35HbJCvM1FSuJv1cVuvErxId50A7htIHJMRG+RLNMDhOvxwimC EtRg== X-Gm-Message-State: AOAM530xk6gKSTa0WgTvR9dczhkVroMoahJ19B21CNgFHLsHyBAayRlN aJQCaEsrZ039Ol8kgVl54r3IDQ== X-Google-Smtp-Source: ABdhPJz9ziJomH7g1dR+TzMKnxXTi2GW1hQ4O1t+pe18I3Wwg19+Ume2JlE/+x+dZr59Qo76NAwTfA== X-Received: by 2002:adf:e989:: with SMTP id h9mr18323596wrm.38.1600106120650; Mon, 14 Sep 2020 10:55:20 -0700 (PDT) Received: from apalos.home (athedsl-246545.home.otenet.gr. [85.73.10.175]) by smtp.gmail.com with ESMTPSA id 189sm20952801wmb.3.2020.09.14.10.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 10:55:20 -0700 (PDT) Date: Mon, 14 Sep 2020 20:55:16 +0300 From: Ilias Apalodimas To: Xi Wang Subject: Re: [PATCH] arm64: bpf: Fix branch offset in JIT Message-ID: <20200914175516.GA21832@apalos.home> References: <20200914083622.116554-1-ilias.apalodimas@linaro.org> <20200914122042.GA24441@willie-the-truck> <20200914123504.GA124316@apalos.home> <20200914132350.GA126552@apalos.home> <20200914140114.GG24441@willie-the-truck> <20200914181234.0f1df8ba@carbon> <20200914170205.GA20549@apalos.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_135521_796497_E403F0EF X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Catalin Marinas , Alexei Starovoitov , Will Deacon , ardb@kernel.org, Jean-Philippe Brucker , Anders Roxell , Daniel Borkmann , naresh.kamboju@linaro.org, John Fastabend , Zi Shen Lim , Jakub Kicinski , Andrii Nakryiko , Jesper Dangaard Brouer , Jesper Dangaard Brouer , Yonghong Song , KP Singh , linux-arm-kernel@lists.infradead.org, Yauheni Kaliuta , netdev@vger.kernel.org, Linux Kernel Mailing List , "David S. Miller" , bpf@vger.kernel.org, Martin KaFai Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 10:47:33AM -0700, Xi Wang wrote: > On Mon, Sep 14, 2020 at 10:03 AM Ilias Apalodimas > wrote: > > Naresh from Linaro reported it during his tests on 5.8-rc1 as well [1]. > > I've included both Jiri and him on the v2 as reporters. > > > > [1] https://lkml.org/lkml/2020/8/11/58 > > I'm curious what you think of Luke's earlier patch to this bug: We've briefly discussed this approach with Yauheni while coming up with the posted patch. I think that contructing the array correctly in the first place is better. Right now it might only be used in bpf2a64_offset() and bpf_prog_fill_jited_linfo() but if we fixup the values on the fly in there, everyone that intends to use the offset for any reason will have to account for the missing instruction. Cheers /Ilias > > https://lore.kernel.org/bpf/CANoWswkaj1HysW3BxBMG9_nd48fm0MxM5egdtmHU6YsEc_GUtQ@mail.gmail.com/T/#m4335b4005da0d60059ba96920fcaaecf2637042a _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel