From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D707CC43461 for ; Mon, 14 Sep 2020 16:15:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6759D20732 for ; Mon, 14 Sep 2020 16:15:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iHVk8d7R"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MrIP/oxA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6759D20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GCvlpIkosHYYOXdT8OTYkdwKQbMDO60tEeusFK7v+oU=; b=iHVk8d7RnA3lc3RIrGtNiurFp f+hIdC/r+WAkS+v/X3nfz1FGtPVQ0pDnsqLQZusAxw9v0i5akTUsW7GUpb1x9bWJrf0/2Enni8d34 sBdZqcX5o18pXDRMUIs17/GRIqfgeOxvGQA4NvQNS2Hn5B/NkAJdOR1ytr4Basz/3rnsOTQXBiwge cbWYBbrHAw+MgZ/37TE+jEvNAJHVOai+VGRUolB19vNc2kMVB5R9hPWYXbbWOQmBcRy5WxtisEKTm 15dZd0vcG3ZkPHgkVCZIumtu3+jvZnqYwwS3hOZZw5T5nbHrjIB2V/SHgut4nwuYcbdXxs+L7wURh 0p7QcEjcg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHr7S-0001Vi-Lx; Mon, 14 Sep 2020 16:14:18 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHr7O-0001UH-SM for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 16:14:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600100053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NMcjuPLsban/s/KhGcm7R6jbGaWdBO7FK18RrhrF4m4=; b=MrIP/oxAaBnwY3SS/cDBPkEHSiu12iLNaK6oGvy5nUAkrsdd16fcZkKA+FjI4TnVSfC/Li 5ZGK5mjTKbPW6mQhJX9DKmUOFo8w8PgAtZ1l0mB/6jRGPHkFusQP/3SXIYJM/FS5FSa9WI pHxTgmSFOsN/PivmEvSh53J1qO4Q1Fc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-lmWKx1gVNNS1mWTiGcUWJw-1; Mon, 14 Sep 2020 12:12:52 -0400 X-MC-Unique: lmWKx1gVNNS1mWTiGcUWJw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7981D425FD; Mon, 14 Sep 2020 16:12:49 +0000 (UTC) Received: from carbon (unknown [10.40.208.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BA4B7EEC9; Mon, 14 Sep 2020 16:12:35 +0000 (UTC) Date: Mon, 14 Sep 2020 18:12:34 +0200 From: Jesper Dangaard Brouer To: Will Deacon Subject: Re: [PATCH] arm64: bpf: Fix branch offset in JIT Message-ID: <20200914181234.0f1df8ba@carbon> In-Reply-To: <20200914140114.GG24441@willie-the-truck> References: <20200914083622.116554-1-ilias.apalodimas@linaro.org> <20200914122042.GA24441@willie-the-truck> <20200914123504.GA124316@apalos.home> <20200914132350.GA126552@apalos.home> <20200914140114.GG24441@willie-the-truck> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_121415_094252_B1369A42 X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Catalin Marinas , Alexei Starovoitov , ardb@kernel.org, Jean-Philippe Brucker , Anders Roxell , Daniel Borkmann , naresh.kamboju@linaro.org, John Fastabend , Zi Shen Lim , Jakub Kicinski , Andrii Nakryiko , Jesper Dangaard Brouer , brouer@redhat.com, Yonghong Song , KP Singh , linux-arm-kernel@lists.infradead.org, Yauheni Kaliuta , netdev@vger.kernel.org, Ilias Apalodimas , linux-kernel@vger.kernel.org, "David S. Miller" , bpf@vger.kernel.org, Martin KaFai Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 14 Sep 2020 15:01:15 +0100 Will Deacon wrote: > Hi Ilias, > > On Mon, Sep 14, 2020 at 04:23:50PM +0300, Ilias Apalodimas wrote: > > On Mon, Sep 14, 2020 at 03:35:04PM +0300, Ilias Apalodimas wrote: > > > On Mon, Sep 14, 2020 at 01:20:43PM +0100, Will Deacon wrote: > > > > On Mon, Sep 14, 2020 at 11:36:21AM +0300, Ilias Apalodimas wrote: > > > > > Running the eBPF test_verifier leads to random errors looking like this: > > [...] > > > > > Any suggestion on any Fixes I should apply? The original code was 'correct' and > > broke only when bounded loops and their self-tests were introduced. > > Ouch, that's pretty bad as it means nobody is regression testing BPF on > arm64 with mainline. Damn. Yes, it unfortunately seems that upstream is lacking BPF regression testing for ARM64 :-( This bug surfaced when Red Hat QA tested our kernel backports, on different archs. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel