From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B13C2D0E3 for ; Mon, 14 Sep 2020 18:26:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A02CC21D7B for ; Mon, 14 Sep 2020 18:26:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rb+K163g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A02CC21D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mm5pNe8nd3ix7tsBo8xNLVBejf8qJndyq3E4oM3xrAA=; b=Rb+K163gD7AoPUqVI3SopYBBi PUUG5ihEk6rUgFEWYdVkpsddbdqdkVY9FEL5SAhQ9eZxAKrdS3CV63C0PlU+OODlisWwUiQA5aD7d hH/UOxOQuFX9R+cJOpnqix+Qhhl55BSIq/CbqL4L7TVja04x81Xxw8uVxPohfOfh5Hs59leaWgXK3 LUE9bQTrWeLf1CmPnaCL2JWuu85Mk2BZVsLszDyC1YaC8eLdpia7iRa6TQsAZJvGCRY2l6DBDi1pn iz2yzTtEeD9aQ8laGqR1OOShSOh6Qi4pQ9D2kWDDrz//+4kgQy73/cEqKFZKLlDnrLGDro43fLbAW V9gxrb6KQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHt9r-0003PN-4L; Mon, 14 Sep 2020 18:24:55 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHt9n-0003O2-VJ for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 18:24:52 +0000 Received: by mail-io1-f66.google.com with SMTP id z25so1127903iol.10 for ; Mon, 14 Sep 2020 11:24:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GTUBoBpz5Ene+9FeiAkhMRnwIfpjlrzqa2JaW342n2A=; b=tZi8FKEJcnS3CXmDns61uineg68M2+uFOO7UPDBIMUdgmRx6vgfeRx0SGBnYEO+mYV Nyg0eHKC6QrrRPm3rlLnPBYzYIgBzVJ6hyIIvPWxIqyZ0w38+3aP8Kh701EBpPYvQ6uS BW4bn1ahmRXwhYkxQzYbmJNCQUYrKEGEyDpPYE3jTkutZwE0trM1HSeZ+e1uXFqtx83g I2S4zBSU0/wrqVPmv1TizjPjR2hnbQcGY6ZE9LkxrxGXeidsPg3CldlVk1Cdy+ALTkw7 ZnftfTQ1VD2+vainJNiH+TYYzCSJkltylPLyw/9zemH2Wk0uQoX5xIrgxLZuwPf6w7aY iHew== X-Gm-Message-State: AOAM531Un6ml4vNDlNoczWn7GUH0snM7ixIjdMUEmzV6i7QYH7e/vl8T 2MRu32HndU3ySSykSUF0bw== X-Google-Smtp-Source: ABdhPJziOCMgtflSFn5rQIYl+kkPb236Vytu9jLXj8iJmknvM5j2xSqWu7dgZX0I/hG4PmzyudThfw== X-Received: by 2002:a6b:b386:: with SMTP id c128mr12051803iof.157.1600107884742; Mon, 14 Sep 2020 11:24:44 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id w70sm7447830ilk.87.2020.09.14.11.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 11:24:43 -0700 (PDT) Received: (nullmailer pid 4185625 invoked by uid 1000); Mon, 14 Sep 2020 18:24:42 -0000 Date: Mon, 14 Sep 2020 12:24:42 -0600 From: Rob Herring To: Martin Cerveny Subject: Re: [PATCH v2 1/3] dt-bindings: crypto: add new compatible for V3s Message-ID: <20200914182442.GA4180717@bogus> References: <20200831073101.3608-1-m.cerveny@computer.org> <20200831073101.3608-2-m.cerveny@computer.org> <20200901093249.orwyc5sr3z2y43fz@gilmour.lan> <20200901105719.GA2639@Red> <20200901114015.qivovvjqvmhkicdl@gilmour.lan> <20200902062824.GA17544@Red> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_142452_019642_E063E213 X-CRM114-Status: GOOD ( 29.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Herbert Xu , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Corentin Labbe , Maxime Ripard , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 05, 2020 at 05:51:48PM +0200, Martin Cerveny wrote: > > On Wed, 2 Sep 2020, Corentin Labbe wrote: > > On Tue, Sep 01, 2020 at 01:40:15PM +0200, Maxime Ripard wrote: > > > On Tue, Sep 01, 2020 at 12:57:19PM +0200, Corentin Labbe wrote: > > > > On Tue, Sep 01, 2020 at 11:32:49AM +0200, Maxime Ripard wrote: > > > > > On Mon, Aug 31, 2020 at 09:30:59AM +0200, Martin Cerveny wrote: > > > > > > Like A33 "sun4i-ss" has a difference, it give SHA1 digest > > > > > > directly in BE. So add new compatible. > > > > > > > > > > > > Tested-by: Martin Cerveny > > > > > > > > > > The Tested-by tag is for the other developpers. You're very much > > > > > expected to have tested your patch before contributing it. > > > > > > > > > > > Signed-off-by: Martin Cerveny > > > > > > --- > > > > > > .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 5 ++++- > > > > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > > > > > index fc823572b..180efd13a 100644 > > > > > > --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > > > > > +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml > > > > > > @@ -25,6 +25,7 @@ properties: > > > > > > - const: allwinner,sun4i-a10-crypto > > > > > > - items: > > > > > > - const: allwinner,sun8i-a33-crypto > > > > > > + - const: allwinner,sun8i-v3s-crypto > > > > > > > > > > If it's compatible with the A33, why do we need to introduce a new compatible? > > > > > > > > > > > > > > > > > reg: > > > > > > maxItems: 1 > > > > > > @@ -59,7 +60,9 @@ if: > > > > > > properties: > > > > > > compatible: > > > > > > contains: > > > > > > - const: allwinner,sun6i-a31-crypto > > > > > > + oneOf: > > > > > > + - const: allwinner,sun6i-a31-crypto > > > > > > + - const: allwinner,sun8i-v3s-crypto > > > > > > > > > > I guess the A33 compatible should be on that list as well? > > > > > > > > This is the list of "need reset". > > > > So we cannot use allwinner,sun8i-a33-crypto > > > > Probably this explanation should be in the commit message. > > > > > > But the A33 has a reset in the DTSI > > > > > > > > > Oh right so I need to send a fix for that and Martin Cerveny could simply use the "allwinner,sun8i-a33-crypto" (and so keep only patch #1(DTS)) > > > > Regards > > > > What is "right" solution for DTSI ? > - compatible = "allwinner,sun8i-a33-crypto"; > OR > - compatible = "allwinner,sun8i-v3s-crypto", "allwinner,sun8i-a33-crypto"; > (but unimplemented "allwinner,sun8i-v3s-crypto") Generally, this one in case you have differences like bugs or features. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel