From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81AABC433E2 for ; Mon, 14 Sep 2020 20:15:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25700208DB for ; Mon, 14 Sep 2020 20:15:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VWhMDLbF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25700208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bbgA1q7oemN8GqBbk8T4xBl10oGpf2cY+X0WyAFXZbM=; b=VWhMDLbFNWPB+6F9vz3yOyEPL HHKI4wQcNLiSr0kWF+tXOeQCPjgvvvI0L8Cqb0eUcuxUhwWgn4ku3yJKjU88m2dUcD77m0EjlbLRs aCUPK7VYbLBTfpsHVT9eKUjJOjMIHonydOVnzDHuT0j7rbUo8F7eDFRGj2zYg5PXSgk/EXUrLkjky bdCXaw9AkW8WBU1bXICmcIgD5WJe2RX2vQT1wboJw5O8ydJR7OMTmjk9lyg2iyaoQabnEbQzaICQ+ DUeQv9OXtxF9VoWF4FcLbH2Sf5mrrlwZDq/u94xbNE75atc8pnmINNxjEfDIaTWgHH3fqkz6TSxgM Iu7kdLHNQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHuqj-0005T5-Rd; Mon, 14 Sep 2020 20:13:17 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHuqg-0005Rz-Qc for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 20:13:15 +0000 Received: by mail-il1-f193.google.com with SMTP id s88so817445ilb.6 for ; Mon, 14 Sep 2020 13:13:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nbeDWg+iTnAnVi0q5KQbhM3HUB1BKl9YFwmERRpyJQM=; b=ejG3A4NUN3uMbJsX1g7x0Nzr239sTChJMflRFXqFdZeLGBgqcnxmQts0F1HAsNzN0S zLQPb4qWsHXkgQ2KtEX8Ke1DkvmDD4eDwMxYED423c4plg5XfPyYFaoGEKdA6EImShTS nuEHIbsiSMi/hCe6V8yh2GZx+v86zh4E1xhZaTR/ZSti7Ml3+xtkkV6A2oMibiu/yTyT N7TsDQjdQbt4jdkaT+02wHJFPHujnVe921UrxCNK6fniFcCVJIstsx8ifNEu4c0WhB4t SIUK4CSNh/0/SPxZGA5qbrJFQ8W+JXToXvTYkLl9FpHVL+2R6w/P9uhzxH/sky3V8Z7Q cGow== X-Gm-Message-State: AOAM530058iktkLkqAfVWXZBW0cag7MYTuFVLuzm12HCiDWBLX7KJuS8 2kClkCljwwrN6RASIMKg6g== X-Google-Smtp-Source: ABdhPJzqPNiMCdNHHFESMV8o9UZee4ffeHLbRHZWFvF46CyTEba02pPXQvYv6AHvLiiID9zHWyZa0Q== X-Received: by 2002:a92:6a08:: with SMTP id f8mr12418496ilc.94.1600114392923; Mon, 14 Sep 2020 13:13:12 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id w13sm6386690iox.10.2020.09.14.13.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 13:13:12 -0700 (PDT) Received: (nullmailer pid 161709 invoked by uid 1000); Mon, 14 Sep 2020 20:13:10 -0000 Date: Mon, 14 Sep 2020 14:13:10 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/3] dt-bindings: media: imx258: Add bindings for IMX258 sensor Message-ID: <20200914201310.GA154873@bogus> References: <1599031090-21608-1-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1599031090-21608-1-git-send-email-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_161314_926889_88CA4B50 X-CRM114-Status: GOOD ( 24.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sakari Ailus , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 02, 2020 at 09:18:08AM +0200, Krzysztof Kozlowski wrote: > Add bindings for the IMX258 camera sensor. The bindings, just like the > driver, are quite limited, e.g. do not support regulator supplies. Bindings should be complete, not what a driver happens to currently support. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. None > --- > .../devicetree/bindings/media/i2c/imx258.yaml | 92 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx258.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > new file mode 100644 > index 000000000000..ef789ad31143 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor > + > +maintainers: > + - Krzysztof Kozlowski > + > +description: |- > + IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > + type stacked image sensor with a square pixel array of size 4208 x 3120. It > + is programmable through I2C interface. Image data is sent through MIPI > + CSI-2. > + > +properties: > + compatible: > + const: sony,imx258 > + > + clocks: > + maxItems: 1 > + > + clock-frequency: > + description: Frequency of input clock if clock is not provided > + deprecated: true Why are we adding something deprecated on a new binding? > + const: 19200000 > + > + reg: > + maxItems: 1 > + > + # See ../video-interfaces.txt for more details > + port: > + type: object > + properties: > + endpoint: > + type: object > + properties: > + data-lanes: > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 If this is the only config, why does it need to be in DT? > + > + link-frequencies: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint64-array > + description: > + Allowed data bus frequencies. > + > + required: > + - data-lanes > + - link-frequencies > + > +required: > + - compatible > + - reg > + - port > + > + > +if: > + not: > + required: > + - clocks > +then: > + required: > + - clock-frequency > + > +unevaluatedProperties: false additionalProperties > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sensor@6c { > + compatible = "sony,imx258"; > + reg = <0x6c>; > + clocks = <&imx258_clk>; > + > + port { > + imx258_ep: endpoint { > + remote-endpoint = <&csi1_ep>; > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <320000000>; > + }; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index dc2aa691b75a..cca13d483d22 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16130,6 +16130,7 @@ M: Sakari Ailus > L: linux-media@vger.kernel.org > S: Maintained > T: git git://linuxtv.org/media_tree.git > +F: Documentation/devicetree/bindings/media/i2c/imx258.yaml > F: drivers/media/i2c/imx258.c > > SONY IMX274 SENSOR DRIVER > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel