From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE59C433E2 for ; Tue, 15 Sep 2020 05:43:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2E8E20829 for ; Tue, 15 Sep 2020 05:43:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="diiURk8I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2E8E20829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iGdmumKA1Nx8yG5CSYqKO0Ix44VubieTGDKXtar6W18=; b=diiURk8IoJZD4/RNgUX9uMouq C9p8OWt1k96lZzjSTm2OdjpAOk9xC9xii+y3UFiGm8/rQuchn3LL+kCHJrh2K/axtZTg1OCNfDe+2 ORuCvWlp2BV7hlTpFAymH7xScRsbbXY9GZ/dd4KES5xvLxxim9mW/utpqa9BkQkYJPaeMrFuJjpkx nL59CzxksLE53OTFH2tcvprhn0tcwTX0+Ic5E/RwHI/Pq6Q31orjzy4aDuEU8M+qPVLbBovK5re7q 63OGlTLlbYUxhDhZHlH6tEWuYXZHt+bRveY64N17IiKCGvEd7JZL3m8dbmihDvhV7SF+5fbY/626L UGQtJ+pAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI3id-0002mg-EZ; Tue, 15 Sep 2020 05:41:31 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI3ia-0002mI-Rs for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2020 05:41:29 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BC6A26736F; Tue, 15 Sep 2020 07:41:22 +0200 (CEST) Date: Tue, 15 Sep 2020 07:41:22 +0200 From: Christoph Hellwig To: Mathieu Poirier Subject: Re: [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Message-ID: <20200915054122.GA18079@lst.de> References: <20200914073343.1579578-1-hch@lst.de> <20200914073343.1579578-7-hch@lst.de> <20200914230147.GA3251212@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200914230147.GA3251212@xps15> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_014129_056287_2B89C7A5 X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-sh@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, Bjorn Andersson , Frank Rowand , Christoph Hellwig , Florian Fainelli , Russell King , linux-acpi@vger.kernel.org, loic.pallardy.st.com@lst.de, Ohad Ben-Cohen , devicetree@vger.kernel.org, Rob Herring , Santosh Shilimkar , Nathan Chancellor , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jim Quinlan , Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 05:01:47PM -0600, Mathieu Poirier wrote: [700 lines of the fullquote deleted..] > > + for (r = map; r->size; r++) > > + num_ranges++; > > + > > + new_map = kmemdup(map, array_size(num_ranges + 1, sizeof(*map)), > > + GFP_KERNEL); > > + if (!new_map) > > + return -ENOMEM; > > + to->dma_range_map = new_map; > > + return 0; > > +} > > + > > This patch seemed Ok to me but it broke the stm32 remoteproc implementation. When > I tested things out function dma_coerce_mask_and_cohenrent() returns -5 and the > rest of the initialisation fails. I isolated things to function dma_to_pfn() > [2]. In the original implementation __bus_to_pfn() returns 0xfffff and > dev->dma_pfn_offset is equal to 0x38000. As such the function returns 0x137fff > and dma_supported() a non-zero value[3]. > > With this set function dma_to_pfn() received a face lift. Function > __bus_to_pfn() still returns 0xfffff but translate_dma_to_phys() returns 0, > which forces dma_supported() to also return 0 and that is where the -5 (-EIO) > comes from. > > Taking a futher look at translate_dma_to_phy(), @dma_addr never falls within the > bus_dma_region ranges and returns 0. > > I'm suspecting an initialisation problem and if it occurred here, it will > likely show up elsewhere. Can you try this incremental patch? diff --git a/include/linux/dma-direct.h b/include/linux/dma-direct.h index 088c97181ab146..c6b21acba7a459 100644 --- a/include/linux/dma-direct.h +++ b/include/linux/dma-direct.h @@ -46,7 +46,7 @@ static inline phys_addr_t translate_dma_to_phys(struct device *dev, if (dma_addr >= m->dma_start && dma_addr - m->dma_start < m->size) return (phys_addr_t)dma_addr + m->offset; - return 0; + return (phys_addr_t)-1; } #ifdef CONFIG_ARCH_HAS_PHYS_TO_DMA _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel