From: "Guido Günther" <guido.gunther@puri.sm>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, martin.kepplinger@puri.sm,
shawnguo@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] arm64: dts: imx8mq-evk: Add MIPI DSI support
Date: Tue, 15 Sep 2020 09:43:29 +0200 [thread overview]
Message-ID: <20200915074329.GA4286@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <20200914143847.10523-1-festevam@gmail.com>
Hi,
On Mon, Sep 14, 2020 at 11:38:46AM -0300, Fabio Estevam wrote:
> imx8mq-evk has a MIPI DSI port that can be used to connect a Raydium
> RM67191 panel.
>
> Add support for it.
This looks good regarding the DTS changes but i don't know if this is a
reasonable default for the EVK so i'm doing a:
Acked-by: Guido Günther <agx@sigxcpu.org>
Cheers,
-- Guido
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 44 ++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index 7c6808814856..2418cca00bc5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -132,6 +132,10 @@
> };
> };
>
> +&dphy {
> + status = "okay";
> +};
> +
> &fec1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_fec1>;
> @@ -255,6 +259,40 @@
> };
> };
>
> +&lcdif {
> + status = "okay";
> +};
> +
> +&mipi_dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + panel@0 {
> + pinctrl-0 = <&pinctrl_mipi_dsi>;
> + pinctrl-names = "default";
> + compatible = "raydium,rm67191";
> + reg = <0>;
> + reset-gpios = <&gpio5 6 GPIO_ACTIVE_LOW>;
> + dsi-lanes = <4>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mipi_dsi_out>;
> + };
> + };
> + };
> +
> + ports {
> + port@1 {
> + reg = <1>;
> + mipi_dsi_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> +};
> +
> &pcie0 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pcie0>;
> @@ -388,6 +426,12 @@
> >;
> };
>
> + pinctrl_mipi_dsi: mipidsigrp {
> + fsl,pins = <
> + MX8MQ_IOMUXC_ECSPI1_SCLK_GPIO5_IO6 0x16
> + >;
> + };
> +
> pinctrl_pcie0: pcie0grp {
> fsl,pins = <
> MX8MQ_IOMUXC_I2C4_SCL_PCIE1_CLKREQ_B 0x76
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-15 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 14:38 [PATCH 1/2] arm64: dts: imx8mq-evk: Add MIPI DSI support Fabio Estevam
2020-09-14 14:38 ` [PATCH 2/2] arm64: defconfig: Enable the eLCDIF and Raydium RM67191 drivers Fabio Estevam
2020-09-14 14:51 ` Guido Günther
2020-09-15 7:43 ` Guido Günther [this message]
2020-09-22 2:32 ` [PATCH 1/2] arm64: dts: imx8mq-evk: Add MIPI DSI support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915074329.GA4286@bogon.m.sigxcpu.org \
--to=guido.gunther@puri.sm \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=martin.kepplinger@puri.sm \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).