Re: [PATCHv2] perf kvm: add kvm-stat for arm64

Sergey Senozhatsky
2020-09-16T08:02:08Z

On (20/09/16 15:51), Leo Yan wrote:
> On Wed, Sep 16, 2020 at 09:44:04AM +0900, Sergey Senozhatsky wrote:
> > On (20/09/15 21:21), Leo Yan wrote:
> > >
> > > Sorry if I miss anything for this.
> > >
> >
> > No, you are absolutely right! I should have looked more attentively.
> >
> > Is "IL" good enough for a decoded reason
> >
> > {ARM_EXCEPTION_IRQ, "IRQ" }, \
> > {ARM_EXCEPTION_EL1_SERROR, "SERROR" }, \
> > {ARM_EXCEPTION_TRAP, "TRAP" }, \
> > + {ARM_EXCEPTION_IL, "IL" }, \
> > {ARM_EXCEPTION_HYP_GONE, "HYP_GONE" }
> >
> > or should there be "ILLEGAL", or maybe something even better?
> > ILLEGAL_EXC, etc.
>
> I personally think "ILLEGAL" is neat and clear :)

OK.

By the way, arch/arm64/kernel/traps.c has esr_class_str[] with
decoded exception names. Maybe I can reuse some.