From: Tingwei Zhang <tingwei@codeaurora.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mike Leach <mike.leach@linaro.org>
Cc: tsoni@codeaurora.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Kim Phillips <kim.phillips@arm.com>,
Mao Jinlong <jinlmao@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
coresight@lists.linaro.org, Randy Dunlap <rdunlap@infradead.org>,
Mian Yousaf Kaukab <ykaukab@suse.de>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
Tingwei Zhang <tingwei@codeaurora.org>,
Leo Yan <leo.yan@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 18/24] coresight: cti: Fix bug clearing sysfs links on callback
Date: Tue, 15 Sep 2020 18:41:10 +0800 [thread overview]
Message-ID: <20200915104116.16789-19-tingwei@codeaurora.org> (raw)
In-Reply-To: <20200915104116.16789-1-tingwei@codeaurora.org>
From: Mike Leach <mike.leach@linaro.org>
During module unload, a coresight driver module will call back into
the CTI driver to remove any links between the two devices.
The current code has 2 issues:-
1) in the CTI driver the matching code is matching to the wrong device
so misses all the links.
2) The callback is called too late in the unload process resulting in a
crash.
This fixes both the issues.
Fixes: 177af8285b59 ("coresight: cti: Enable CTI associated with devices")
Reported-by: Tingwei Zhang <tingwei@codeaurora.org>
Signed-off-by: Mike Leach <mike.leach@linaro.org>
Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/hwtracing/coresight/coresight-cti.c | 2 +-
drivers/hwtracing/coresight/coresight.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c
index abc8b32e79b3..38e785d913b0 100644
--- a/drivers/hwtracing/coresight/coresight-cti.c
+++ b/drivers/hwtracing/coresight/coresight-cti.c
@@ -591,7 +591,7 @@ static void cti_remove_assoc_from_csdev(struct coresight_device *csdev)
ctidrv = csdev_to_cti_drvdata(csdev->ect_dev);
ctidev = &ctidrv->ctidev;
list_for_each_entry(tc, &ctidev->trig_cons, node) {
- if (tc->con_dev == csdev->ect_dev) {
+ if (tc->con_dev == csdev) {
cti_remove_sysfs_link(ctidrv, tc);
tc->con_dev = NULL;
break;
diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
index 4f4485b17458..b8b0a20e93c9 100644
--- a/drivers/hwtracing/coresight/coresight.c
+++ b/drivers/hwtracing/coresight/coresight.c
@@ -1246,8 +1246,6 @@ static void coresight_device_release(struct device *dev)
{
struct coresight_device *csdev = to_coresight_device(dev);
- if (cti_assoc_ops && cti_assoc_ops->remove)
- cti_assoc_ops->remove(csdev);
fwnode_handle_put(csdev->dev.fwnode);
kfree(csdev->refcnt);
kfree(csdev);
@@ -1582,6 +1580,8 @@ void coresight_unregister(struct coresight_device *csdev)
{
etm_perf_del_symlink_sink(csdev);
/* Remove references of that device in the topology */
+ if (cti_assoc_ops && cti_assoc_ops->remove)
+ cti_assoc_ops->remove(csdev);
coresight_remove_conns(csdev);
coresight_clear_default_sink(csdev);
coresight_release_platform_data(csdev, csdev->pdata);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-15 10:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 10:40 [PATCH v11 00/24] coresight: allow to build coresight as modules Tingwei Zhang
2020-09-15 10:40 ` [PATCH v11 01/24] coresight: cpu_debug: add module name in Kconfig Tingwei Zhang
2020-09-15 10:40 ` [PATCH v11 02/24] coresight: cpu_debug: define MODULE_DEVICE_TABLE Tingwei Zhang
2020-09-15 10:40 ` [PATCH v11 03/24] coresight: use IS_ENABLED for CONFIGs that may be modules Tingwei Zhang
2020-09-15 10:40 ` [PATCH v11 04/24] coresight: add coresight prefix to barrier_pkt Tingwei Zhang
2020-09-15 10:40 ` [PATCH v11 05/24] coresight: export global symbols Tingwei Zhang
2020-09-15 10:40 ` [PATCH v11 06/24] coresight: add try_get_module() in coresight_grab_device() Tingwei Zhang
2020-09-15 11:08 ` Suzuki K Poulose
2020-09-15 10:40 ` [PATCH v11 07/24] coresight: stm: allow to build coresight-stm as a module Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 09/24] coresight: etm3x: allow etm3x to be built as a module Tingwei Zhang
2020-09-15 18:09 ` Mathieu Poirier
2020-09-22 21:42 ` Mathieu Poirier
2020-09-23 0:23 ` Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 10/24] coresight: etm4x: allow etm4x " Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 11/24] coresight: etb: allow etb " Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 12/24] coresight: tpiu: allow tpiu " Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 13/24] coresight: tmc: allow tmc " Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 14/24] coresight: allow funnel driver to be built as module Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 15/24] coresight: allow replicator " Tingwei Zhang
2020-09-15 11:25 ` Suzuki K Poulose
2020-09-15 10:41 ` [PATCH v11 16/24] coresight: cti: add function to register cti associate ops Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 17/24] coresight: cti: Fix remove sysfs link error Tingwei Zhang
2020-09-15 10:41 ` Tingwei Zhang [this message]
2020-09-15 10:41 ` [PATCH v11 19/24] coresight: cti: don't disable ect device if it's not enabled Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 20/24] coresight: cti: increase reference count when enabling cti Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 21/24] coresight: cti: allow cti to be built as a module Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 22/24] coresight: tmc-etr: add function to register catu ops Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 23/24] coresight: catu: allow catu drivers to be built as modules Tingwei Zhang
2020-09-15 10:41 ` [PATCH v11 24/24] coresight: allow the coresight core driver to be built as a module Tingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915104116.16789-19-tingwei@codeaurora.org \
--to=tingwei@codeaurora.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinlmao@codeaurora.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=rdunlap@infradead.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tsoni@codeaurora.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).