From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4072C43461 for ; Tue, 15 Sep 2020 11:09:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3438321D43 for ; Tue, 15 Sep 2020 11:09:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EwwYytqy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z1en/Msu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3438321D43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eJ/W0xhgQSEEsqYH9bUVbcWS5kLR9buxmMrBSYXbskc=; b=EwwYytqyTnaeNm4OBBHpCVsCi SUpZazrYGxNTbdukiVCC3ZIxozBjhGeGULp9njIBPXs78JV9GpPi0KS/Wqa+rx3A8vN1H1htYULpn 2DsR9qok4TOvy0MashT0r/RMK0sr2QmIkciIsZFclk0yvjJ4wh3Gk+tTPTRnHrkQURvF94IFyQ7qn IIhoQrwKAw+LPOKExsdnfXbPT63cYxwefUExdopatoLQh4VnZijwKuZtf+0/d768jJhj2OVcE7FGl ZRG2HON5AhJyq4BWpqNqlapHSoOLqY8/L0pkYNY6/THQao1SlrU4Cvc95hRIEWUqB45iN/y0sq90u KMPXyCaPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI8nm-000112-SW; Tue, 15 Sep 2020 11:07:10 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI8e8-00059I-M4 for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2020 10:57:25 +0000 Received: by mail-pl1-x629.google.com with SMTP id bh1so1143418plb.12 for ; Tue, 15 Sep 2020 03:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jwkMsDqbHDpkmL1DX5NgTbbCQ3AjMnA4hImq/0BH+g8=; b=Z1en/MsuS0FkLwP9QiKP4RDKQ4lDQrtoQcNhaQbkkWLL0C7dop77EY6E35zFR3KEPv tHy4ymOajbSYRNFipuUxO/ue+Ey0xOrnD0w+KURVDA8S9vTK9qYklTQFqXpb12xuHvmJ +sZj50iAni6pL8qSngd1dy/Wfa9or7UJIURMLST69b/CWmTFoNeAHdC7npkdyK/qLhs5 tKLUukQJlbpxfnW+5tksh44wwjw8nOtwhDxh1qVUHDQw2XdjjF0Mb35LJGYGqo9hkvMa cb3KTdqAxVTD6vI4qGGWAWVq0ld7iPOHwXP9XTjoo5PzX1x5PFL57t9yku8TRVsyqTrX XreA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jwkMsDqbHDpkmL1DX5NgTbbCQ3AjMnA4hImq/0BH+g8=; b=ek9B/z+W6vs0ZFJxtaahwBJk+U6aY7qro0wSiK+I+AbV47NjwlI/wtNfQ7zyWsc4Z6 7tn3ifqGEcDzq1Ap0lBe1uZxm9kiV0xHTyfwCYj9h4KK0+Wyj/OD4BgdmSGobOYEtRax 8IJc1KGd/EGqrg1WIeXTolQxDHQVP8391hqU91JX5CQGTC94V2wrK5jtmd7WkabnRfkO B1EvVNNa6Pr8NSbN0du9NOpRty/HQAWKXv4DbieiUqKJinPb2DXwEg1oMbTsnQxaeoX2 TIi20ic2/A0sZBgvMnSwrx+r9RtTubZ3R9zB2oqeSqi7kC/+OaVaFBt45nzf/ceE2P7C O/5A== X-Gm-Message-State: AOAM533747bQTZtEWe9LN5Ob3eUWBidVs05nQAZ4RKgyEWVoAuRDYWtK MuwUWoV9qJ1qjvIgyyDoTbg= X-Google-Smtp-Source: ABdhPJzRoeYwWAVjm+161ifDeODD584x26HaSlSK2Ee2HVdWhaSe/P++BaS7m2BhbnFG3MOgK3KsjA== X-Received: by 2002:a17:90b:d89:: with SMTP id bg9mr3429765pjb.26.1600167425864; Tue, 15 Sep 2020 03:57:05 -0700 (PDT) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id s28sm13471235pfd.111.2020.09.15.03.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 03:57:04 -0700 (PDT) Date: Tue, 15 Sep 2020 19:57:02 +0900 From: Sergey Senozhatsky To: Leo Yan Subject: Re: [PATCHv2] perf kvm: add kvm-stat for arm64 Message-ID: <20200915105702.GA604@jagdpanzerIV.localdomain> References: <20200915091140.152775-1-sergey.senozhatsky@gmail.com> <20200915103644.GA32758@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200915103644.GA32758@leoy-ThinkPad-X240s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_065713_356349_AE62DD58 X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , Peter Zijlstra , John Garry , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Suleiman Souhlal , Namhyung Kim , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On (20/09/15 18:36), Leo Yan wrote: > > +#define HVC_STUB_ERR 0xbadca11 > > + > > +/* Per asm/kvm_asm.h */ > > +#define ARM_EXCEPTION_IRQ 0 > > +#define ARM_EXCEPTION_EL1_SERROR 1 > > +#define ARM_EXCEPTION_TRAP 2 > > +#define ARM_EXCEPTION_IL 3 > > Nitpick: from completeness, we also can give out KVM exiting reason > for 'ARM_EXCEPTION_IL'. OK, let me take a look. > > +define_exit_reasons_table(arm64_exit_reasons, kvm_arm_exception_type); > > +define_exit_reasons_table(arm64_trap_exit_reasons, kvm_arm_exception_class); > > + > > +const char *kvm_trap_exit_reason = "esr_ec"; > > +const char *vcpu_id_str = "id"; > > +const int decode_str_len = 20; > > +const char *kvm_exit_reason = "ret"; > > +const char *kvm_entry_trace = "kvm:kvm_entry"; > > +const char *kvm_exit_trace = "kvm:kvm_exit"; > > + > > +const char *kvm_events_tp[] = { > > + "kvm:kvm_entry", > > + "kvm:kvm_exit", > > I think Arm64 needs to support event 'kvm_mmio'. It's good to use a > new patch for support this event? Yes, I guess a follow up kvm_mmio patch would be a better option. > > +int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid __maybe_unused) > > +{ > > + kvm->exit_reasons = arm64_exit_reasons; > > Since the "kvm->exit_reasons" will be always set in the function > event_get_key(), seems to me here can remove this assignment. Yes, this assignment is a leftover. -ss _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel