From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CCA0C43461 for ; Tue, 15 Sep 2020 12:46:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF516208E4 for ; Tue, 15 Sep 2020 12:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t79Q2Fwt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hRWVCqfY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF516208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wSddAn0tr1aAFAb2Cf5/NNSc7L6oAV3pBhSQkdMGMPA=; b=t79Q2FwtXbRBSKOtWqkDOwwU8 OkuB0X24zfAvxLL0OgKzuoxXxWsxhcpOUiCn3hSgKvRf2c3OEgfYrsHFawlRk4hRSlFRHpX+OB9Di WeIKu4xKfWt+uEk1O62Yg/LD3AmRu/eFO7F+K6jeI1WCJcBMPXKDAOCzvgs5m28VWhr2XGeCdep4p BY5ls0dBrPG0JjGzL6y8HKtIsaBiV075x3LOwrZ0XudOou/WVjN1lRTprr7TmZ5DVKID5AQrfxOO7 BZDcU7BEca6SpayBGBkrHI+Ro9yjJDhb5okDrVAMgseG2fUD4gyE4/nyKRtTEh+BREZdbiocWY4+O V6OyVPS8g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIAK2-0002V7-St; Tue, 15 Sep 2020 12:44:35 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIAK0-0002UJ-Bo for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2020 12:44:33 +0000 Received: by mail-ed1-x541.google.com with SMTP id c8so2891703edv.5 for ; Tue, 15 Sep 2020 05:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mEiVCit6FSg8i4y7xzG1PhjUQrtE3x8RMEykB0yBZow=; b=hRWVCqfYMK2MPPQwYa91FJ9bg7QEA26p0sM58xh2VHakwa8Idnn7wyf7RjGnhjEMYc CnmZW4y8K7FGOgXtCVk5KXi5oj5+BBRpMV/LcOGnPqgJM+3XOOSloZcmOTzHN6ENwc2e QQM4ePTCJbjOtOq/FZlGCIDd0mivE+7prKup810HiuK1Hz5+glkKKXIJ+s36F43UGHSv M0o8pdkp3ynsjUUJoS7B+qMew48wfset5rRFPTjOOgL+7W1gSNsBlZPzMVjySveSbk7m XPXzQ7+24caIrX/arBIBbDk4MxblgAXEm1IuTl6w5GjQFhHASYFuanehKQUVFD+3JL+A wiiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mEiVCit6FSg8i4y7xzG1PhjUQrtE3x8RMEykB0yBZow=; b=hR1aQAx40eqUXekVb70JjNfvsxbcDDvE9EMb30K+hbhgk3SzeOFI0I9AWPgTY7ROVH 9ykVSoWwoOtrKv5CS9S+dvC5GGNH8ePq7mbd3nD/El2OsbjFZuhc7tRobYZ1FfqBHfa/ QEvfYnf02byDbnJO1tQBX0h8ElUPGG6/50jiFSzYmvCCQVJORTC6p7qsJlx2Mgc1HtN7 qldwa12FJC9ruAwwguncUUvGooHB2CTNx4qIzj0UGq49iQVBHxye7skVtAC6q3Ii2WxC cXxe7bPuqtU9KEAWeaBPzjNf3XytIYzlUbEbpb45/PvHEKk3b9QrOAKMMLb3MNLYP7mu Es6Q== X-Gm-Message-State: AOAM531MJoD/xRk95ydrtWt8PMRjNipwMruGduovc1GmcabYDNh2GiRY QB5GCTz4VBjXFCCJsy0CpobQxknQxPPb5Q== X-Google-Smtp-Source: ABdhPJzHxoOUXvXFVfVey8oiNZuP4hjeh49KqHcgeQ12dBfzaXNx9+ModH3NnakBVnP0eGFeDx/Ezg== X-Received: by 2002:a05:6402:1212:: with SMTP id c18mr21856162edw.344.1600173870376; Tue, 15 Sep 2020 05:44:30 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id s15sm9983892eju.105.2020.09.15.05.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 05:44:28 -0700 (PDT) Date: Tue, 15 Sep 2020 14:44:27 +0200 From: Thierry Reding To: Jon Hunter Subject: Re: [PATCH 9/9] arm64: tegra: Initial Tegra234 VDK support Message-ID: <20200915124427.GC3496938@ulmo> References: <20200716141856.544718-1-thierry.reding@gmail.com> <20200716141856.544718-10-thierry.reding@gmail.com> <3c2f4e9c-28af-d5dc-1daa-40744da32898@nvidia.com> MIME-Version: 1.0 In-Reply-To: <3c2f4e9c-28af-d5dc-1daa-40744da32898@nvidia.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_084432_426772_0B19241B X-CRM114-Status: GOOD ( 27.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7847621884063313867==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7847621884063313867== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XMCwj5IQnwKtuyBG" Content-Disposition: inline --XMCwj5IQnwKtuyBG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 07, 2020 at 08:46:48PM +0100, Jon Hunter wrote: >=20 > On 16/07/2020 15:18, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > The NVIDIA Tegra234 VDK is a simulation platform for the Orin SoC. It > > supports a subset of the peripherals that will be available in the final > > chip and serves as a bootstrapping platform. > >=20 > > Signed-off-by: Thierry Reding > > --- > > arch/arm64/boot/dts/nvidia/Makefile | 1 + > > .../boot/dts/nvidia/tegra234-sim-vdk.dts | 40 ++++ > > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 191 ++++++++++++++++++ > > drivers/soc/tegra/Kconfig | 10 + > > include/dt-bindings/clock/tegra234-clock.h | 14 ++ > > include/dt-bindings/reset/tegra234-reset.h | 10 + > > 6 files changed, 266 insertions(+) > > create mode 100644 arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dts > > create mode 100644 arch/arm64/boot/dts/nvidia/tegra234.dtsi > > create mode 100644 include/dt-bindings/clock/tegra234-clock.h > > create mode 100644 include/dt-bindings/reset/tegra234-reset.h > >=20 > > diff --git a/arch/arm64/boot/dts/nvidia/Makefile b/arch/arm64/boot/dts/= nvidia/Makefile > > index 2273fc5db19c..9296d12d11e9 100644 > > --- a/arch/arm64/boot/dts/nvidia/Makefile > > +++ b/arch/arm64/boot/dts/nvidia/Makefile > > @@ -9,3 +9,4 @@ dtb-$(CONFIG_ARCH_TEGRA_210_SOC) +=3D tegra210-p2894-00= 50-a08.dtb > > dtb-$(CONFIG_ARCH_TEGRA_186_SOC) +=3D tegra186-p2771-0000.dtb > > dtb-$(CONFIG_ARCH_TEGRA_194_SOC) +=3D tegra194-p2972-0000.dtb > > dtb-$(CONFIG_ARCH_TEGRA_194_SOC) +=3D tegra194-p3509-0000+p3668-0000.d= tb > > +dtb-$(CONFIG_ARCH_TEGRA_234_SOC) +=3D tegra234-sim-vdk.dtb > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dts b/arch/arm= 64/boot/dts/nvidia/tegra234-sim-vdk.dts > > new file mode 100644 > > index 000000000000..f6e6a24829af > > --- /dev/null > > +++ b/arch/arm64/boot/dts/nvidia/tegra234-sim-vdk.dts > > @@ -0,0 +1,40 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/dts-v1/; > > + > > +#include "tegra234.dtsi" > > + > > +/ { > > + model =3D "NVIDIA Tegra234 VDK"; > > + compatible =3D "nvidia,tegra234-vdk", "nvidia,tegra234"; > > + > > + aliases { > > + sdhci3 =3D "/cbb@0/sdhci@3460000"; > > + serial0 =3D &uarta; > > + }; > > + > > + chosen { > > + bootargs =3D "console=3DttyS0,115200n8 earlycon=3Duart8250,mmio32,0x= 03100000"; > > + stdout-path =3D "serial0:115200n8"; > > + }; > > + > > + cbb@0 { > > + serial@3100000 { > > + status =3D "okay"; > > + }; > > + > > + sdhci@3460000 { > > + status =3D "okay"; > > + bus-width =3D <8>; > > + non-removable; > > + only-1-8-v; > > + }; > > + > > + rtc@c2a0000 { > > + status =3D "okay"; > > + }; > > + > > + pmc@c360000 { > > + nvidia,invert-interrupt; > > + }; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot= /dts/nvidia/tegra234.dtsi > > new file mode 100644 > > index 000000000000..3509687441a1 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > > @@ -0,0 +1,191 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include > > +#include > > +#include > > +#include > > + > > +/ { > > + compatible =3D "nvidia,tegra234"; > > + interrupt-parent =3D <&gic>; > > + #address-cells =3D <2>; > > + #size-cells =3D <2>; > > + > > + bus@0 { > > + compatible =3D "simple-bus"; > > + #address-cells =3D <1>; > > + #size-cells =3D <1>; > > + > > + ranges =3D <0x0 0x0 0x0 0x40000000>; > > + > > + misc@100000 { > > + compatible =3D "nvidia,tegra234-misc"; > > + reg =3D <0x00100000 0xf000>, > > + <0x0010f000 0x1000>; > > + status =3D "okay"; > > + }; >=20 >=20 > Is there meant to be a fallback option here, because I don't see > anything to match the above compatible string? I've got the below patch in my tree that's meant to add that code, but it's in the wrong order in my local branch, so it didn't make it into this subset. I'll reorder the patches to include the APBMISC support patch in this series. While this block is generally very similar, there are enough variations for them not to count as compatible, in my opinion, so I don't think adding a fallback is the right option. Thierry --XMCwj5IQnwKtuyBG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9gtysACgkQ3SOs138+ s6Hyqg/+LeW2gS1vt964BE13iqFijk59/znlG/eMRFfyJVelPuZjWAYtKMqkMYUj 6O7Q5E2cZ7ZFz6sZiVNfclDfAq2qjjcO80BAH6fkM2kt6XR27sGXD2aRrBxlu2An o0Q/3KpQRS1vPfxpPrmWtKNYVT1TYetd00wOstepypUwpksAhvAuZs5s3JMF/jEA Ou8S8IDx5SbAnP5oQT+LrADsaFjxQrwXq1jT4hjZB55L2+alaKGru/cbNfCAqf4F ARaWE+lPhkBpuaFaXkRFjVm9rRYIXMhO8IXejAvPenSyNg07OmvBuPC5ykzAfpjL xRLlnUqGPKlkYqaSRv1zRf4RrBvKic0W9X/lV+ANIdFqIjBG8KHW7+SVJJ9+WA4C xmO0Hd6zwcIMC5mIr6e8UZagLPSWojL6J079GKrQ83DlX0fUK6bXvUF08v0DkRcX +GG7veRv7OxLoJxYTnwHkJaNssacl3PzSke+o5fxsySiMkYqGgT0SO9MPe64saiv t8wivNzY9Kha/SSi4Xv+94xRkUmKY+kVz3JFmFdQmyyIAsH51zvoLmpTA9tZ+O3m fa3AElqo5/2j8NThOKZlL+YoveH4AZhVEl9jkDKSZqrH/2aPB6CVH/cROv+lWfp/ HezYNUchsCpNuBFNimPjQdSfSs3nOOWPQLUuTkq+LWD7NnYgaXQ= =7yT6 -----END PGP SIGNATURE----- --XMCwj5IQnwKtuyBG-- --===============7847621884063313867== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7847621884063313867==--