From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A77BC43461 for ; Wed, 16 Sep 2020 00:55:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C412206B6 for ; Wed, 16 Sep 2020 00:55:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DnMFexP/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dGUV5VEW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C412206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hpKsgSgDQlbNh0Ru/lvFbTBKna0eae1w96+3TG3V4PA=; b=DnMFexP/1kesE67LoiDOBDirP d4EatbYeIt9WR1tfFnY+tN+xzS9UUhw8zJMI3m6Ma6sylqrPOzq/+WZA1rmAdMDlhFyfoYO3VoXab wy6IJxOakT+1zTNXCsMTXg14ru+bK80TOSPEwaN8V+Qo96kqOXJVCCHRzDbu/gO3a22f45p0dVDEC +NYTBWcfDLr9foTSSN/O7bDdgWv3wOaXIcS6yOGZT2hwkvjfWBH/CW7fxS1hBfvGr+2nQRr+dUP5Q LbKvJ+LwLLir1Epcp7sOGs/5vnlWF9fDdb4mEn7xEVIamnUWiJsa02WzeOg51sR9NHEfjjPx75Bnr 6VffE6sRQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kILi4-0001Cp-7E; Wed, 16 Sep 2020 00:54:08 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kILi1-0001C7-Q6 for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 00:54:06 +0000 Received: by mail-pj1-x1043.google.com with SMTP id a9so680899pjg.1 for ; Tue, 15 Sep 2020 17:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UAVBoDevT9l3v6Yq4HsTsFUpmF8NbevOuwC5bYWFSWQ=; b=dGUV5VEWPWhr5mJT3YsFt0mypb70SiBUfT6WRyUlMnHR6QFR6KbB9Zw8l6LmrwqTHX OjLN1WQ8SVaWNfEBXKyEUOp0bDsvmhadnkpiL/u3CtHzYTjpNedISDfC0dD5U0kukwLG w9ZGsc3TTGs4xAHyM514WU5A9wxTgvHzb+/9eTQqo4KPsyvZlBP5z6bmvpKXAJWt3KTH BDuzxsqeGIWqlrmBFFcgtjFqA4XnOELFCGASG/mBZZP5ftQLpj/XhO+L/fcTEihSMpcl 7pyq3XfpF5BaK3VR+DiCrxjsyTQlTSS+P31p+Cdvrxb/R/BsJXYBXMBGHmVJS4OLWAAw EiSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UAVBoDevT9l3v6Yq4HsTsFUpmF8NbevOuwC5bYWFSWQ=; b=Mmg0cZ2iRtYR+9/TUijaVJMV53sBZuWXIuRNva+DNTY6U4aqhLg+w5XgQM/R9gdLv7 p+LHTVfOD7GlJ6hMAV41lCFU2WXnnxa5wtEAKQRTWnGWd/xk+hojj1chF/JfOTSLMc0e 47aoFCJ7vPg87iFViPXr/U4/oLAW9DmmBrKaCbh4v6yo2v9sbcx8lEa9B5BIV5c/tsKH JCCjcI+cP4tKu9IcGLnn53lmJdLRWhlu5/LA20QzBeb2kD3Sx+LZicA+8THSzJRZIoHt 9R0L2otGBc61PnNuuXCwgNlBMdnZ9jKTaUs846FBwsG5cjyB9FBosvPA3lUq8e3+2Ov7 /z2Q== X-Gm-Message-State: AOAM530aHjSXZ7hzeeZhZv95FmzM9ZbXRH2qLNG+CfJVF4fyNbRN3Mv2 EHXdeWXUXc3634je6yif90Q= X-Google-Smtp-Source: ABdhPJy19jYEOl6sx7SJm2Wm3Wdy/XAVvcrykV+8Mej2tLYRkj8qz6QC2RlptrTKGELkrQs2E9tFfA== X-Received: by 2002:a17:90a:e287:: with SMTP id d7mr1821541pjz.170.1600217642302; Tue, 15 Sep 2020 17:54:02 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id u22sm12458883pgi.85.2020.09.15.17.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 17:54:01 -0700 (PDT) Date: Tue, 15 Sep 2020 17:53:59 -0700 From: Dmitry Torokhov To: Krzysztof Kozlowski Subject: Re: [PATCH v2 2/4] Input: omap4-keypad - Fix handling of platform_get_irq() error Message-ID: <20200916005359.GE1681290@dtor-ws> References: <20200828145744.3636-1-krzk@kernel.org> <20200828145744.3636-2-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200828145744.3636-2-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_205405_856086_6082EC36 X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, Maxime Ripard , linux-input@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 28, 2020 at 04:57:42PM +0200, Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: f3a1ba60dbdb ("Input: omap4-keypad - use platform device helpers") > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. None > --- > drivers/input/keyboard/omap4-keypad.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c > index 94c94d7f5155..b075f1af0305 100644 > --- a/drivers/input/keyboard/omap4-keypad.c > +++ b/drivers/input/keyboard/omap4-keypad.c > @@ -240,10 +240,8 @@ static int omap4_keypad_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (!irq) { > - dev_err(&pdev->dev, "no keyboard irq assigned\n"); > - return -EINVAL; > - } > + if (irq < 0) > + return -irq; You must have meant just "irq", right? > > keypad_data = kzalloc(sizeof(struct omap4_keypad), GFP_KERNEL); > if (!keypad_data) { > -- > 2.17.1 > -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel