From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD5BC43461 for ; Wed, 16 Sep 2020 01:03:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 188EB20715 for ; Wed, 16 Sep 2020 01:03:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DoKJW1fB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GxnJyXiq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 188EB20715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zDFPn5NWTLDRE7BF9H5dily8S9cS/qrccJ9px6Fq3tM=; b=DoKJW1fBOSHqA5Q1L6w+mptPy jPOvhV/xHBXVpnZCFbK+In7Kjh5YQ5RvJtVDVKUP1f7Ctst3N7BTkTl1cNyVwi+kRWjiwd6dV2K0q ZZpnL0FVOFvpBLuCi6akEG+MFOqyspvKPj5ZXV6kGCBDN9o4A/hC0KnbXQd1K4g+eL/PiggmgzJxC tP2kljEB4zJlWSjDoV3k68wclt55OnD0Z0xjxJFs+MO3lt4CCIEWSKGwjx676FT+JPNzptXzpDz8Z gIVy9h8xUHMywRU8f02JJAPi0ZUlPRjGEdyFuQPdsKrnbZCTMx99dZ5xlEfiWbYpQNy6H71aT/ZJw lSYJAUzug==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kILpW-00023K-HQ; Wed, 16 Sep 2020 01:01:50 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kILpS-00022T-Oh for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 01:01:47 +0000 Received: by mail-pf1-x444.google.com with SMTP id d9so2975184pfd.3 for ; Tue, 15 Sep 2020 18:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DycTmxSFFnDVXWFUqr21zhna4kBRrUqR0acmd5MtpdQ=; b=GxnJyXiq4QG+ghyb61K6sKuh3mV+hxrs8JA7BWsf3+9XItarPjm0OW4IccPj9xtF2N sxJS+xiFJ9u6MWEmxHVmvqJsqhPr1GSJZXvwaxBofSrMHZMSp8n80MHY5dd8L024tesz wUcLR9bBtLq7lNQBylSiR0dfbAhTerBafpMmDsvX2OEkyD6P5Y8S+d16gujIjplpEbxp LZPBXvTbjQIJ7sFyQDXn4FPIQsm5sSMHF29Umvlvfw/+sw0RVQE5UFZIMiD97nhRnBDX 8kK7fd55zieoLW37kygtOLJaarl1NlBhH2whlPDhid36Zh7U2i/XGMxQTMF+WNFWnseY OFng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DycTmxSFFnDVXWFUqr21zhna4kBRrUqR0acmd5MtpdQ=; b=YoFcmftjRaaLIVw6wsRpy2UAdMu2e1B1wkGJTuqhUHeZgPaPLDodG0+k+HM3wDhe47 wleTPeAi6FToNf0S3LdoxJx4Ng5tyyzwLmKIUNO8T07Ng9i1A0d3js86mJTBamSsRODb y054jFHwmf2SrgnYXZ1cUcmh7HtbXBHLUHsC6gkaplIH3odeowaWS9uqhJ+pRHQCutgv IAKJeonOxHBgP/wcEGcDdaJQklmMJJ0rtqKmiXyGEmO+J9Z7Y3wL3Ahbk5+lr6SflN+5 Wy/mzzfun3PHc8Vt7RPSY7QXVmd/QrPetXaXvimYAUpmiIoinyYKyf0V/kxwV7LkTaPe iKrw== X-Gm-Message-State: AOAM5335SWVFFkLYWVashSP7frMGRrJkBnAFTxYFbyT4axzjzlyQKS0d ZPpcS57ABPQGjUKJBAP9xYLh/+WNtDs= X-Google-Smtp-Source: ABdhPJwnm/FnXuLqgQyD1LM4EpxtcV+dBr1YFz0ubNGr228NPkWg4tawBz7y5hafZWeyOVS5fwQPdw== X-Received: by 2002:aa7:9491:0:b029:142:2501:34dd with SMTP id z17-20020aa794910000b0290142250134ddmr4273238pfk.54.1600218103467; Tue, 15 Sep 2020 18:01:43 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id y203sm14338924pfb.58.2020.09.15.18.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 18:01:42 -0700 (PDT) Date: Tue, 15 Sep 2020 18:01:40 -0700 From: Dmitry Torokhov To: Krzysztof Kozlowski Subject: Re: [PATCH v2 4/4] Input: sun4i-ps2 - Fix handling of platform_get_irq() error Message-ID: <20200916010140.GG1681290@dtor-ws> References: <20200828145744.3636-1-krzk@kernel.org> <20200828145744.3636-4-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200828145744.3636-4-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_210146_821293_D9DC4C05 X-CRM114-Status: GOOD ( 20.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, Maxime Ripard , linux-input@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 28, 2020 at 04:57:44PM +0200, Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: e443631d20f5 ("Input: serio - add support for Alwinner A10/A20 PS/2 controller") > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. None > --- > drivers/input/serio/sun4i-ps2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c > index a681a2c04e39..7da1ea8741fc 100644 > --- a/drivers/input/serio/sun4i-ps2.c > +++ b/drivers/input/serio/sun4i-ps2.c > @@ -265,9 +265,8 @@ static int sun4i_ps2_probe(struct platform_device *pdev) > > /* Get IRQ for the device */ > irq = platform_get_irq(pdev, 0); > - if (!irq) { > - dev_err(dev, "no IRQ found\n"); > - error = -ENXIO; > + if (irq < 0) { "irq" is unsigned here, so this will not work. I'll change it to use drvdat->irq which happens to be signed, and drop "irq" variable. > + error = irq; > goto err_disable_clk; > } > > -- > 2.17.1 > Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel