Re: [PATCH v4 5/5] arm64: dts: ti: Add support for J7200 Common Processor Board

[Nishanth Menon <nm@ti.com>]

On 10:33-20200915, Suman Anna wrote:
> On 9/14/20 11:22 AM, Lokesh Vutla wrote:
> > Add support for J7200 Common Processor Board.
> > The EVM architecture is very similar to J721E as follows:
> > 
> > +------------------------------------------------------+
> > |   +-------------------------------------------+      |
> > |   |                                           |      |
> > |   |        Add-on Card 1 Options              |      |
> > |   |                                           |      |
> > |   +-------------------------------------------+      |
> > |                                                      |
> > |                                                      |
> > |                     +-------------------+            |
> > |                     |                   |            |
> > |                     |   SOM             |            |
> > |  +--------------+   |                   |            |
> > |  |              |   |                   |            |
> > |  |  Add-on      |   +-------------------+            |
> > |  |  Card 2      |                                    |    Power Supply
> > |  |  Options     |                                    |    |
> > |  |              |                                    |    |
> > |  +--------------+                                    | <---
> > +------------------------------------------------------+
> >                                 Common Processor Board
> > 
> > Common Processor board is the baseboard that has most of the actual
> > connectors, power supply etc. A SOM (System on Module) is plugged on
> > to the common processor board and this contains the SoC, PMIC, DDR and
> > basic high speed components necessary for functionality.
> > 
> > Note:
> > * The minimum configuration required to boot up the board is System On
> >   Module(SOM) + Common Processor Board.
> > * Since there is just a single SOM and Common Processor Board, we are
> >   maintaining common processor board as the base dts and SOM as the dtsi
> >   that we include. In the future as more SOM's appear, we should move
> >   common processor board as a dtsi and include configurations as dts.
> > * All daughter cards beyond the basic boards shall be maintained as
> >   overlays.
> > 
> > Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > ---
> >  arch/arm64/boot/dts/ti/Makefile               |  2 +
> >  .../dts/ti/k3-j7200-common-proc-board.dts     | 64 +++++++++++++++++++
> >  arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi   | 29 +++++++++
> >  3 files changed, 95 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> >  create mode 100644 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> > 
> > diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> > index 7f28be62b8da..65506f21ba30 100644
> > --- a/arch/arm64/boot/dts/ti/Makefile
> > +++ b/arch/arm64/boot/dts/ti/Makefile
> > @@ -9,3 +9,5 @@
> >  dtb-$(CONFIG_ARCH_K3) += k3-am654-base-board.dtb
> >  
> >  dtb-$(CONFIG_ARCH_K3) += k3-j721e-common-proc-board.dtb
> > +
> > +dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb
> > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > new file mode 100644
> > index 000000000000..e27069317c4e
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> > @@ -0,0 +1,64 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2020 Texas Instruments Incorporated - https://www.ti.com/
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "k3-j7200-som-p0.dtsi"
> > +
> > +/ {
> > +	chosen {
> > +		stdout-path = "serial2:115200n8";
> > +		bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
> > +	};
> > +};
> > +
> > +&wkup_uart0 {
> > +	/* Wakeup UART is used by System firmware */
> > +	status = "disabled";
> > +};
> > +
> > +&main_uart0 {
> > +	power-domains = <&k3_pds 146 TI_SCI_PD_SHARED>;
> 
> Perhaps a comment here to explain why this is being overwritten to use
> PD_SHARED. I don't see anything in the Changelog either.
Shared with ATF on this platform -> I can add this comment on applying.
> 
> Otherwise, looks good.

Would that be a reviewed-by?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel