From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE494C433E2 for ; Wed, 16 Sep 2020 08:00:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66BAD206B6 for ; Wed, 16 Sep 2020 08:00:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mZFlFEHo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66BAD206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NWGqP4iKqwQxGrL9FUw2QUI030CQW32oiSu9ICYcTpE=; b=mZFlFEHoq5nJEp4cITn9OWfl+ Mfw2P8w4Iw7AbeYVAC4gxcgTdMAudlWeoVoJ6yxWffAcB9c5WxtedZEajm0JsDS8cUeArgoEdBr6x k4hBJ9ABtyMpOmAftL3nAzycvR4LgBchUt5Ugf2hHSb8U1ewIoC7GDCwxQrr+xAI6GfRwQDRQ6MhY iA5KEtBOaZfPJaS0BFMeJwjKKWFK+ExfStEL2gyipVtFVBJwaakXW41a2g4gnaNPhrn3LFOcx0NAD R/DUHV8r5eEhw5XUqWAEb2jEddF5ifv9BldvG1zT0u25cuheldQ05UvA6Zv4bZ3nzIqMcBXxdHMDr ipBiRzmCw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kISLU-00044m-6N; Wed, 16 Sep 2020 07:59:16 +0000 Received: from mail-wm1-f66.google.com ([209.85.128.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kISLQ-00043q-OW for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 07:59:14 +0000 Received: by mail-wm1-f66.google.com with SMTP id l15so1640877wmh.1 for ; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f9vR3Ti7HGJjlVupS35gCwKRPU2ouBmpdxOZm0a6pHg=; b=CGxQDShwatuASyR56GzYndl8hdSI0N9f2I26u1dzliCr5j+Pio5b7J6j0mlWj9DoWW 5jAiDqxRMQqPBuGckm7uATCxgMU9QA8a9oeRHXElvwQHoc+jOAPJW5DTvOCLK8jxQij3 X0AIM3g/p2L94MrPGokXsOTeiKqGom5WhCwGkIlk9Jc3r7B4OCZ72db/mjbbcxNqByZC tpht7kHvUZ2XfvynWAh5ZXf5kO6uMQySK2mAVH1ltntmI9ImstUUnf7Q5oQ/idVBCEdm ktuKKFcPkEwYCI764aDKwqnyNYrjjZEqJTu1OVA5T9JDuzF2/bnEoH5mNLjNMcn/R9nD YHCA== X-Gm-Message-State: AOAM532t6w7T32QRaGC34kRDb0HUcIeTnC+N8SEh1TugrEgsst1PQThd s2VJJAxfFhDoTb50Ypyz1fs= X-Google-Smtp-Source: ABdhPJxvAiLHTzMl+wXAqNoAvB4Yv/BV83AUKMAclJ4hQWRQUQ98jocoP+WC+dpkBraRRwrLGVhbrg== X-Received: by 2002:a1c:7c1a:: with SMTP id x26mr3467656wmc.112.1600243151114; Wed, 16 Sep 2020 00:59:11 -0700 (PDT) Received: from kozik-lap ([194.230.155.124]) by smtp.googlemail.com with ESMTPSA id a81sm4022587wmf.32.2020.09.16.00.59.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Sep 2020 00:59:09 -0700 (PDT) Date: Wed, 16 Sep 2020 09:59:07 +0200 From: Krzysztof Kozlowski To: Andrzej Hajda Subject: Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2 Message-ID: <20200916075907.GA10270@kozik-lap> References: <20200829142501.31478-1-krzk@kernel.org> <20200829142501.31478-9-krzk@kernel.org> <4eb7d0d9-29e2-9162-4521-10e4422f9c71@samsung.com> <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <021495a9-7a00-eb91-ddfa-885cc2fb5462@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_035913_083353_0E774E7D X-CRM114-Status: GOOD ( 27.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , Chanwoo Choi , David Airlie , Mark Brown , Daniel Lezcano , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Sangbeom Kim , Bartlomiej Zolnierkiewicz , Kukjin Kim , dri-devel@lists.freedesktop.org, Daniel Vetter , Thomas Gleixner , Sylwester Nawrocki , Lee Jones , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 02, 2020 at 01:23:50PM +0200, Andrzej Hajda wrote: > > On 31.08.2020 14:50, Marek Szyprowski wrote: > > Hi Krzysztof, > > > > On 29.08.2020 16:25, Krzysztof Kozlowski wrote: > >> The USB-C connector bindings require port@0. Such port was already > >> described in DTS but outside of the connector itself. Put it into > >> proper place to fix dtbs_check warnings like: > >> > >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: musb_connector: ports: 'port@0' is a required property > >> > >> Signed-off-by: Krzysztof Kozlowski > > I'm not sure if topic should be about USB-C, I will call it simply USB > > connector node. TM2(e) uses Samsung's 11-pin micro USB 2.0 connector, > > which has nothing in common with USB Type-C. > > > > Anyway, this patch breaks DWC3 (tested in Device mode) driver operation, > > so something has to be somehow adjusted or fixed. Added CC Andrzej > > Hajda, who actually worked on this. > > > >> --- > >> > >> Not tested on HQ. Please kindly review and test. > >> > >> Best regards, > >> Krzysztof > >> --- > >> .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 15 +++++++-------- > >> 1 file changed, 7 insertions(+), 8 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> index 6246cce2a15e..bab6c1addd5f 100644 > >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > >> @@ -871,6 +871,13 @@ > >> #address-cells = <1>; > >> #size-cells = <0>; > >> > >> + port@0 { > >> + reg = <0>; > >> + muic_to_usb: endpoint { > >> + remote-endpoint = <&usb_to_muic>; > >> + }; > >> + }; > >> + > > > According to not-yet-yaml documentation of dt-bindings (patch 05/10): > > -Required nodes: > > -- any data bus to the connector should be modeled using the OF graph bindings > > - specified in bindings/graph.txt, unless the bus is between parent node and > > - the connector. > > This is 'unless' case - muic is parent of the connector, so the port 0 is not necessary. > > > >> port@3 { > >> reg = <3>; > >> musb_con_to_mhl: endpoint { > >> @@ -879,14 +886,6 @@ > >> }; > >> }; > >> }; > >> - > >> - ports { > >> - port { > >> - muic_to_usb: endpoint { > >> - remote-endpoint = <&usb_to_muic>; > >> - }; > >> - }; > > > And this port belongs to MUIC - it describes connection between USB-HOST > and MUIC, it has nothing to do with the connector, and is necessary. Thanks for checking this. It's really appreciated! I'll work on v2 later to address the schema warning, hopefully without breaking things... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel