From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D739C433E2 for ; Wed, 16 Sep 2020 08:34:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDBAF20795 for ; Wed, 16 Sep 2020 08:34:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wAFLvaif"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RyMJhFWO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDBAF20795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nByPPknO7eh6MpksdqujkAYAR0YjleTm+RV8hyLYHKY=; b=wAFLvaifAeIuziYMtsyl5oJiT J4obfnCv59OKC53fMFwr26R33wT8ocaOBnbtuNxPnGfdp48LQhUnKZ2u7Q0eKsqaDeyHz706ayReG 93JyLt5uQcuY/43kJjpkOPDabhi0GWuUZza0f4DSNdLEmDJkb0JNmTmPhU5BsofONrI61qVuFYnxG Wp2z7V6+g3XxPsBHID4TtXIuAae6MgU3N2LLVoulBLsUTAUofBVFBVxdVy4XGiGDdTXORVZp2AnoD ufNEOauV8NbAAtH3eYMlKvlrXVBJAHYKS5HtBheSwdJKlDAUE8Tafqc1EbkwUh/gd5eg8dUIryooB YAHpT89Xg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kISsV-0001bK-SB; Wed, 16 Sep 2020 08:33:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kISsT-0001aZ-M5 for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 08:33:22 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11A12206DC; Wed, 16 Sep 2020 08:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600245200; bh=hZD6Zy7WdDq71T8XLF+vpP+BlqkstySbFXt4pCl8CIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RyMJhFWOsymi1JLqBzFr0sWwBETAFEFcwU6V6gU/zpoU9wx0iiDJwKRta9VIj/Ly6 HC1uECiMfvQ/om/DldYAJbAUgHzg3C8Zz6bAt4dP8oPHkblcshPd2QCqt40TJiNXip HHlH17B2Gax3zyMo+/SVJjD9cmSVT9f+8VrGICJA= Date: Wed, 16 Sep 2020 09:33:16 +0100 From: Will Deacon To: Jason Gunthorpe Subject: Re: [PATCH] arm64: Enable PCI write-combine resources under sysfs Message-ID: <20200916083315.GC27496@willie-the-truck> References: <20200914142406.k44zrnp2wdsandsp@amazon.com> <20200914143819.GC904879@nvidia.com> <375c478593945a416f3180c3773bcb5240d2e36c.camel@kernel.crashing.org> <1d6f2ceb8d3538c906a1fdb8cd3d4c74ccffa42e.camel@kernel.crashing.org> <20200914225740.GP904879@nvidia.com> <2b539df4c9ec703458e46da2fc879ee3b310b31c.camel@kernel.crashing.org> <20200915101831.GA2616@e121166-lin.cambridge.arm.com> <20200915110511.GQ904879@nvidia.com> <20200915234006.GI1573713@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200915234006.GI1573713@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_043321_789042_FABA8C20 X-CRM114-Status: GOOD ( 27.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , catalin.marinas@arm.com, Leon Romanovsky , Benjamin Herrenschmidt , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Clint Sbisa Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 08:40:06PM -0300, Jason Gunthorpe wrote: > On Wed, Sep 16, 2020 at 09:17:38AM +1000, Benjamin Herrenschmidt wrote: > > On Tue, 2020-09-15 at 08:05 -0300, Jason Gunthorpe wrote: > > > > To sum it up: > > > > > > > > (1) RDMA drivers need a new mapping function/attribute to define their > > > > message push model. Actually the message model is not necessarily related > > > > to write combining a la x86, so we should probably come up with a better > > > > and consistent naming. Enabling this patchset may trigger performance > > > > regressions on mellanox drivers on arm64 - this ought to be > > > > addressed. > > > > > > It is pretty clear now that the certain ARM chips that don't do write > > > combining with pgprot_writecombine will performance regress if they > > > are running a certain uncommon Mellanox configuration. I suspect these > > > deployments are all running the out of tree patch for DEVICE_GRE > > > though. > > > > I'm not sure I understand... > > > > Today those ARM chips will not use pgprot_writecombine (at least not > > using that code path, they might still use it as the result of the > > other path in the driver that can enable it). > > Not quite, upstream kernel will never use WC on those > devices. DEVICE_GRE is not supported in upstream, > arch_can_pci_mmap_wc() is always false and the WC tester will always > fail. > > > With the patch, those device will now use MT_DEVICE_NC. > > Which doesn't do WC at all on some ARM implementations. Is that just TX2? I remember that thing being weird where GRE performed better than NC, but I thought that was a one off (and the thing is dead). NC is more permissive than GRE, so I think that's the right one to use; i.e. we go for the fewest number of restrictions on the hardware. If somebody screws up the uarch, that's up to them. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel