From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCE7C433E2 for ; Wed, 16 Sep 2020 08:39:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 013B12064E for ; Wed, 16 Sep 2020 08:39:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bx4cwUp1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qGEn+X97" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 013B12064E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lp7T4tTB83vaArkvIsPJS/IRZumzuOUZkSb/Y7uMcKo=; b=bx4cwUp1MjHyYoRkRRGuq32r1 qv4FEqEXZnG9M0AUXzeritfMiitG2+PLb4zoeT870Y+r32JutzTamXIt8TLd7V1lvlzmKX7WGS/69 sgdWpJSOjQ3Z9+SohfmQmrYF1jgB3WAe9woOVuK2HCgPH/kM8cUKO18na6pM/0MZTUn8Ag03JOqVQ +D6jN9EFUhJ9Ir3MIbe3/Jo1VtWQp7QH1yQxTM1J6j6MbETSarNOeB0yK1TvWUQ+1RDBXsy11WgyD iuwQXKj+AJdES18/P4if2RYO5MgSN2ksNAGMfY0BMUSa4EXp33vV+jqJ8gDij/8ybsv6PTPfEUnpB tTMyxITrQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kISx3-0002Xk-DD; Wed, 16 Sep 2020 08:38:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kISx1-0002XD-9e for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 08:38:04 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4FA82064E; Wed, 16 Sep 2020 08:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600245482; bh=ayHqD0TxwK+DKfoaoQ5U/0qGfOY6exkP6goS8angK4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qGEn+X97bm/YN/f+V8umKxtNMSFx/ciTUIo7tQe8epZAfaYwBRvP6AEB5Z5NInYAD S3STXFRBhTgYskh7xiRZm9P5KJIN/vOPJWDaBdcjdTou5QCVZYtRIuk2X40h3l80fw uQ5jSfJsSaY2ecWqqpn4aTryoCuef03zQiXcvC+s= Date: Wed, 16 Sep 2020 09:37:57 +0100 From: Will Deacon To: Xiaofei Tan Subject: Re: [PATCH v2] KVM: arm64: fix doc warnings in mmu code Message-ID: <20200916083756.GD27496@willie-the-truck> References: <1600221639-4471-1-git-send-email-tanxiaofei@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1600221639-4471-1-git-send-email-tanxiaofei@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_043803_406525_76F6FEF5 X-CRM114-Status: GOOD ( 22.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, maz@kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 16, 2020 at 10:00:39AM +0800, Xiaofei Tan wrote: > Fix following warnings caused by mismatch bewteen function parameters > and comments. > arch/arm64/kvm/mmu.c:128: warning: Function parameter or member 'mmu' not described in '__unmap_stage2_range' > arch/arm64/kvm/mmu.c:128: warning: Function parameter or member 'may_block' not described in '__unmap_stage2_range' > arch/arm64/kvm/mmu.c:128: warning: Excess function parameter 'kvm' description in '__unmap_stage2_range' > arch/arm64/kvm/mmu.c:499: warning: Function parameter or member 'writable' not described in 'kvm_phys_addr_ioremap' > arch/arm64/kvm/mmu.c:538: warning: Function parameter or member 'mmu' not described in 'stage2_wp_range' > arch/arm64/kvm/mmu.c:538: warning: Excess function parameter 'kvm' description in 'stage2_wp_range' > > Signed-off-by: Xiaofei Tan > --- > arch/arm64/kvm/mmu.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index e8a51799..909e995 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -114,9 +114,10 @@ static bool kvm_is_device_pfn(unsigned long pfn) > */ > /** > * unmap_stage2_range -- Clear stage2 page table entries to unmap a range > - * @kvm: The VM pointer > + * @mmu: pointer to mmu structure to operate on > * @start: The intermediate physical base address of the range to unmap > * @size: The size of the area to unmap > + * @may_block: The flag that if block is allowed here Whether or not we are permitted to block. > * > * Clear a range of stage-2 mappings, lowering the various ref-counts. Must > * be called while holding mmu_lock (unless for freeing the stage2 pgd before > @@ -493,6 +494,7 @@ void kvm_free_stage2_pgd(struct kvm_s2_mmu *mmu) > * @guest_ipa: The IPA at which to insert the mapping > * @pa: The physical address of the device > * @size: The size of the mapping > + * @writable: If it is writable here Whether or not to create a writable mapping. > */ > int kvm_phys_addr_ioremap(struct kvm *kvm, phys_addr_t guest_ipa, > phys_addr_t pa, unsigned long size, bool writable) > @@ -530,7 +532,7 @@ int kvm_phys_addr_ioremap(struct kvm *kvm, phys_addr_t guest_ipa, > > /** > * stage2_wp_range() - write protect stage2 memory region range > - * @kvm: The KVM pointer > + * @mmu: pointer to mmu structure to operate on The KVM stage-2 MMU pointer. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel