From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3D3C43461 for ; Wed, 16 Sep 2020 09:34:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 448A022208 for ; Wed, 16 Sep 2020 09:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VdmA+TnG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A+yh78E6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 448A022208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7+C2R5mQQdP4Q+IhpSTbgsPFbX2Uw25GmVIGs/ZFlGE=; b=VdmA+TnGDbV9wR3AEOM1k86Hx ScWgajbFuH7OctYyeHc79OwL53v7DzeehLdJNHmpxffEJvtEKrZfyOciQkGYjWN9W2HdjArc8ZBJs 8Xi0JwG7XRYBBzIXpHTeGMgyB8EEkJ32tF7t2WwG5CKmXmTPV9q3W0rRuKaFt5al3aBNnoV3fRCvQ OEPzT2OECgSMqMFE/ZGpUEnCkAltUmLg0vvnKEZ+ZziwY8O4EItQwtmanMpR6JC6cEDsingxjphbD jNMWsG5vqowVALwlgywk/BvytYEEpJWyYtyL5hQHuqCp0RaF+vX9dJ27LR6+dOPyZPHvizaJNtq0W 9IHB8BLzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIToT-0001ZI-QA; Wed, 16 Sep 2020 09:33:17 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIToR-0001YK-4S for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 09:33:15 +0000 Received: by mail-wm1-x342.google.com with SMTP id k18so2226325wmj.5 for ; Wed, 16 Sep 2020 02:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YjecuPhauQHL4j4Z2a9keky4ajO3faW/VO0iw9ZMsyw=; b=A+yh78E6fm9DBZfbdqzQH+qzcsEGu6J4+jBTWy2YENyyyt2Zbq0S/OFMY+YMWluCW8 z8t3xi+iP90JmyDxktlPvCO+1T3U3hFBPr8qrN+yRgMmJ0GM2L7qRI0Eo3AOZ7RMkQPe LWE3uzHR7S4jsQzPTnyioG1nqAXIH9Jsv1zZo5fzHTOi1paYswkOFIvKmndmutMHCR0b y7j++ofj0gze7dcveAmPNZVSNVJ8f7dc9HkoqOY5StLB4q0UsS53QODCjO0b8LP6kuiJ 8vHisP+2YnnZzbQCZ5tRX2F0md65KbL3npfLcO72aSz6q9hmrXsAZ2AjIqklFE2qGRqP eeXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YjecuPhauQHL4j4Z2a9keky4ajO3faW/VO0iw9ZMsyw=; b=ZJiIwcdcGFwXB2n4Lt4upn+Dyo0ZonG7AUxSMlob+o0QF2f1yhipbDO+2vHs2mB4yF WFuhKBfd0T7nufhMt+KjJ6dTa2Xl++YuoriiRrkyLQyJZ0JAQNX66zCCsbLPrLIJxLD+ JidtXrBlPAHHnGYuuNkUBQQd/sY3YasupU1Fv6ISzr6SYHPKIKmumU1d2KiWUBy1no7q TzHg7oJGYFU29YBoo2exIaQxHuferkIuGElfBytha6d3JZ6Hy/N1ARSDeYX+CtCsx2wG Gch013dWM3YtJHikN/u9zLiXsDKXdHykefv04xEwuaYzQ1EIZSTxVaACXGpShb84KV9K 8ugQ== X-Gm-Message-State: AOAM533So31Ew6S26mIzDQCdH2+r2CbXNczU7MVL2peHXcbWKv6YNTgj 3FF5ldj9+xS+r7Gm5mRVXm8= X-Google-Smtp-Source: ABdhPJxBZS9ztI4xvrbGTpOSw6c/HLSysA8VOVuU/1daXUC/dE1jO2LoC/ZzlHwtXxsbSfmuJA8jmA== X-Received: by 2002:a05:600c:2047:: with SMTP id p7mr4017341wmg.168.1600248792836; Wed, 16 Sep 2020 02:33:12 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id u8sm4171183wmj.45.2020.09.16.02.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 02:33:11 -0700 (PDT) Date: Wed, 16 Sep 2020 11:33:09 +0200 From: Corentin Labbe To: Krzysztof Kozlowski Subject: Re: [PATCH v2 4/4] crypto: allwinner/sun8i - Simplify with dev_err_probe() Message-ID: <20200916093309.GA11483@Red> References: <20200910192919.12503-1-krzk@kernel.org> <20200910192919.12503-4-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200910192919.12503-4-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_053315_205038_4FE3F30B X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aymen Sghaier , Herbert Xu , Horia =?utf-8?Q?Geant=C4=83?= , Iuliana Prodan , linux-kernel@vger.kernel.org, Maxime Ripard , linux-stm32@st-md-mailman.stormreply.com, Chen-Yu Tsai , linux-crypto@vger.kernel.org, Maxime Coquelin , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Alexandre Torgue Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 10, 2020 at 09:29:19PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. None > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 9 +++------ > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 9 +++------ > 2 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > index 138759dc8190..e3c62051c595 100644 > --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c > @@ -573,12 +573,9 @@ static int sun8i_ce_probe(struct platform_device *pdev) > return irq; > > ce->reset = devm_reset_control_get(&pdev->dev, NULL); > - if (IS_ERR(ce->reset)) { > - if (PTR_ERR(ce->reset) == -EPROBE_DEFER) > - return PTR_ERR(ce->reset); > - dev_err(&pdev->dev, "No reset control found\n"); > - return PTR_ERR(ce->reset); > - } > + if (IS_ERR(ce->reset)) > + return dev_err_probe(&pdev->dev, PTR_ERR(ce->reset), > + "No reset control found\n"); > > mutex_init(&ce->mlock); > > diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > index 9a23515783a6..576df8c8df51 100644 > --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c > @@ -545,12 +545,9 @@ static int sun8i_ss_probe(struct platform_device *pdev) > return irq; > > ss->reset = devm_reset_control_get(&pdev->dev, NULL); > - if (IS_ERR(ss->reset)) { > - if (PTR_ERR(ss->reset) == -EPROBE_DEFER) > - return PTR_ERR(ss->reset); > - dev_err(&pdev->dev, "No reset control found\n"); > - return PTR_ERR(ss->reset); > - } > + if (IS_ERR(ss->reset)) > + return dev_err_probe(&pdev->dev, PTR_ERR(ss->reset), > + "No reset control found\n"); > > mutex_init(&ss->mlock); > > -- > 2.17.1 > Hello Acked-by: Corentin Labbe Tested-by: Corentin Labbe Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel