From: Dave Martin <Dave.Martin@arm.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: suzuki.poulose@arm.com, catalin.marinas@arm.com, rdna@fb.com,
linuxarm@huawei.com, james.morse@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/fpsimd: Fix missing-prototypes in fpsimd.c
Date: Wed, 16 Sep 2020 11:36:46 +0100 [thread overview]
Message-ID: <20200916103641.GY6642@arm.com> (raw)
In-Reply-To: <1600157999-14802-1-git-send-email-tiantao6@hisilicon.com>
On Tue, Sep 15, 2020 at 04:19:59PM +0800, Tian Tao wrote:
> Fix the following warnings.
> arch/arm64/kernel/fpsimd.c:935:6: warning: no previous prototype for
> ‘do_sve_acc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:962:6: warning: no previous prototype for
> ‘do_fpsimd_acc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:971:6: warning: no previous prototype for
> ‘do_fpsimd_exc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:1266:6: warning: no previous prototype for
> ‘kernel_neon_begin’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:1292:6: warning: no previous prototype for
> ‘kernel_neon_end’ [-Wmissing-prototypes]
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Strange this was missed in the past. I guess the warnings have become
more aggressive.
Was this encountered using defconfig?
Either way, the change seems sensible:
Reviewed-by: Dave Martin <Dave.Martin@arm.com>
> ---
> arch/arm64/kernel/fpsimd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
> index 55c8f3e..0a637e3 100644
> --- a/arch/arm64/kernel/fpsimd.c
> +++ b/arch/arm64/kernel/fpsimd.c
> @@ -32,9 +32,11 @@
> #include <linux/swab.h>
>
> #include <asm/esr.h>
> +#include <asm/exception.h>
> #include <asm/fpsimd.h>
> #include <asm/cpufeature.h>
> #include <asm/cputype.h>
> +#include <asm/neon.h>
> #include <asm/processor.h>
> #include <asm/simd.h>
> #include <asm/sigcontext.h>
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-16 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 8:19 [PATCH] arm64/fpsimd: Fix missing-prototypes in fpsimd.c Tian Tao
2020-09-16 10:36 ` Dave Martin [this message]
2020-09-18 16:17 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916103641.GY6642@arm.com \
--to=dave.martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=rdna@fb.com \
--cc=suzuki.poulose@arm.com \
--cc=tiantao6@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).