* [PATCH] arm64/fpsimd: Fix missing-prototypes in fpsimd.c
@ 2020-09-15 8:19 Tian Tao
2020-09-16 10:36 ` Dave Martin
2020-09-18 16:17 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Tian Tao @ 2020-09-15 8:19 UTC (permalink / raw)
To: catalin.marinas, will, rdna, james.morse, suzuki.poulose,
Dave.Martin, linux-arm-kernel
Cc: linuxarm
Fix the following warnings.
arch/arm64/kernel/fpsimd.c:935:6: warning: no previous prototype for
‘do_sve_acc’ [-Wmissing-prototypes]
arch/arm64/kernel/fpsimd.c:962:6: warning: no previous prototype for
‘do_fpsimd_acc’ [-Wmissing-prototypes]
arch/arm64/kernel/fpsimd.c:971:6: warning: no previous prototype for
‘do_fpsimd_exc’ [-Wmissing-prototypes]
arch/arm64/kernel/fpsimd.c:1266:6: warning: no previous prototype for
‘kernel_neon_begin’ [-Wmissing-prototypes]
arch/arm64/kernel/fpsimd.c:1292:6: warning: no previous prototype for
‘kernel_neon_end’ [-Wmissing-prototypes]
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
arch/arm64/kernel/fpsimd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
index 55c8f3e..0a637e3 100644
--- a/arch/arm64/kernel/fpsimd.c
+++ b/arch/arm64/kernel/fpsimd.c
@@ -32,9 +32,11 @@
#include <linux/swab.h>
#include <asm/esr.h>
+#include <asm/exception.h>
#include <asm/fpsimd.h>
#include <asm/cpufeature.h>
#include <asm/cputype.h>
+#include <asm/neon.h>
#include <asm/processor.h>
#include <asm/simd.h>
#include <asm/sigcontext.h>
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64/fpsimd: Fix missing-prototypes in fpsimd.c
2020-09-15 8:19 [PATCH] arm64/fpsimd: Fix missing-prototypes in fpsimd.c Tian Tao
@ 2020-09-16 10:36 ` Dave Martin
2020-09-18 16:17 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Dave Martin @ 2020-09-16 10:36 UTC (permalink / raw)
To: Tian Tao
Cc: suzuki.poulose, catalin.marinas, rdna, linuxarm, james.morse,
will, linux-arm-kernel
On Tue, Sep 15, 2020 at 04:19:59PM +0800, Tian Tao wrote:
> Fix the following warnings.
> arch/arm64/kernel/fpsimd.c:935:6: warning: no previous prototype for
> ‘do_sve_acc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:962:6: warning: no previous prototype for
> ‘do_fpsimd_acc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:971:6: warning: no previous prototype for
> ‘do_fpsimd_exc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:1266:6: warning: no previous prototype for
> ‘kernel_neon_begin’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:1292:6: warning: no previous prototype for
> ‘kernel_neon_end’ [-Wmissing-prototypes]
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Strange this was missed in the past. I guess the warnings have become
more aggressive.
Was this encountered using defconfig?
Either way, the change seems sensible:
Reviewed-by: Dave Martin <Dave.Martin@arm.com>
> ---
> arch/arm64/kernel/fpsimd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
> index 55c8f3e..0a637e3 100644
> --- a/arch/arm64/kernel/fpsimd.c
> +++ b/arch/arm64/kernel/fpsimd.c
> @@ -32,9 +32,11 @@
> #include <linux/swab.h>
>
> #include <asm/esr.h>
> +#include <asm/exception.h>
> #include <asm/fpsimd.h>
> #include <asm/cpufeature.h>
> #include <asm/cputype.h>
> +#include <asm/neon.h>
> #include <asm/processor.h>
> #include <asm/simd.h>
> #include <asm/sigcontext.h>
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64/fpsimd: Fix missing-prototypes in fpsimd.c
2020-09-15 8:19 [PATCH] arm64/fpsimd: Fix missing-prototypes in fpsimd.c Tian Tao
2020-09-16 10:36 ` Dave Martin
@ 2020-09-18 16:17 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2020-09-18 16:17 UTC (permalink / raw)
To: Dave.Martin, suzuki.poulose, rdna, linux-arm-kernel, james.morse,
Tian Tao, catalin.marinas
Cc: Will Deacon, kernel-team, linuxarm
On Tue, 15 Sep 2020 16:19:59 +0800, Tian Tao wrote:
> Fix the following warnings.
> arch/arm64/kernel/fpsimd.c:935:6: warning: no previous prototype for
> ‘do_sve_acc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:962:6: warning: no previous prototype for
> ‘do_fpsimd_acc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:971:6: warning: no previous prototype for
> ‘do_fpsimd_exc’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:1266:6: warning: no previous prototype for
> ‘kernel_neon_begin’ [-Wmissing-prototypes]
> arch/arm64/kernel/fpsimd.c:1292:6: warning: no previous prototype for
> ‘kernel_neon_end’ [-Wmissing-prototypes]
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64/fpsimd: Fix missing-prototypes in fpsimd.c
https://git.kernel.org/arm64/c/c6b90d5cf637
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-18 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-15 8:19 [PATCH] arm64/fpsimd: Fix missing-prototypes in fpsimd.c Tian Tao
2020-09-16 10:36 ` Dave Martin
2020-09-18 16:17 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).