From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E46C433E2 for ; Wed, 16 Sep 2020 12:25:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B270520659 for ; Wed, 16 Sep 2020 12:25:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bZGn/2N1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ecyvxJA9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B270520659 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3Bx/3hpqsbSCwAqp8jIRW2E1JzD6tILQhTXIkrBSPDI=; b=bZGn/2N1KMkRZtPFhjh820cUP h1Gr8Ln+AcLwfh0xAyyxVNH0PKv9Fdd9bqr8pwW6Xe6K7+N45jUZTbYfrXpZyDxoJ8wTfBQeLl2eU dcjlw4F2uOVJFw9NjJacYoYwg/BJX9+IScItkpiWX2gIVxEA+jTegx7HQIIztIayaQ81fkHjmjpLu 5KrHZEfoVL9G+EiHgzuEuLHKmKdOyn03HJRqQ8CGnxqtJOn8LiIcAWnucMQgdDRO2Yb6ZioNgA1Hv XtvR+j8YtCKpqWovmgIJnywBARM1RnyDQ5oNzvtPRzjCeYlw4nNIBn8kBennoK4U3qPAF8NFq/GlR S0ws2w44g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIWTy-0004A4-3t; Wed, 16 Sep 2020 12:24:18 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIWTv-00049A-Ef for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 12:24:16 +0000 Received: by mail-wr1-x443.google.com with SMTP id k15so6686690wrn.10 for ; Wed, 16 Sep 2020 05:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yWmAHcgT2wDa3AHqlJ16t/WowuUKj+5oH128IS3to+s=; b=ecyvxJA9SssekdAOtuviJ13pOnV2clLGkWhiOWO+2yrKD8LW/yxDkjFG3CzSaKPwdz lO4l8QLk4EjgOwdsycDk3JkggZLdyWLIjx79hY9n3+KYGB1WQIAQ4FECAlbZPLNNzst2 +V8xxssKHQL+hxHT661evNUe9qi63Lr5THWvEXVzmU8ys481d4Icv0X7UrGAWcX3Y6R6 TW53J0GJUqSsZ/FtTU9WDgV3l69ZLSMQ+ne9CePfgEfWy5GDf3/fHWWq15NCFehU95v3 AHJkB5O7SLJY0IhMVow1YeZiDiMLuOOGL8aCTq8O7o0OtK/8YUEzsxMcZLk6TNgC2ruT WwzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yWmAHcgT2wDa3AHqlJ16t/WowuUKj+5oH128IS3to+s=; b=AFFAfITBQ4/LaGpygE/LZl6pHq0JNNuiznG5aXiJ4jf0ZFMPIRSzVBispGK/d3ujY4 jH9bsf6vKOaZl0VIW0sVmpz8s9a9znbIbY/NPeX5URuLHY0X/hbgXeREzBs4/WovPTTd jhoa7N6nLFcEP1jw4jyUOOu+a6V2ezeyU6oEWIwHcFfpH1ALYCKXzLn1tl8ewZRZ4q6J +CeXDVp+P+zefdaA51TavMMrgi0/NUFpSpCR43C8U4+Cwyo91irQIRYU2r9ZMwMXHUKa JoTaSuXDKGBqAu7lPBlRlcmOezKL66rCOUdxtgCAHqtGubDcvXiIaq+9XQwYyyM4JJ6I ITpQ== X-Gm-Message-State: AOAM53038+wiRxsxDfUxY/To+F4besBA+wsySvRctHDaLRsIwQj/Q4SE B1GhjJjwMJpA4ft1k2W81b6rig== X-Google-Smtp-Source: ABdhPJyN8ng2AKyfXE308SyYBOpK5+vw1l709E5yQIVxjKXFjVd61eroffH5kXqXdkXmnXUZ3JvTow== X-Received: by 2002:adf:9b8b:: with SMTP id d11mr19383508wrc.71.1600259054273; Wed, 16 Sep 2020 05:24:14 -0700 (PDT) Received: from google.com ([2a01:4b00:8523:2d03:e49d:f6be:d31b:ad3c]) by smtp.gmail.com with ESMTPSA id j26sm2567165wrc.79.2020.09.16.05.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 05:24:13 -0700 (PDT) Date: Wed, 16 Sep 2020 13:24:12 +0100 From: David Brazdil To: Will Deacon Subject: Re: [PATCH v2 00/10] Independent per-CPU data section for nVHE Message-ID: <20200916122412.elxfxbdygvmdgrj5@google.com> References: <20200903091712.46456-1-dbrazdil@google.com> <20200914174008.GA25238@willie-the-truck> <20200916115404.rhv4dkyjz35e4x25@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200916115404.rhv4dkyjz35e4x25@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_082415_824746_168F5428 X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Arnd Bergmann , Suzuki K Poulose , Marc Zyngier , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Tejun Heo , Dennis Zhou , Christoph Lameter , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > I was also wondering about another approach - using the PERCPU_SECTION macro > unchanged in the hyp linker script. It would lay out a single .data..percpu and > we would then prefix it with .hyp and the symbols with __kvm_nvhe_ as with > everything else. WDYT? Haven't tried that yet, could be a naive idea. Seems to work. Can't use PERCPU_SECTION directly because then we couldn't rename it in the same linker script, but if we just unwrap that one layer we can use PERCPU_INPUT. No global macro changes needed. Let me know what you think. ------8<------ diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S index 5904a4de9f40..9e6bf21268f1 100644 --- a/arch/arm64/kernel/vmlinux.lds.S +++ b/arch/arm64/kernel/vmlinux.lds.S @@ -195,11 +195,9 @@ SECTIONS PERCPU_SECTION(L1_CACHE_BYTES) /* KVM nVHE per-cpu section */ - #undef PERCPU_SECTION_NAME - #undef PERCPU_SYMBOL_NAME - #define PERCPU_SECTION_NAME(suffix) CONCAT3(.hyp, PERCPU_SECTION_BASE_NAME, suffix) - #define PERCPU_SYMBOL_NAME(name) __kvm_nvhe_ ## name - PERCPU_SECTION(L1_CACHE_BYTES) + . = ALIGN(PAGE_SIZE); + .hyp.data..percpu : { *(.hyp.data..percpu) } + . = ALIGN(PAGE_SIZE); .rela.dyn : ALIGN(8) { *(.rela .rela*) diff --git a/arch/arm64/kvm/hyp/nvhe/hyp.lds.S b/arch/arm64/kvm/hyp/nvhe/hyp.lds.S index 7d8c3fa004f4..1d8e4f7edc29 100644 --- a/arch/arm64/kvm/hyp/nvhe/hyp.lds.S +++ b/arch/arm64/kvm/hyp/nvhe/hyp.lds.S @@ -4,6 +4,10 @@ * Written by David Brazdil */ +#include +#include +#include + /* * Defines an ELF hyp section from input section @NAME and its subsections. */ @@ -11,9 +15,9 @@ SECTIONS { HYP_SECTION(.text) - HYP_SECTION(.data..percpu) - HYP_SECTION(.data..percpu..first) - HYP_SECTION(.data..percpu..page_aligned) - HYP_SECTION(.data..percpu..read_mostly) - HYP_SECTION(.data..percpu..shared_aligned) + + .hyp..data..percpu : { + __per_cpu_load = .; + PERCPU_INPUT(L1_CACHE_BYTES) + } } -----8<------ David _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel