From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C930C43461 for ; Wed, 16 Sep 2020 14:13:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E54420795 for ; Wed, 16 Sep 2020 14:13:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r+ZVh1yJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hAS45VSz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E54420795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jO+Qm1S3JnBxctsqXIIKZi2pi/lYnCB+Mjl0hbOy3C0=; b=r+ZVh1yJt0qG34lYfrOx9mwhI ZNZBbBKHPGqUGdGZ1Awt9ZGhR+070J0jKXOz2WHCDI+aT6M2NuYoiQiyEM1mtC0IYfWkvdFCPr5Ti VvnbRbWmskRNMgc+8F6dEuJg/nXiFZSALOUPx1sDr2rBTWe1AVyZw6obUDvSaq5bAVrciHdvpupEd 7kRCRuSLYceDjCYUhcRkOnl8v9EC4ba/jz0YZo/uN+p/IrGfSfN4XlMfi8ZIh7KJb00TKFBhQVMnu k3s0HRFXeK+JhpP+kzQH/57Bd1Qk9WQO5jk/yM3dV9vLPFWkxxf3lWsiL9ZLKE6pNklyDq2uQK34z 0S//cj8aA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIYA5-0002LE-3l; Wed, 16 Sep 2020 14:11:53 +0000 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIYA1-0002Js-W0 for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 14:11:50 +0000 Received: by mail-ed1-x542.google.com with SMTP id i1so6470132edv.2 for ; Wed, 16 Sep 2020 07:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LlUrkn99PMIYQmVGLdB0+eN+QkGnfm38LGdCqXub4Ao=; b=hAS45VSzPObmCMHNxGfkG+NDKM1TzVnv7KNEr8vj9xy4MrtNPbVMnP3E+c0FUzYGVO wPqjGd58SjTgvD4ElwGMVTkJ/vQJgVksPrNujXbUCvaSYAR+nYUFKIv9GmdPmsAeTw1w SLEokVTwh41c06RWTQK8ga+0WnZtxqNFStmhRekL0xLKWTqn8cVn6iVyLbEJCK4D+afx gIcqGW5V3Meio++Xlq1PULg8xgNkm9FJhgcaQPYCFJl1o7cQZmddSIXGNjtX54ocOxnB XkpAgcnLOKialpbNRhtfkofkZ/QjghU36lEKLA39h4h8TVkfr6on/E7w7xYxDBzj+JkY +i2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LlUrkn99PMIYQmVGLdB0+eN+QkGnfm38LGdCqXub4Ao=; b=tE6E+UatSibPJI4AFh8vnFP4UrUx25RNMqQuzb4+YbYKTNGOtUKT85otwO+R5g1swx 3+POdGntJeCzTjXFBMmnI8zWK35RYwEad/wG0FA1/dMnQxSN7gwZN4lL3FjZqQZ4UR/Y bbmNH4lrBwgRua6pQO4Ltq1IdvZoRCrg/zZoUHVKoIVs+6Hh62Ky9w0UthA8fLKR13yl GX9Kj5upoWZQfYVce7cDPevU66R5zKLp3XCuDS7yqCr/E4T3T3AI+1IEzUXktZN70TAv QJmliSnIMeRKVFUJxJYNYvvjZcbn9H+QnnwyDVkzk9EmZeK4JKPk6577eruyXKm8JIfa +OHg== X-Gm-Message-State: AOAM530pQXrr2P2CYJiGm10qZ9DQYLUrOpNU6UsnEuWpg3AKcwmd9qqk /3YRMvZuHp/1d808QSwwD7Avyw== X-Google-Smtp-Source: ABdhPJxCXAJVT89OOq1cTZqdGdXIDr/MyyoQoJRJeCQxhnHcd7r64qYaYdWt6ztGRzTK/qlOZ2O25Q== X-Received: by 2002:a05:6402:2c7:: with SMTP id b7mr28642771edx.125.1600265507151; Wed, 16 Sep 2020 07:11:47 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id y25sm13933983edv.15.2020.09.16.07.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 07:11:46 -0700 (PDT) Date: Wed, 16 Sep 2020 16:11:28 +0200 From: Jean-Philippe Brucker To: Zenghui Yu Subject: Re: [PATCH v7 18/24] iommu/arm-smmu-v3: Add support for Hardware Translation Table Update Message-ID: <20200916141128.GC5316@myrica> References: <20200519175502.2504091-1-jean-philippe@linaro.org> <20200519175502.2504091-19-jean-philippe@linaro.org> <472fdcf6-f306-60bc-5813-4ad421ee03f2@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <472fdcf6-f306-60bc-5813-4ad421ee03f2@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_101150_050547_E184854C X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, kevin.tian@intel.com, jacob.jun.pan@linux.intel.com, will@kernel.org, fenghua.yu@intel.com, jgg@ziepe.ca, linux-pci@vger.kernel.org, joro@8bytes.org, Jonathan.Cameron@huawei.com, christian.koenig@amd.com, hch@infradead.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, catalin.marinas@arm.com, zhangfei.gao@linaro.org, xuzaibo@huawei.com, robin.murphy@arm.com, felix.kuehling@amd.com, linux-arm-kernel@lists.infradead.org, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 28, 2020 at 05:28:22PM +0800, Zenghui Yu wrote: > On 2020/5/20 1:54, Jean-Philippe Brucker wrote: > > @@ -4454,6 +4470,12 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu) > > smmu->features |= ARM_SMMU_FEAT_E2H; > > } > > + if (reg & (IDR0_HA | IDR0_HD)) { > > + smmu->features |= ARM_SMMU_FEAT_HA; > > + if (reg & IDR0_HD) > > + smmu->features |= ARM_SMMU_FEAT_HD; > > + } > > + > > nitpick: > > As per the IORT spec (DEN0049D, 3.1.1.2 SMMUv3 node, Table 10), the > "HTTU Override" flag of the SMMUv3 node can override the value in > SMMU_IDR0.HTTU. You may want to check this bit before selecting the > {HA,HD} features and shout if there is a mismatch between firmware and > the SMMU implementation. Just like how ARM_SMMU_FEAT_COHERENCY is > selected. Thanks for pointing this out, I didn't know about these flags but have added them to the patch now. Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel