From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE6DC43461 for ; Wed, 16 Sep 2020 15:40:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8649222242 for ; Wed, 16 Sep 2020 15:39:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="abszEWyE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8649222242 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fH1pF3ZsqUQf8QQKvY2m/YWPUEGsxssJWIhlL6fGneA=; b=abszEWyEr/dJhiTBNkU71KaO4 J3NCjjP4DfEjHGdjA+RZKIuRRi8HMJzp8w2tgHmEtA8rKLu9B96zG12Wd++9sFO3Uq2JJcnUl9/cJ dclWt7aGoDa8IyaQiw0/b3C/D5M41mZFC4cb6rEofKuQ+gMo/eBJfOjsXhaS2bWHDwAYJcm53884V qnR0WEZou4yQ/MAnDl4Uq/ER1om0xkN7WNW5AsPV5Wfsy86VL7GYWufkCuFBoR9w3SI4cW6MjxKim JqonI85g+1SXt0SdMsss2Gy2iuG44Kufwzpzr3ZlOv6P5oI38AKHeeyZo+2wDn1idJvKPmrP74vC2 JmfKOM8jg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIZVr-00010J-Iw; Wed, 16 Sep 2020 15:38:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIZVn-0000zS-La for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 15:38:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E251214BF; Wed, 16 Sep 2020 08:38:15 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 91CA13F718; Wed, 16 Sep 2020 08:38:14 -0700 (PDT) Date: Wed, 16 Sep 2020 16:38:12 +0100 From: Dave Martin To: Boyan Karatotev Subject: Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys Message-ID: <20200916153809.GZ6642@arm.com> References: <20200828131606.7946-1-boyan.karatotev@arm.com> <20200828131606.7946-4-boyan.karatotev@arm.com> <20200902170052.GJ6642@arm.com> <70e207ea-f7c2-2c9d-e868-3ba3b6451c6f@arm.com> <20200907102717.GM6642@arm.com> <4f38a974-d5a0-87e6-3db3-647e3cc32c0e@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4f38a974-d5a0-87e6-3db3-647e3cc32c0e@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_113823_763363_0D0AEEDE X-CRM114-Status: GOOD ( 19.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shuah Khan , Catalin Marinas , Boyan Karatotev , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, amit.kachhap@arm.com, vincenzo.frascino@arm.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 04:18:28PM +0100, Boyan Karatotev wrote: > On 07/09/2020 11:27 am, Dave Martin wrote: > > On Thu, Sep 03, 2020 at 11:20:25AM +0100, Boyan Karatotev wrote: > >> On 02/09/2020 18:00, Dave Martin wrote: > >>> On Fri, Aug 28, 2020 at 02:16:05PM +0100, Boyan Karatotev wrote: > >>>> +int exec_sign_all(struct signatures *signed_vals, size_t val) > >>>> +{ > >>> > >>> Could popen(3) be used here? > >>> > >>> Fork-and-exec is notoriously fiddly, so it's preferable to use a library > >>> function to do it where applicable.I would love to, but the worker needs a bidirectional channel and popen > >> only gives a unidirectional stream. > > > > Ah, fair point. > > > > Would it help if you created an additional pipe before calling popen()? > > > > May not be worth it, though. For one thing, wiring that extra pipe to > > stdin or stdout in the child process would require some extra work... > Well, I probably could, but I doubt the result would be any better. I > agree that I'm not sure the effort is worth it and would rather keep it > the same. Sure, fair enough. Ideally kselftest would provide some common code for this sort of thing, but I guess that's a separate discussion. Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel