From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C68EC433E2 for ; Wed, 16 Sep 2020 17:24:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83C4E223E8 for ; Wed, 16 Sep 2020 17:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vrb4u2BY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="FA22T5GO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83C4E223E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4O4TPHAltHipL2J3vN/yf1IrVhKiiMXCvw9DYthJ16c=; b=Vrb4u2BYSDqtaIfZ+1floH20O mLvu6P6qKnXByZ9thvanpkZ7JXH4VueH4pjZKiYIbrf9I9sse7fLZg6f07iuM/VFmcFn+/qFf3bnF MQ2qM3lg1qeOGl7wa7jJAYWZK/fD7xtucgbaiHPfbzvJszzeoNu9prHVTXQfBrV7S2wwWp8o1gKRg IUjlVK9uSxsdka+0bHDgrisEIQxVbXljq12Zv/eeAf2wi4Fy2y+lmdOOmiJPtYsDC5SEZPj/v6vgE WWY8CtH188xj9uA5GtRy0FxbTgsIjCV4z8iWDtNnSYK51S5Frni2eXDGekUV5DhI55VOiPIKqeZ4h xHnvevZZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIb8m-00087H-Fj; Wed, 16 Sep 2020 17:22:44 +0000 Received: from mail.skyhub.de ([5.9.137.197]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIb8j-00086q-Oy for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 17:22:42 +0000 Received: from zn.tnic (p200300ec2f0c3e00db2f62bd592f04a0.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:3e00:db2f:62bd:592f:4a0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1522C1EC026F; Wed, 16 Sep 2020 19:22:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1600276960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=CXiDzhd51Y1X9PUqSzctKBUMynV+tiDkIpdtvyBec+o=; b=FA22T5GORdlesUNedODvDvgYmaDdj8PkbyqTIBGIJGmwPSV7OwXITkTe+/heqhPzL51mx/ pz9TN+9/aavENJg5AcMKLXQbd8fQkM/a7YpcMLiW6VU6TuZrjI1W39VNhvn1DoPE0GxQtm LTCrTJdKJtIOJzBUC8dhq1g4Pd1Q8lE= Date: Wed, 16 Sep 2020 19:22:38 +0200 From: Borislav Petkov To: Liu Shixin Subject: Re: [PATCH -next] EDAC/aspeed: use module_platform_driver to simplify the code Message-ID: <20200916172238.GQ2643@zn.tnic> References: <20200914065358.3726216-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200914065358.3726216-1-liushixin2@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_132241_929989_E0CF8A8C X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Luck , Robert Richter , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , linux-kernel@vger.kernel.org, James Morse , Joel Stanley , Stefan Schaeckeler , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 02:53:58PM +0800, Liu Shixin wrote: > module_platform_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Liu Shixin > --- > drivers/edac/aspeed_edac.c | 18 +----------------- > 1 file changed, 1 insertion(+), 17 deletions(-) > > diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c > index fbec28dc661d..fde809efc520 100644 > --- a/drivers/edac/aspeed_edac.c > +++ b/drivers/edac/aspeed_edac.c > @@ -388,23 +388,7 @@ static struct platform_driver aspeed_driver = { > .probe = aspeed_probe, > .remove = aspeed_remove > }; > - > - > -static int __init aspeed_init(void) > -{ > - return platform_driver_register(&aspeed_driver); > -} > - > - > -static void __exit aspeed_exit(void) > -{ > - platform_driver_unregister(&aspeed_driver); > -} > - > - > -module_init(aspeed_init); > -module_exit(aspeed_exit); > - > +module_platform_driver(aspeed_driver); > > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Stefan Schaeckeler "); > -- Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel