From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD5CC43461 for ; Thu, 17 Sep 2020 05:22:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64C5520872 for ; Thu, 17 Sep 2020 05:22:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T+CNO9gF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nUxgf4XQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64C5520872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i8Y2o543B3bPnEW7aCjEuJpV7PTI3yYGwJ4RbyCbsvE=; b=T+CNO9gFrSWztp/M0S0Bd8VcF 4Kz0c2uqFBccfjjTBYxhlPWD5/PCOo+Rc88H0aR21zVCNpZ/xqH10egFeduAzZO8Tezbj6pLIax3t ZpxAcrVvVpFt2ZmjHpttMNBHHpxMRDENPQGpbzCMpAHAfwhlhc0dYNLEIVlsmk3ul41fzZTRMHMut zN8ZdnMix5nDxIz9mL/LOcciaIh/5oxw03+DSFdReIWPN+eH4pQUD4FJVz1ZceaKEwQykISiKcVOh CNCEbF+2ZIe0eTTjpKJ9MytJtR0r8rfxbwh3QU8Y/A0xTMxtNn7WUaP2nXCICW4pFaBTl6Z9N5mk+ HwN7E8gng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kImKs-0006zK-33; Thu, 17 Sep 2020 05:19:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kImKo-0006yo-Vp for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 05:19:55 +0000 Received: from kernel.org (unknown [87.71.73.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38D71206C3; Thu, 17 Sep 2020 05:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600319993; bh=LQAOJ6T9kBFVpgSoZo/1UMJGmpXRbmDEcvqaS+t/aUA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nUxgf4XQ4VhQQj1qTiPIpZ1BdDJGpLUBLjLArIadmyhDC1bwCI2Ce5Gxnx7hr9i1c lu2MlZ7ectxebuu0hGymY6QkMWKm2qEetRgwyRF9vl/LUUy99tWTROSA7nbTl5XRFq ZR7Pae+Aa+MQekWUmReapezKvbgAXWXFXLv1Z36s= Date: Thu, 17 Sep 2020 08:19:45 +0300 From: Mike Rapoport To: Nick Desaulniers Subject: Re: [PATCH 00/12] ARM: use adr_l/ldr_l macros for PC-relative references Message-ID: <20200917051945.GM2142832@kernel.org> References: <20200914095706.3985-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_011955_115977_9D18759F X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: song.bao.hua@hisilicon.com, linux-efi , Anders Roxell , Nicolas Pitre , Marc Zyngier , Linus Walleij , Russell King , Stefan Agner , Peter Smith , clang-built-linux , Naresh Kamboju , Jian Cai , Will Deacon , Ard Biesheuvel , Linux ARM , Mike Kravetz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org (added Mike K.) On Wed, Sep 16, 2020 at 05:16:32PM -0700, Nick Desaulniers wrote: > On Wed, Sep 16, 2020 at 2:25 PM Nick Desaulniers > wrote: ... > Maybe this is: https://lore.kernel.org/linux-next/20200916140437.GL2142832@kernel.org/ > ? That looks arm64 specific though. Maybe 32b ARM needs the same or a > similar fix? Oh man, this boots, total shot in the dark: The CMA change is the problem IMO and it's now removed from -mm and -next trees. > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c > index 45f9d5ec2360..7118b98c1f5f 100644 > --- a/arch/arm/mm/init.c > +++ b/arch/arm/mm/init.c > @@ -226,9 +226,6 @@ void __init arm_memblock_init(const struct > machine_desc *mdesc) > early_init_fdt_reserve_self(); > early_init_fdt_scan_reserved_mem(); > > - /* reserve memory for DMA contiguous allocations */ > - dma_contiguous_reserve(arm_dma_limit); > - > arm_memblock_steal_permitted = false; > memblock_dump_all(); > } > @@ -248,6 +245,9 @@ void __init bootmem_init(void) > */ > sparse_init(); > > + /* reserve memory for DMA contiguous allocations */ > + dma_contiguous_reserve(arm_dma_limit); > + This might be too late for ARM because in paging_init() it calls dma_contiguous_remap() which presumes that the CMA area is already reserved. dma_contiguous_remap() might be NOP, so your fix will boot until it fails eventually :) > /* > * Now free the memory - free_area_init needs > * the sparse mem_map arrays initialized by sparse_init() -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel