From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787C1C43461 for ; Thu, 17 Sep 2020 13:10:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 143EF206E6 for ; Thu, 17 Sep 2020 13:10:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qVyeAX+2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lQsGBLbW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 143EF206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WgFV3xP80I6LyoSnnRuHgJxFmLZvPCCKlx8iV6lle/Q=; b=qVyeAX+2GiMUSeyEJ9gt/iuQ4 5dgC1a1o26SBMTMlN5Sp/frwfvHg66XI/B+Rae41wMvD7Du3u4uRi4CoRr03p3ZoROv4K9+tMwyWj IYVrNDc0aBB1snEcasSuZVc+gUuh4NPli1opge+aLFe+Y1f3nWeKZuSvA3ibEKkezjyPPvfKbW8AW Hq/g8hN04jULrRyM28Hkgl/PuOVEdfpaJCVuHG6YY1OuURGkPXhOq60juv2RGGPhM+kZhts1g1jno u8cyoBbpfLFUraNE/8Dlbo+lJos1YJd+9EMs7fyOfrTzdD4XIcA5RMsDHXVyzJVn3ljETliZRGvOA h3bkwLNQQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kItew-0000Vf-K3; Thu, 17 Sep 2020 13:09:10 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kItet-0000Uf-SD for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 13:09:09 +0000 Received: by mail-pl1-x635.google.com with SMTP id y6so1092203plt.9 for ; Thu, 17 Sep 2020 06:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EPhqMoh56IwlomezpV7bUA2GhqD4gsP45pnIJn8fDBI=; b=lQsGBLbWY2kcQ82vLfnmoL6IH/qgqIDrCnST3XhMd9AoMR6c4Tu8GVfOIB78QKb7Mu RbUWt9+7Z1FGMgTa5mYQRgUJvlj3VrYBkGNxqvivlB44pl4IudI9Xj6NfwNNZidP8rjZ crpRVDHQhPKXFS+tnztOJG1VqSUBRa5TwYQfk8qCuSPNiQ65KS3/kq9/oC40Ok13dKqF r6caHdl38SQtNi+JAb6EnGGzPRRzJb/9W6PPZ32BihQp2wvRdCGFtV9UHOQxkKXM23QG tvIfWM5PA0mmseUPRqKW7gi04v5u3AGM6mQyqo73JXEzupEbr1VfVAXDTKzOX67GI5Wn FgRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EPhqMoh56IwlomezpV7bUA2GhqD4gsP45pnIJn8fDBI=; b=Iwf4iSiPDd9amAZxjkMD8DlePQKWBsApr4iyxCAg0M9eORy1Dj9xjxe6HogaOE5ayZ Oe/1vnxflzdR5HN1WXBKzkCXaHwFdeCvzENfeTuWhWYixgCnNbgt59VHwGKBWzXzOtaN vHMHVm8vShtXgzLwZU4HcUw/gut9XquCqq7wvfvw8+2yOm9FEh71h24erXEC3d3dM/b4 qRrh72sIYURdQJ+7o46cxyNK7JWizrnbocvHAFvG1XTGhRxxXUrWOouicwBFv+P1v6eQ zN5mpnfgA5Pp4aepokK5tdzdSqKsr8Gy/eRnFVP9R4VEOQYL72H4qoR16M9v2TXRMAVW 44qw== X-Gm-Message-State: AOAM5306vn53fH4AfA2zDq4GtAhmfW7KReqTiOzLxqZXr4E49BZlLw5j ZY4xOz37/wHrDQOE3x+D+DqeTw== X-Google-Smtp-Source: ABdhPJz1RC10B1kD75VwpjKu21dK2v2wlK7bFQuvpp3GKVQEhlTeQXzpxApNlngVukQ2vbgjtt/6kQ== X-Received: by 2002:a17:902:a582:b029:d1:cbfc:608f with SMTP id az2-20020a170902a582b02900d1cbfc608fmr17372312plb.37.1600348145509; Thu, 17 Sep 2020 06:09:05 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([2600:3c01::f03c:91ff:fe8a:bb03]) by smtp.gmail.com with ESMTPSA id 187sm20845436pfx.174.2020.09.17.06.08.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Sep 2020 06:09:04 -0700 (PDT) Date: Thu, 17 Sep 2020 21:08:54 +0800 From: Leo Yan To: Sergey Senozhatsky Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64 Message-ID: <20200917130854.GG12548@leoy-ThinkPad-X240s> References: <20200917003645.689665-1-sergey.senozhatsky@gmail.com> <20200917100950.GC12548@leoy-ThinkPad-X240s> <20200917101219.GD12548@leoy-ThinkPad-X240s> <652f10660f09bd608b825233713f775a@kernel.org> <20200917110028.GB3049@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917110028.GB3049@jagdpanzerIV.localdomain> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_090908_186358_DE11BC73 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Mathieu Poirier , Peter Zijlstra , Marc Zyngier , John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Suleiman Souhlal , Namhyung Kim , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sergey, On Thu, Sep 17, 2020 at 08:00:28PM +0900, Sergey Senozhatsky wrote: > On (20/09/17 11:21), Marc Zyngier wrote: > > > > On Arm64, ftrace tracepoint "kvm_entry" doesn't contain the field "id" > > > > or field "vcpu_id", thus it always reads out the "id" is 0 and it is > > Right, Leo, I saw that. I put "id", because there is ... well, there is > nothing we can put there. The trace points on arm64, unlike on s390 or x86, > don't contain info which can let us map trace-event to vcpu_id (even > (void *)vcpu would have been rather helpful). > > > > > Essentially, this issue is caused by different archs using different > > > > format for ftrace event "kvm_entry", on x86 it contains feild > > > > "vcpu_id" but arm64 only just records "vcpu_pc". > > Exactly. I wish trace-points were less of pain-points. > > So 'perf kvm stat' on arm64 works, but it's not as feature rich as on other > platforms; at the same it's better than nothing, I suppose. Agree and I don't want to introduce complexity at here. So it's fine for me to merge your patch v4 firstly and later use a new patch set to support "vcpu_id". As you might have seen the discussion with Marc for new trace events with "vcpu_id", another way is to add new trace events with "vcpu_id" and then enable "perf kvm stat" based on new trace events. Either way is okay for me; except maintainers have different thinking for this. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel