From: Jonathan Cameron <jic23@kernel.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: gene_chen@richtek.com, devicetree@vger.kernel.org,
lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, cy_huang@richtek.com,
benjamin.chao@mediatek.com, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, pmeerw@pmeerw.net,
knaack.h@gmx.de, matthias.bgg@gmail.com, Wilma.Wu@mediatek.com,
linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com
Subject: Re: [PATCH v4 1/3] dt-bindings: iio: adc: add bindings doc for MT6360 ADC
Date: Thu, 17 Sep 2020 18:33:22 +0100 [thread overview]
Message-ID: <20200917183322.25fa2aea@archlinux> (raw)
In-Reply-To: <1600191369-28040-2-git-send-email-gene.chen.richtek@gmail.com>
On Wed, 16 Sep 2020 01:36:07 +0800
Gene Chen <gene.chen.richtek@gmail.com> wrote:
> From: Gene Chen <gene_chen@richtek.com>
>
> This change adds the binding doc for the MT6360 ADC.
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
Hi Gene
A few things inline I missed before. Ideally this wants
a device-tree ack which it isn't likely to get without
cc'ing the binding Maintainers. I've added Rob and the list.
Thanks,
Jonathan
> ---
> .../bindings/iio/adc/mediatek,mt6360.yaml | 32 ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml
> new file mode 100644
> index 0000000..2fa2fe7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/mediatek,mt6360.yaml#
I think this should probably match the compatible as should the file name.
(sorry missed this on previous review!)
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek MT6360 and similar ADCs
> +
> +maintainers:
> + - Gene Chen <gene_chen@richtek.com>
> +
> +description: |
> + Family of simple ADCs with i2c interface and internal references.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6360-adc
> +
> + "#io-channel-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - "#io-channel-cells"
As it's fresh in my mind from forgetting it myself, can we
add
additionalProperties: false
?
> +
> +examples:
> + - |
> + adc {
> + compatible = "mediatek,mt6360-adc";
> + #io-channel-cells = <1>;
> + };
> +...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-17 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 17:36 [PATCH v4 0/3] iio: adc: mt6360: Add ADC driver for MT6360 Gene Chen
2020-09-15 17:36 ` [PATCH v4 1/3] dt-bindings: iio: adc: add bindings doc for MT6360 ADC Gene Chen
2020-09-17 17:33 ` Jonathan Cameron [this message]
2020-09-15 17:36 ` [PATCH v4 2/3] Documentation: ABI: testing: mt6360: Add ADC sysfs guideline Gene Chen
2020-09-17 17:42 ` Jonathan Cameron
2020-09-18 7:21 ` Gene Chen
2020-09-18 8:03 ` Jonathan Cameron
2020-09-18 10:33 ` Gene Chen
2020-09-18 15:12 ` Jonathan Cameron
2020-09-15 17:36 ` [PATCH v4 3/3] iio: adc: mt6360: Add ADC driver for MT6360 Gene Chen
2020-09-17 17:53 ` Jonathan Cameron
2020-09-18 8:04 ` Gene Chen
2020-09-19 13:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917183322.25fa2aea@archlinux \
--to=jic23@kernel.org \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).