From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89524C433E2 for ; Thu, 17 Sep 2020 18:35:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28C3B206B6 for ; Thu, 17 Sep 2020 18:35:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NYCWudpj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28C3B206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jic23.retrosnub.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2ZQc6otMP2J4gQWu2DSdYuN82NVAgqkrZUPaYLXxGWY=; b=NYCWudpjR9MmTl95W1zjLeadx MES6dJq2o2zEIVw2uybyQZMkBNJxRXiDXHnl/UY3qa+t1DVpOtADUNSjWDTFCxy5pYhT9+zaUC7Nb 4hDdRSejlq1cnTSM9/+XLTvQLZpof691lZafKLOpGJIbcG+vX/yRJVdXNhy1yY+VgDDfs8gL1J05Q pdOISTfVQFfLaJdzW7wOrjUleO4/F6mR6cH7la3TXqstzvOgNzR8hLUhvk1KHvJyDYHIuYHo4efcj j+m7Pt/9/z+jeJgbMrwRkcGmjqf+TM0xjDzjkREaaqrj7vn5XTlpUowYISjty0wb4sf7w0ybWlyob 4dsgMV7RQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyjF-0005ZJ-Cr; Thu, 17 Sep 2020 18:33:57 +0000 Received: from saturn.retrosnub.co.uk ([2a00:1098:86::1:1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyjB-0005YL-NI for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 18:33:54 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 655929E023F; Thu, 17 Sep 2020 19:33:52 +0100 (BST) Date: Thu, 17 Sep 2020 19:33:51 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 05/30] iio: chemical: sgp30: Add description for sgp_read_cmd()'s 'duration_us' Message-ID: <20200917193351.6d640cb5@archlinux> In-Reply-To: <20200718153345.0a6a5720@archlinux> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-6-lee.jones@linaro.org> <20200718153345.0a6a5720@archlinux> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_143353_865229_5B4739CA X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Andreas Brauchli , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org, Pascal Sachs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 18 Jul 2020 15:33:45 +0100 Jonathan Cameron wrote: > On Thu, 16 Jul 2020 14:59:03 +0100 > Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/chemical/sgp30.c:236: warning: Function parameter or member 'duration_us' not described in 'sgp_read_cmd' > > > > Cc: Andreas Brauchli > > Cc: Pascal Sachs > > Signed-off-by: Lee Jones > > Perhaps we can do better on the wording. > > > --- > > drivers/iio/chemical/sgp30.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c > > index 403e8803471a9..82e407d48a0aa 100644 > > --- a/drivers/iio/chemical/sgp30.c > > +++ b/drivers/iio/chemical/sgp30.c > > @@ -227,6 +227,7 @@ static int sgp_verify_buffer(const struct sgp_data *data, > > * @cmd: SGP Command to issue > > * @buf: Raw data buffer to use > > * @word_count: Num words to read, excluding CRC bytes > > + * @duration_us: Time to sleep in microseconds > > Time taken to sensor to take a reading and data to be ready. > > Something like that maybe? I've not checked the datasheet but from > code that looks to be what this describes.. Tweaked and applied Thanks, Jonathan > > Jonathan > > > * > > * Return: 0 on success, negative error otherwise. > > */ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel