From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1FAC43464 for ; Fri, 18 Sep 2020 04:20:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57702206A2 for ; Fri, 18 Sep 2020 04:20:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EgEOfEjZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jmFM5Hk0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57702206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V+jHHDU7BtYUAiWp6wrcpN3A1iguLyUyF9i8nY/HrQM=; b=EgEOfEjZFi9vPPAAs1EFpFBKp kHpZJvsL98IQrsS6ujQX7/E5XaBQEx/nB/MixIIkha6FL2AwsCV0gTAA6Deo9f7QKMExF8sUyRWb4 qKUbU3gciIuGESFzQSLtJcGlf27gPTRWkyfMvHr0LK0OHvsQglwlrurXsGUP2L0/w7ViARBAgI+En FVMfWrGvQu6Wg1lxqDVp4HoVgoATJieRg5I1aFcVQ8laFqe/WNd0OdlRHII+j/9mTHecOS9yNvX47 ZfKal47K1V2/HlAAOXl8LFLvZXbHjPxLFhC3Oe058sFj90TsDoCf4qBZWCH9ll8kxbYA4V64XRGTD qPPusmbxg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ7rd-0006Dz-1h; Fri, 18 Sep 2020 04:19:13 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ7ra-0006DS-2C for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 04:19:10 +0000 Received: by mail-pl1-x644.google.com with SMTP id r19so2309372pls.1 for ; Thu, 17 Sep 2020 21:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uf0XaWxmSBWPs5Ykw52VMS2PajAcQCq1xNqnxZFMyic=; b=jmFM5Hk0uI1NV5zSmzm/rM5GMZnWpZNWRRVoGKaPVl9lvOS2eCjrtzS+6z8u19qAgd sDTmAtyKcKBy06InOtgbTb4X4PyMhqiMocmFrX0qvXPVrm1krkpyMVj2Rc099XEYRg8a 8tDLZ4PQsuimizomOQJRZ2C5l4UWsPY35hg3IB5pzLWkR+OXNmwx48yAtPQ1HJa3jURB QZJBfzF971iHAG1Y5/v1cd2O3WvfuUzK7qRBVCPlj0aJJpcyj8D7x8hJqdLHOtVy7Ns3 p2ksQWCSyqxpTv2Emz4KefLL+HH9ZIIr7refP2C/I9oBemQPvmiCj1yskQYAb27T6svY E6hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uf0XaWxmSBWPs5Ykw52VMS2PajAcQCq1xNqnxZFMyic=; b=g2BKDj8i5IfXFnfepimdL973OnpA2xSMrIRO/Srg8K6fXewd7PY/cshajtOV1h30k0 xZp0wiI7nU5uecKoc2ZUtoo83mI/6JbHnjU3MPIh291MXg06kA/uNXZfOHdn9CudvtqO VCJFEE0QKDQkfyPztethsEnwtZXGFGpIXwa/2OlE1nXJsGDcXGMmCeTSB8BftTlEXmGM htB6wXNG3SXaAYCrtuBL8nl/GYIFaUiZBkFqCZiErKi0UCVkWahmnXkcenh4bVi9cuYr qS/BgzmBCBXPgyVzkZAoQcWo7c2KJahQ3PaPjxq7JnrKULtGewk01cwdHGeqE788JolI vHpg== X-Gm-Message-State: AOAM530ifmnPCEYf8Aa+c/GOM5kq5jFA63eSW6cDCireN0tOsgern1DL f5dLSW8zAZlaEU+rymR0Ll4= X-Google-Smtp-Source: ABdhPJyTMd0Gg5Oqyr+rhgTmOWmBD6MN+kyK6wNEcYWw7fpphO5ZfvEVBe4QGl3Mhi+fBlLXTDQBqA== X-Received: by 2002:a17:902:c40c:b029:d1:9bc8:1624 with SMTP id k12-20020a170902c40cb02900d19bc81624mr30237552plk.1.1600402746335; Thu, 17 Sep 2020 21:19:06 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id c24sm1326854pfd.24.2020.09.17.21.19.05 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Sep 2020 21:19:05 -0700 (PDT) Date: Thu, 17 Sep 2020 21:18:59 -0700 From: Tao Ren To: Andrew Jeffery Subject: Re: [PATCH] gpio: aspeed: fix ast2600 bank properties Message-ID: <20200918041858.GA14246@taoren-ubuntu-R90MNF91> References: <20200916204216.9423-1-rentao.bupt@gmail.com> <60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <60f9f14a-c9be-45ac-b3a8-516ab73d9bee@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_001910_115315_9FBF1D9C X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, linux-gpio@vger.kernel.org, Tao Ren , Linus Walleij , linux-kernel@vger.kernel.org, Bartosz Golaszewski , Joel Stanley , openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2020 at 08:42:27AM +0930, Andrew Jeffery wrote: > > > On Thu, 17 Sep 2020, at 06:12, rentao.bupt@gmail.com wrote: > > From: Tao Ren > > > > GPIO_U is mapped to the least significant byte of input/output mask, and > > the byte in "output" mask should be 0 because GPIO_U is input only. All > > the other bits need to be 1 because GPIO_V/W/X support both input and > > output modes. > > > > Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the > > according bits need to be 1 because GPIO_Y/Z support both input and > > output modes. > > > > Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver") > > Signed-off-by: Tao Ren > > Thanks Tao, > > Reviewed-by: Andrew Jeffery Thanks Andrew for the quick review. Cheers, Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel