From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035E4C43463 for ; Fri, 18 Sep 2020 08:08:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A6AA2100A for ; Fri, 18 Sep 2020 08:08:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1gDd6d+R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="waJaW8Mt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A6AA2100A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cQyAgKWBx9vI97BOfAWqYvoEpNHICkZCPdlu17WsTv8=; b=1gDd6d+RsOWVe0tL56LuTTjo+ 5br28bM4JhiQKgKhC0HhBvNnGUHFntA9Kwk4rfw9XvHur71hXt2ymS8FyZOwxXud+QbeIDSYt5dRS 5o1PrOjuyT/9rp3skseIyqlO1VoygaX/yZqQF2O6aTzuztDtbDdAeal0LWK1TX2uvUpJh23B+Kxki xcGgQoHBjOvXYodEhfbY25YAU5hxre7eVjWW2sqDnP/IhNYJ2KHjNelGwW4ByudMbrMu6JqFXw4yL zqpDT430Dh37AkUq00kzg8BQvANPk2iFiJ1ayyecSc7kTLwrPaTB6zVbPnX6BOhskXywv6fI1dhG3 ZJ9MmqeGw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJBQA-0000He-Ut; Fri, 18 Sep 2020 08:07:06 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJBQ6-0000G5-NI for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 08:07:04 +0000 Received: by mail-wm1-x341.google.com with SMTP id y15so4587517wmi.0 for ; Fri, 18 Sep 2020 01:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tgDf+8aovxjwoFqw2pAtXyIqTcZuyQ4tZIemMpo6x5g=; b=waJaW8Mte9D9mu7wVneZdTaseFBahkj505vErBuQBlQdpJCv75cCAvwDEWNFUdX0yw vYzf5M/L1eh5a+L0kuixVIG7B/rrBkqi9HSe10xnQGCX0q2eVFVVU0cLlhyGWAdNMc7L dXQBDU/znPYpMoRmNtBz8CktfjhKqXMdmgeqAfrLx9i7wlrwgkd31B5QiSOjjLSBwkzV zilkLklpmyL1MOZuZ3hw6WhcgZy0qw5zi/nT35DeJM0MCuoa0y+0ztiQHZxanmwOVTJn g/EpZ23RO+2tZsx9k9JwZ/FAn9YMTUN5othT0vqOf8E1E+FnGLkaoOj6G3nkYHEg7THo vknw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tgDf+8aovxjwoFqw2pAtXyIqTcZuyQ4tZIemMpo6x5g=; b=Qkoc0EnbT8z0ByamkIuiGZyG5uTQco2EV7ieIzxE+nQZ1xVbj58aW3MW8xTmA7WTJ+ FUg4027OAZCRyavWsMKEe/r57cXE5y2WJkGd6J0/6BYzst8wuvVvZlzAuY1N21tVQsi+ hyPPDc3TDwp2FHylMwuz0Wvog443lUeP2kMEUsAarzd82Zng+6E6JoZlAb2TANe8uzG2 /O4KB9UljIDlBzY0Z2h1NBtZDwIySdq8YJJ+WAiMmjFWALQd+UJK7oDjAbMPo2FPU9Cl 2fcJrKerRegWaG1HI8B1mAS6Z+dRKhMlmUWSdSTPbu5EQD/QMYiJi9HVxaTPc15qa1wp mOzg== X-Gm-Message-State: AOAM5338kvjLQo9dGTRhCh2T1d1GkdkjQGh0KlG/Rbiv8om7Y06jQ5pZ mPZ/f5BgL34w6ubi2mUsu0562g== X-Google-Smtp-Source: ABdhPJzLuGCkjX50uDxEUgN+LexVakjf3B5xC2tQu09Z2pdTpH6+Pd24cnvL3XO8Yfc9PLw9FvZOnw== X-Received: by 2002:a7b:c4d9:: with SMTP id g25mr14060379wmk.15.1600416421193; Fri, 18 Sep 2020 01:07:01 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id r15sm3524860wmn.24.2020.09.18.01.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 01:07:00 -0700 (PDT) Date: Fri, 18 Sep 2020 10:06:58 +0200 From: LABBE Corentin To: Herbert Xu Subject: Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher Message-ID: <20200918080658.GA22656@Red> References: <1600367758-28589-1-git-send-email-clabbe@baylibre.com> <1600367758-28589-5-git-send-email-clabbe@baylibre.com> <20200918073128.GA24168@gondor.apana.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200918073128.GA24168@gondor.apana.org.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_040702_983252_510461BE X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, linux-crypto@vger.kernel.org, stable@vger.kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 18, 2020 at 05:31:28PM +1000, Herbert Xu wrote: > On Thu, Sep 17, 2020 at 06:35:55PM +0000, Corentin Labbe wrote: > > Ciphers produce invalid results on BE. > > Key and IV need to be written in LE. > > Furthermore, the non-optimized function is too complicated to convert, > > let's simply fallback on BE for the moment. > > > > Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator") > > Cc: > > Signed-off-by: Corentin Labbe > > --- > > .../crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 17 +++++++++++------ > > 1 file changed, 11 insertions(+), 6 deletions(-) > > Does the BE failure get caught by the selftest? > Yes, selftest found it. > If so please just leave it enabled so that it can be fixed properly. Not sure to leave it enabled is a good idea. A least, leaving it failing probably will not annoy any user (according to my readings of #linux-sunxi, nobody use BE). But I think only me will see it and since I already have this on my TODO list, I dont see any interest to leave it failing. Furthermore, having a clean BE boot will permit to enable BE boots for thoses SoCs on kernelCI. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel