From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A882EC43463 for ; Fri, 18 Sep 2020 12:43:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4467B21481 for ; Fri, 18 Sep 2020 12:43:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vAahSw/z"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="XJthRxMj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4467B21481 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7vb7woOtveAyr5WA3I2zSxI9UachTmLghpg9fQ5TAfI=; b=vAahSw/zNK+nKKkbgV+PGbT0H laBPcwr9aE0XFWSanSwa8fYtlYECU8XwnL+x9JgwNXOdPgxbrmVXlfDggU0WQiDUYgl9i3PwnIvJa Gu7d0tvh/fiLzuaEhAQUHyJdkT6X8TVYr6eVKBZbjiNyhUmlb6Xh2waPly2BXrVcWBX4JnKhosOF3 OKVz2ixtsRyzuLX9djP8+lB2WcH1ZcD1dRidp3tT8pqrpEz6AUhCp5AVO4yVqc9edqunMcC/fdw9b ePfidyYVpCvuCsFiL3LoQIDzs1mJ59ztYlxNrKSQPRJFXs4y2XxcfWFrPAQDIPazB93kChKwxv5NX UJMijhTjg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJFiO-0005OF-Nn; Fri, 18 Sep 2020 12:42:12 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJFiM-0005ME-0z for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 12:42:10 +0000 Received: by mail-wr1-x443.google.com with SMTP id k15so5468128wrn.10 for ; Fri, 18 Sep 2020 05:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=SOcYopzpVA91Ur8JOndAUuW5kC5KQpU+aqaU8ciX7/I=; b=XJthRxMj7p5FVQ8UB8QHPjpkyrZ1DYRAiW2zVjRAhJUW0e0QzTxX9S0LywyZSJEGAX oQ6rcMf41/DYJXO67/Xq8aoMk84qRFYHTNdeA/7L9sScQbt/SEfZaJSlI5KxMxxR+CIT M/6Aec09cMTtIOtfSD5s3TkOo40GHFODxElv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=SOcYopzpVA91Ur8JOndAUuW5kC5KQpU+aqaU8ciX7/I=; b=awOy6Y8p9FBUNh/G2JpE/aP55TmBABYKNqD1BTNQwySMSUTR7ybp33Eg9zngPk/52t OeBYn1CE6tSVx7nOjNb3fvu3jfS8OovWV13JamrWkPJUsYZoDKVg//+FZFxEO4Gdmx/C jrk+Y4YWpGfbwVL59PLTeLtuKEt3hTuNN2pv3fi982XXnegbv3wXVttJGMG+TV/fvVz/ k4Q4/YoRFKWg8tjADcI12a2pnljBN1HkBchFUP2uq7wK4dmX9zv6QYLjANfpJLf1Ocgm 4nnx81dm+4dC7fFxMp4ETetqPjXL1Eadn787L52m5BVJsMI3xDnDVD93AjclxNaBl/zN VHxQ== X-Gm-Message-State: AOAM530b/ixVPhaulzQWeQEML01wLa3RTC/OVT2G2S2e265rDq+tHcyO JWz5G20t3DktCIdTDeBGTdtjzA== X-Google-Smtp-Source: ABdhPJzrTC3CW6AB1dTSGBrjqUS3H6j44ck9bWQgvGGmKSFb26qrBxqU+OHgoRbREA252KDgVlNEww== X-Received: by 2002:a5d:4a49:: with SMTP id v9mr41100529wrs.153.1600432926218; Fri, 18 Sep 2020 05:42:06 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id d2sm5156057wro.34.2020.09.18.05.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 05:42:05 -0700 (PDT) Date: Fri, 18 Sep 2020 14:42:03 +0200 From: Daniel Vetter To: Vaibhav Gupta Subject: Re: [PATCH v1] fbdev: aty: remove CONFIG_PM container Message-ID: <20200918124203.GY438822@phenom.ffwll.local> Mail-Followup-To: Vaibhav Gupta , Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Bartlomiej Zolnierkiewicz , Sam Ravnborg , Paul Mackerras , Russell King , Andres Salomon , Antonino Daplas , linux-fbdev@vger.kernel.org, kernel test robot , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-geode@lists.infradead.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-arm-kernel@lists.infradead.org References: <20200917115313.725622-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917115313.725622-1-vaibhavgupta40@gmail.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_084210_073299_AF87B7FD X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, kernel test robot , Antonino Daplas , Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andres Salomon , Bjorn Helgaas , Paul Mackerras , Sam Ravnborg , linux-geode@lists.infradead.org, linux-kernel-mentees@lists.linuxfoundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2020 at 05:23:14PM +0530, Vaibhav Gupta wrote: > The changes made in below mentioned commit removed CONFIG_PM containers > from drivers/video/fbdev/aty/atyfb_base.c but not from > drivers/video/fbdev/aty/atyfb.h for respective callbacks. > > This resulted in error for implicit declaration for those callbacks. > > Fixes: 348b2956d5e6 ("fbdev: aty: use generic power management") > > Signed-off-by: Vaibhav Gupta > Reported-by: kernel test robot Applied, thanks. -Daniel > --- > drivers/video/fbdev/aty/atyfb.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/atyfb.h b/drivers/video/fbdev/aty/atyfb.h > index a7833bc98225..551372f9b9aa 100644 > --- a/drivers/video/fbdev/aty/atyfb.h > +++ b/drivers/video/fbdev/aty/atyfb.h > @@ -287,8 +287,8 @@ static inline void aty_st_8(int regindex, u8 val, const struct atyfb_par *par) > #endif > } > > -#if defined(CONFIG_PM) || defined(CONFIG_PMAC_BACKLIGHT) || \ > -defined (CONFIG_FB_ATY_GENERIC_LCD) || defined (CONFIG_FB_ATY_BACKLIGHT) > +#if defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) || \ > +defined (CONFIG_FB_ATY_BACKLIGHT) > extern void aty_st_lcd(int index, u32 val, const struct atyfb_par *par); > extern u32 aty_ld_lcd(int index, const struct atyfb_par *par); > #endif > -- > 2.28.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel