From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDAC5C43463 for ; Fri, 18 Sep 2020 13:39:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 670AF20795 for ; Fri, 18 Sep 2020 13:39:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zcavGZcI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eg5/i5Bl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 670AF20795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tVuYWDzsVbVcNc8s94oCBn+ACmdFq2hlZAenruIGwss=; b=zcavGZcIchrUEbPhsb4mgHRZA 0T+T25lQdgnEdW4et7H2lumzoYEYo/cXCkJBIXAqnPv+cGiePt2tGt5sZGtMW7d5LAZCqEImvmY/t ADBXnzjrql95Qw4bX+u22mnv6+NUFTovwXM1sWGd1bhDzcKmoVCMq7fJgJq3BKlwMvy3Yr2l6U8ob N+JMPzDuemwE4Rrkvkzjo6RcQKewwFZqWoHOk8fzoRic7zQPbGGs9CC4FjG18joXw6dXKLexbry2i AIRIfhouM8Tv87pghP8jGguBloCTjbw/8ZJHc8voc41OPsbZL3IUdL56QOkABg38iQg0xt95Hoesz 1cm9sn3sA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJGaQ-0004d8-To; Fri, 18 Sep 2020 13:38:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJGaP-0004cH-13 for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 13:38:01 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F6F320795; Fri, 18 Sep 2020 13:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600436280; bh=XngjAAUnERWNiIssoK32pkqFZKZzcZgEAB7yYNwM4jk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eg5/i5BlgYsAk25OvAKp3QMoPQhjz+4/oACfeovvBXJmr7hm/jjLHjhQ/jtVYGnUj iT6XA+jIhbgJFwsFRXwZM7xE2nLb3TFqfVKwqPpvpzzfIaufFCpua0ayj/L+KH40h/ 60p5RvmwTysQlLSVpEaQJfxfjWM7ZO8GE+C5Ua5s= Date: Fri, 18 Sep 2020 14:37:55 +0100 From: Will Deacon To: Marc Zyngier Subject: Re: [PATCH v2 0/2] KVM: arm64: Fix handling of S1PTW Message-ID: <20200918133755.GD31232@willie-the-truck> References: <20200915104218.1284701-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200915104218.1284701-1-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_093801_169095_DC389F39 X-CRM114-Status: GOOD ( 18.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 11:42:16AM +0100, Marc Zyngier wrote: > I recently managed to trigger an interesting failure mode, where a > guest would be stuck on an instruction abort due to a permission > fault. Interestingly enough, this IABT had S1PTW set in the ESR, > indicating that it was trying to *write* to the PT. We fix it by > adding the execute permission (it's an IABT, after all...), and going > nowhere fast. > > Note that it can only happen on a system that can perform automatic > updates of the page table flags. > > This small series fixes the issue by revamping the S1PTW handling in > the context of execution faults. The first patch fixes the bug, and is > definitely a stable candidate. The second patch is merely a cleanup, > which can wait. > > Tested on an A55-based board. > > * From v1: > - Rename kvm_vcpu_dabt_iss1tw() to kvm_vcpu_abt_iss1tw() > - Don't overload kvm_vcpu_trap_is_iabt() > - Introduce kvm_vcpu_trap_is_exec_fault() For both patches: Reviewed-by: Will Deacon Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel