From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8986BC43464 for ; Fri, 18 Sep 2020 14:45:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01FFA2078D for ; Fri, 18 Sep 2020 14:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m1kBDUtq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="XIp6kndV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01FFA2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Dxd+C/qpCzI+6oPAbxOIite91iplvwi2+46GKQlQXM=; b=m1kBDUtqPKO1mDMfn8g8Fyf7Q rmdVlry+p6QXKHDZZlUeL7HbYQ5G7pqBQDZPP/qmoqfT3dNmdHTEklcPtD7TB7aq5GU5RO11C6uAq PRbUoTg2ozNfwXkkhMeQtiETeMCcpcwNr9lNOYPToS862TffUrCVD9sbmy/rdMa51IiQw2xia9oNG YlBVpsM4tSKYpcx5WgwLr7b9qkzYIzPkqTP9P3RKV3pgT+TgfzKmqr5sIG4Iifbuvm1xdTOuU5cFQ KP3e0KuIXRRl1Ax0DUxkT3F0xgZO9FzrYYbe6liZt5SOmwSWHURU/XEODWqDTK31wSUzfoO8xotoc mCCatpqVA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJHcp-00057s-65; Fri, 18 Sep 2020 14:44:35 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJHcl-00057B-PH for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 14:44:32 +0000 Received: by mail-wm1-x344.google.com with SMTP id d4so5582771wmd.5 for ; Fri, 18 Sep 2020 07:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6NiKzp3GYnVNlrj1nKLgBBFJ1a03bOSILhGt3u/+Pok=; b=XIp6kndVEG2N2+RGvk2CLTkKWfRU+U5aAp7NUBTHXY8UWtgpV3qgnO6RIrKMJP2gtz zirQylm1yKbgnZxlriyNfUVIaDLWf4G84eDl5CnQNKUWfoRInb8kZRK9KDBDK2khyC6j QEQ1CtSCDRHUIXTobBj4jhMHt6V8yVSBE8UcDUqWlt1em7Ef90dKhlzHeN1No1G4zCBl NeM9HvHya5j56QPjDMQhy6xDxEmDoAxKDxIbds8HUqMCsfdg5TZgEpm9xikP/ip6Z32a r+FXgb8s4aCv3lU3KmOPVPxLv4cZXqc05XtlByqTDPNAUqIQrmG6wp2rERCitlLOsLJV kqsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6NiKzp3GYnVNlrj1nKLgBBFJ1a03bOSILhGt3u/+Pok=; b=QcIWpZZMrwX2+5XORd4b2NlJsXrWwzgnz9xFFoOAyMwGI2OLGWG/l5P1kd9wgLwn6G ySoMYlFy626h+uR5BPp8J+nnUdol0NqOxjnnJH19oLslEQO3Btt13j5zyl6pVV6CsSFu 1wG8hvVkaE2TabJGLWCQMppOxIUg6P6hQZIs6eyvcYB6Vbx1mPLwSXmbyJZ0VgCvpFqQ TN7Y7I4YzRfIdepBJw3IigyIDZ56gZQ0btMCkLte78goaYEKwldotuJUiIczSsQskMfg 0Kmd1e8F2RFU4sFI5Tjd26CbICyOpY3y5dwcv9hOV+MMzHexGOnMbWZx0f5lsH5uv7SN o2fw== X-Gm-Message-State: AOAM530rF6ff38CimDJdr5489qakSH1lotnFVpWb9yWrc4549TYUiJcu aZ+OvUOIF2lxLJsm0a4PEdyHXw== X-Google-Smtp-Source: ABdhPJyFC4mR1SfiLdJTxPUvBtO9C0cNuL9WhIwJnbYCiO8CdCCbWcOJrWJ1D+arshhoBuJ5gPciJQ== X-Received: by 2002:a1c:a953:: with SMTP id s80mr15793418wme.70.1600440270291; Fri, 18 Sep 2020 07:44:30 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id s17sm5860736wrr.40.2020.09.18.07.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 07:44:29 -0700 (PDT) Date: Fri, 18 Sep 2020 16:44:23 +0200 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata Message-ID: <20200918144423.GF2384246@elver.google.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.4 (2020-06-18) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_104431_877735_F89CCD67 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Elena Petrova , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote: [...] > static void set_track(struct kmem_cache *s, void *object, > @@ -583,7 +585,8 @@ static void set_track(struct kmem_cache *s, void *object, > unsigned int nr_entries; > > metadata_access_enable(); > - nr_entries = stack_trace_save(p->addrs, TRACK_ADDRS_COUNT, 3); > + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > + TRACK_ADDRS_COUNT, 3); Suggested edit (below 100 cols): - nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), - TRACK_ADDRS_COUNT, 3); + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), TRACK_ADDRS_COUNT, 3); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel