From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE0AC43464 for ; Sat, 19 Sep 2020 08:23:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 875FD21481 for ; Sat, 19 Sep 2020 08:23:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ox8yFKHH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="M3ACm5mA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 875FD21481 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W6HKBOffwoarm6Xv1FX1Htgij1FQZHjpN32m5GYCQLc=; b=Ox8yFKHHoSY7fVOXDZOPzUzAm +nfWmfTr/QuYRl5kCOUwv+VKb7jSi7VYzNZj+Fk5JcjTDHTAHiiK0VHku87VafeAS09Zuu/Lbd2NL 6D6I1UcBSQWUOV+eZ+DXCwYjTqBe5pV/9yH7T5mx5wqggV2Sc5sif5b+L9c3DzPLpw3aOzlgCc70z x16cF/zFRI8T3f2dfMcoZa9FbGbiiaoFxwBVO72OnF9nJqDT2vLb9pa+y/BO6l7Ff/lr5zRxNFGNm HKQ5mRieCVjoCyfYM/F3Bc90nQQ933Mg4R0XqzACBXTHGBy4KeVBYCy5isCSiZyaXyW4J1yJopDEd hh5fKOswA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJY8Q-0008E3-EH; Sat, 19 Sep 2020 08:22:18 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJY8N-00086E-ND for linux-arm-kernel@lists.infradead.org; Sat, 19 Sep 2020 08:22:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IJuNd4Gv09RCWUtcMRiqY/ZG9/GwVj+dhX5p2aRdauU=; b=M3ACm5mAdf7GFn88uis+FydnL bEkrNBoGv79Y3vmqo9+VcsFQzoolHZEHKtd1fBbiM1R9sgRo5eub6AZ+Ap//OXgWSm9yi563pd3OC t2+lOQVlhelmGHK5xdoaRENeAZdHiHvPZIGo++k61VxtxBTOB/vRcYppcL0sUW+qjmkjRoZ2x0uL+ 2b4FiXSz+AaqUIw9UrV3gMoH00CaCqQFgQLumeWrIXm+BP06dOve4pEH9BaThoAs1KYYeGGMgnPut bn21/hSfFlhzcG9DJHQP8sPChJRdGuU/ROf5pu1iXpsx1WmCgPH9Y5+rM/B4e4WVLrxS/WSOMeoPG Hn6wtjFzw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35542) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJY5N-0008EB-3k; Sat, 19 Sep 2020 09:19:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kJY5K-0007c5-E9; Sat, 19 Sep 2020 09:19:06 +0100 Date: Sat, 19 Sep 2020 09:19:06 +0100 From: Russell King - ARM Linux admin To: Arnd Bergmann Subject: Re: [PATCH v2 0/9] ARM: remove set_fs callers and implementation Message-ID: <20200919081906.GV1551@shell.armlinux.org.uk> References: <20200918124624.1469673-1-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200918124624.1469673-1-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200919_042215_763384_EA648118 X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org, Alexander Viro , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 18, 2020 at 02:46:15PM +0200, Arnd Bergmann wrote: > Hi Christoph, Russell, > > Here is an updated series for removing set_fs() from arch/arm, > based on the previous feedback. > > I have tested the oabi-compat changes using the LTP tests for the three > modified syscalls using an Armv7 kernel and a Debian 5 OABI user space, > and I have lightly tested the get_kernel_nofault infrastructure by > loading the test_lockup.ko module after setting CONFIG_DEBUG_SPINLOCK. I'm not too keen on always saving the syscall number, but for the gain of getting rid of set_fs() I think it's worth it. However... I think there are some things to check - what value do you end up with as the first number in /proc/self/syscall when you do: strace cat /proc/self/syscall ? It should be 3, not 0x900003. I suspect you're getting the latter with these changes. IIRC, task_thread_info(task)->syscall needs to be the value _without_ the offset, otherwise tracing will break. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel