From: LABBE Corentin <clabbe@baylibre.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: arnd@arndb.de, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org,
linux-crypto@vger.kernel.org, stable@vger.kernel.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher
Date: Sat, 19 Sep 2020 21:05:08 +0200 [thread overview]
Message-ID: <20200919190508.GA15359@Red> (raw)
In-Reply-To: <20200918080915.GA24549@gondor.apana.org.au>
On Fri, Sep 18, 2020 at 06:09:15PM +1000, Herbert Xu wrote:
> On Fri, Sep 18, 2020 at 10:06:58AM +0200, LABBE Corentin wrote:
> >
> > But I think only me will see it and since I already have this on my TODO list, I dont see any interest to leave it failing.
> > Furthermore, having a clean BE boot will permit to enable BE boots for thoses SoCs on kernelCI.
>
> I'll happily accept patches that fix the actual bug but not ones
> just papering over it.
>
I am sorry, you are right.
Furthermore, while respining to fix it, it seems that the current fix is enough.
I have rerun a clean rebuild and test on A10/A13/A20/A33 with BE and sun4i-ss is working fine.
I will sent a clean v2.
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-19 19:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:35 [PATCH 0/7] crypto: sun4i-ss: prevent always fallback for ciphers Corentin Labbe
2020-09-17 18:35 ` [PATCH 1/7] crypto: sun4i-ss: linearize buffers content must be kept Corentin Labbe
2020-09-17 18:35 ` [PATCH 2/7] crypto: sun4i-ss: checking sg length is not sufficient Corentin Labbe
2020-09-21 12:54 ` Sasha Levin
2020-09-17 18:35 ` [PATCH 3/7] crypto: sun4i-ss: IV register does not work on A10 and A13 Corentin Labbe
2020-09-17 18:35 ` [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher Corentin Labbe
2020-09-18 7:31 ` Herbert Xu
2020-09-18 8:06 ` LABBE Corentin
2020-09-18 8:09 ` Herbert Xu
2020-09-19 19:05 ` LABBE Corentin [this message]
2020-09-17 18:35 ` [PATCH 5/7] crypto: sun4i-ss: initialize need_fallback Corentin Labbe
2020-09-17 18:35 ` [PATCH 6/7] crypto: sun4i-ss: enabled stats via debugfs Corentin Labbe
2020-09-17 18:35 ` [PATCH 7/7] crypto: sun4i-ss: add SPDX header and remove blank lines Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919190508.GA15359@Red \
--to=clabbe@baylibre.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).