From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8603C43463 for ; Mon, 21 Sep 2020 11:28:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54BAD207BC for ; Mon, 21 Sep 2020 11:28:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cx1jn+w5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54BAD207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pPS10UZltwtsvrhMEXxkCIqoHv+yqq/V/REWCKMX8RE=; b=cx1jn+w5RB6l0hTRjrZp7M3rL EzQIRUlZw76oRSgOzmkJg0OGBeLEqY91tv5Pr1aWk6slz4pceBHah/WvMTsW7PCUM/Vtq9r+vpRsQ qUVoDbd34DxZAZtwd6Lj7z/gesLku+e0J+Poft2YfO+uxnA56suOhZZMbZ1krzJwsBPP0p5LSiY++ 5yN7NTYsTNOOn+q/9LV8Ez/x6wKF+0SkdFYV3QlVVhx3FpZxPQKG5gDjWnwtL5R/aUdoXyOpUBVS6 MTzke68QiVdRAwaO5WCzLC2EpuMw/eRVQYrgtaYPI0+f6Jl6aZ8QhyyftzBJ2gsqr09vBF6UjJU6E 4qkddkdIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKJyX-0004AL-V7; Mon, 21 Sep 2020 11:27:18 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKJyU-00049C-Uc for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 11:27:15 +0000 Received: by mail-ej1-f68.google.com with SMTP id z23so17101507ejr.13 for ; Mon, 21 Sep 2020 04:27:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TklpADd3IHxb6z2of1IfW1yIIhmPXuPXH+f9NSI1fhs=; b=Lw9UiVI90yjyoCY4uFNUGnCiBAOpo0phpRMtF+v1WGIJWfyBQ1krWe64Izs+NroTX8 N5qW4Jhl5o2Powf6VM9jPW6e7RPTdDJ0k8FoBunrt8aS5xO+HZ+SmnBlCjvj8sYCmzX1 PUg5J052FiqdOlEZnU8mn163zLnSUK9RhIAQPWEm8OYlpWbklRZwAi2ia1A3vC96GxCe XrD7Bukhn9iPOLBGVriKG99ger2CMcdq3oRPQFg3vZf/mPrLiG6PMfVSTwi3oBZpNvM2 XMl7TEhIYs1oZWNKvZKev1npkfu55yXH8nqPXCSkj/mD6QE9n/FH2BH75wmpdm2olnIB Yfug== X-Gm-Message-State: AOAM531rpMflHZqCmgyUtoYdJhlI2NKnnbC1sVK5IC5R9o9BE+vkfqaH vVi5O0pasmixWMfWfWhbfQxb/ChPJNQ= X-Google-Smtp-Source: ABdhPJwD2dkaD3vci3J10BEc2dBbE2JojebgK4ZMrXwRGuPek2cZCWlF8pueaGRM3ASW48A72otQnQ== X-Received: by 2002:a17:906:f9d8:: with SMTP id lj24mr50631653ejb.379.1600687633079; Mon, 21 Sep 2020 04:27:13 -0700 (PDT) Received: from kozik-lap ([194.230.155.191]) by smtp.googlemail.com with ESMTPSA id cf7sm8470136edb.78.2020.09.21.04.26.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Sep 2020 04:27:12 -0700 (PDT) Date: Mon, 21 Sep 2020 13:26:35 +0200 From: Krzysztof Kozlowski To: Rob Herring Subject: Re: [PATCH v2 1/3] dt-bindings: media: imx258: Add bindings for IMX258 sensor Message-ID: <20200921112635.GA1233@kozik-lap> References: <1599031090-21608-1-git-send-email-krzk@kernel.org> <20200914201310.GA154873@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200914201310.GA154873@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_072715_009309_68FF1BDC X-CRM114-Status: GOOD ( 27.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sakari Ailus , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 02:13:10PM -0600, Rob Herring wrote: > On Wed, Sep 02, 2020 at 09:18:08AM +0200, Krzysztof Kozlowski wrote: > > Add bindings for the IMX258 camera sensor. The bindings, just like the > > driver, are quite limited, e.g. do not support regulator supplies. > > Bindings should be complete, not what a driver happens to currently > support. I'll add then more complete picture. > > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v1: > > 1. None > > --- > > .../devicetree/bindings/media/i2c/imx258.yaml | 92 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 93 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx258.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > > new file mode 100644 > > index 000000000000..ef789ad31143 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/imx258.yaml > > @@ -0,0 +1,92 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + > > +description: |- > > + IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel > > + type stacked image sensor with a square pixel array of size 4208 x 3120. It > > + is programmable through I2C interface. Image data is sent through MIPI > > + CSI-2. > > + > > +properties: > > + compatible: > > + const: sony,imx258 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-frequency: > > + description: Frequency of input clock if clock is not provided > > + deprecated: true > > Why are we adding something deprecated on a new binding? My intention was also to document it but indeed easier to skip it. > > > + const: 19200000 > > + > > + reg: > > + maxItems: 1 > > + > > + # See ../video-interfaces.txt for more details > > + port: > > + type: object > > + properties: > > + endpoint: > > + type: object > > + properties: > > + data-lanes: > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > If this is the only config, why does it need to be in DT? The sensor is capable of two settings: two lanes (1 and 2) and four lanes described above. However Linux driver requires the latter (four lanes, 1+2+3+4). If I were to describe the bindings for HW, someone would really be confused and try to use two lanes setup, which won't work. Driver won't allow it. I understand that bindings document the HW and describe its interface but do we really want to put "theoretical" bindings which cannot be used in practice with Linux kernel? If yes, how to nicely document this that only one setting is currently working? > > > + > > + link-frequencies: > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint64-array > > + description: > > + Allowed data bus frequencies. > > + > > + required: > > + - data-lanes > > + - link-frequencies > > + > > +required: > > + - compatible > > + - reg > > + - port > > + > > + > > +if: > > + not: > > + required: > > + - clocks > > +then: > > + required: > > + - clock-frequency > > + > > +unevaluatedProperties: false > > additionalProperties Right. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel