From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3917DC43463 for ; Mon, 21 Sep 2020 12:04:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA45921789 for ; Mon, 21 Sep 2020 12:04:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WcBvR7Fv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA45921789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7dqyB4OzsfwDVoRbF6VXy1ma/htaogi8tN2r2AOLEeM=; b=WcBvR7FvKbIhM2ZpFXQSjt3RR j5RRhH2EglMuakPp5RwdkFg3uoOoRaEyVLJswTe9THT8Px1E+cQPgP/EVNEVzqHJPLrc4x4nOy0oL H59roMF9g98n4UIuKIXJ/XaBI+6EOYzSJ2KZ6A06BbeJdVkwO2xF49LbeDQ3dhe6wRidO3Mz4hVdZ /Eu/LX5hCYCnCdfbjxrMAl90UZLxGW97BzCq9h4VweCwAeK3oQKkjZ0G0DSrWQ4CJLUj6+QEGp3Ed ZFSO/JVnxgFXId7p31ItBkLzJbDFWHZ61jqk2YSEblMaKKs4tRAGvHUsnCiifG4e8AdYtZdgmDD+W hNG4DopZQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKKWn-0004V8-Vx; Mon, 21 Sep 2020 12:02:42 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKKWl-0004Tz-H4 for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 12:02:40 +0000 Received: by mail-ed1-f65.google.com with SMTP id c8so12495769edv.5 for ; Mon, 21 Sep 2020 05:02:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ooMeOqFsTMGGMTe6eBLr2JMOUkuXwIh/FFAOaUcM2v0=; b=MJYbrElTw3hypcEZVa1ccIDAuxIvtdNSKDINaz0YL56iIp90u34Au+yZDG+c7HRr+f KIU4PjkdPYZfCDUMhjie8EbgHMaQXLyfsH4VHcYwfF4dPogLzPJP6Hq7uQRdgcYoreSx rmnc85uDRK2ZElCtPd6sM8wM7cOFZnlZDK2UFb/yd8wvVdfhT38kD/1TmZigmkfwnqcw ptLPhvo6yMAVsmcodYMMay2NI2pfsni3kTXXNyd7dDil6gTDkhDLV02MiNHeQ0o80fuF I90rPIbRe5w3g1P5NvOSx5z9FHPE/RPBVkuqk+AXbJVbUcyFJnQgr6a8YRm9xi5bm1+s i0Ug== X-Gm-Message-State: AOAM532Llm6diHp8phD0tT7vj2Q7NtDsdR3q6g5KmMAs82sGNpef4NuJ bgfekuspRD5rJMZq8rtdRrHP3w/LSDk= X-Google-Smtp-Source: ABdhPJxt7v8AvSUBkvJ6qkwYaOh3b7yjN1eWTtOk3ANPGVwOskaBIoo2jvk2Zg9Tvz2Dpnkz6P6KoA== X-Received: by 2002:aa7:d4d2:: with SMTP id t18mr50829445edr.55.1600689757765; Mon, 21 Sep 2020 05:02:37 -0700 (PDT) Received: from kozik-lap ([194.230.155.191]) by smtp.googlemail.com with ESMTPSA id c8sm8771235ejp.30.2020.09.21.05.02.36 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Sep 2020 05:02:36 -0700 (PDT) Date: Mon, 21 Sep 2020 14:02:34 +0200 From: Krzysztof Kozlowski To: Sakari Ailus Subject: Re: [PATCH v2 3/3] media: imx258: Get clock from device properties and enable it via runtime PM Message-ID: <20200921120234.GB1233@kozik-lap> References: <1599031090-21608-1-git-send-email-krzk@kernel.org> <1599031090-21608-3-git-send-email-krzk@kernel.org> <20200902073935.GD32646@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200902073935.GD32646@paasikivi.fi.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_080239_579980_D8E88658 X-CRM114-Status: GOOD ( 33.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 02, 2020 at 10:39:35AM +0300, Sakari Ailus wrote: > Hi Krzysztof, > > Thanks for the update. > > On Wed, Sep 02, 2020 at 09:18:10AM +0200, Krzysztof Kozlowski wrote: > > The IMX258 sensor driver checked in device properties for a > > clock-frequency property which actually does not mean that the clock is > > really running such frequency or is it even enabled. > > > > Get the provided clock and check it frequency. If none is provided, > > fall back to old property. > > > > Enable the clock when accessing the IMX258 registers and when streaming > > starts with runtime PM. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v1: > > 1. Use runtime PM for clock toggling > > --- > > drivers/media/i2c/imx258.c | 68 ++++++++++++++++++++++++++++++++++++++++------ > > 1 file changed, 59 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c > > index c20bac9b00ec..ee38dafb8450 100644 > > --- a/drivers/media/i2c/imx258.c > > +++ b/drivers/media/i2c/imx258.c > > @@ -2,6 +2,7 @@ > > // Copyright (C) 2018 Intel Corporation > > > > #include > > +#include > > #include > > #include > > #include > > @@ -68,6 +69,9 @@ > > #define REG_CONFIG_MIRROR_FLIP 0x03 > > #define REG_CONFIG_FLIP_TEST_PATTERN 0x02 > > > > +/* Input clock frequency in Hz */ > > +#define IMX258_INPUT_CLOCK_FREQ 19200000 > > + > > struct imx258_reg { > > u16 address; > > u8 val; > > @@ -610,6 +614,8 @@ struct imx258 { > > > > /* Streaming on/off */ > > bool streaming; > > + > > + struct clk *clk; > > }; > > > > static inline struct imx258 *to_imx258(struct v4l2_subdev *_sd) > > @@ -972,6 +978,27 @@ static int imx258_stop_streaming(struct imx258 *imx258) > > return 0; > > } > > > > +static int imx258_power_on(struct device *dev) > > +{ > > + struct imx258 *imx258 = dev_get_drvdata(dev); > > + int ret; > > + > > + ret = clk_prepare_enable(imx258->clk); > > + if (ret) > > + dev_err(dev, "failed to enable clock\n"); > > + > > + return ret; > > +} > > + > > +static int imx258_power_off(struct device *dev) > > +{ > > + struct imx258 *imx258 = dev_get_drvdata(dev); > > + > > + clk_disable_unprepare(imx258->clk); > > + > > + return 0; > > +} > > + > > static int imx258_set_stream(struct v4l2_subdev *sd, int enable) > > { > > struct imx258 *imx258 = to_imx258(sd); > > @@ -1201,9 +1228,27 @@ static int imx258_probe(struct i2c_client *client) > > int ret; > > u32 val = 0; > > > > - device_property_read_u32(&client->dev, "clock-frequency", &val); > > - if (val != 19200000) > > - return -EINVAL; > > + imx258 = devm_kzalloc(&client->dev, sizeof(*imx258), GFP_KERNEL); > > + if (!imx258) > > + return -ENOMEM; > > + > > + dev_set_drvdata(&client->dev, imx258); > > This you cannot do --- it'll be overwritten by v4l2_i2c_subdev_init(). Right, thanks. > > > + > > + imx258->clk = devm_clk_get_optional(&client->dev, NULL); > > + if (!imx258->clk) { > > You can move declaration of val here (I think). No, the val is used later in further device_property_read* calls. > > > + dev_info(&client->dev, "no clock provided, using clock-frequency property\n"); > > As this is showing up on all ACPI based systems, I guess dev_dbg() would be > more appropriate. Sure, I'll make it debug. > > Please also wrap lines over 80 if they reasonably can be. OK Thanks for the review. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel