From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56D86C43463 for ; Mon, 21 Sep 2020 13:10:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E72B221789 for ; Mon, 21 Sep 2020 13:10:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iBXv5OBQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NcTJTpiL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E72B221789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8TjNjdOwWwb4E643xF1+0gvR122BBSp1+sfqoRUkPvI=; b=iBXv5OBQcVkx5s+8dIApaZzEN v4UznFG4k2F9Z19oQEFc9XTTOiNQH1VRD2jDahdEqjK7y9R/4YSLekJZVdYNBrJMSFKD8MLDgSmJo KmQifMvI7WRQwKaLYoqZ1ave4uK6YaMhvRTIN2EfFinrPYOm2tfASQ12ygV/ODZGB1OwcUi1gdvni WRHFGYb0yOBdagtykzLaQUkeEabVq+u5ti4wMVR2nrsfSFBGG1tnrvgPr85FjM5jfdiupPdZWZt49 q/V/2AXC89/XiN7zKEiqMSO06UrDRF8o+/Zx8F4VfzButNC5tdNID2INuHTeR9i0JLTirw4YDoDiV 57omytn9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKLYd-0004Ho-KD; Mon, 21 Sep 2020 13:08:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKLYa-0004Gy-Vb for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 13:08:37 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C57E21789; Mon, 21 Sep 2020 13:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600693716; bh=tg4FQI0IvC0cxgrmVdpK5HzAN0j6gpdZVFKiMBfm8jU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NcTJTpiLfeDnJfLcRy999SohDdAJkQ6LFJqwDV4YmfiV89CkR1sWuW2q+8vmtxAS+ YiR6+FCkOa8m3rCqGj8CVgwJmL+p1Ez4f8uhNGaigLr9tkGNjGJ0N9VBPTcFMLQDyk CzECMoiVKyyse8Wx7LkNrT8nO5nF/P0IX+pCJ6gI= Date: Mon, 21 Sep 2020 14:08:31 +0100 From: Will Deacon To: Mark Brown Subject: Re: [PATCH v4 0/8] arm64/sve: First steps towards optimizing syscalls Message-ID: <20200921130829.GI2139@willie-the-truck> References: <20200828181155.17745-1-broonie@kernel.org> <20200921124212.GH2139@willie-the-truck> <20200921125628.GB4792@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200921125628.GB4792@sirena.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_090837_181067_0892F5A7 X-CRM114-Status: GOOD ( 25.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Catalin Marinas , Zhang Lei , Julien Grall , Dave Martin , linux-arm-kernel@lists.infradead.org, Daniel Kiss Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 21, 2020 at 01:56:28PM +0100, Mark Brown wrote: > On Mon, Sep 21, 2020 at 01:42:13PM +0100, Will Deacon wrote: > > > Having three flags to track the fp state and then a bunch of WARN()s > > checking for invalid combinations is quite brittle, so any documentation > > that can help to justify this would certainly be useful! > > > I've left a couple of comments on some of the patches, but it looks like > > Dave was reviewing them but stopped short of the meat and potatoes in the > > last two patches. I'd like to see his Ack on those before picking them up, > > as well as testing from somebody with hardware because this is _very_ > > subtle stuff. > > Right. The previous version was tested on hardware but I dropped the > Tested-by since I felt there were more changes than I was comfortable > with. I have to say that a bunch of the things you've flagged up were > things that were requested on previous rounds of review. If you have links to specifics, I'm happy to take a look. I like what this patch series is trying to do, but the implementation is piling complexity on top of something that is already horribly complicated and I don't immediately see the justification for why that is necessary. > > Is it worth me picking some of the preparatory patches up on their own? > > I think so, yes - it'd make the series easier to manage and mean there's > less to redo per-patch validation on each time if nothing else. They > don't do any harm and seem like they'd be useful even if a completely > different approach is adopted. Ok, I'll see if I can reduce this a bit then. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel