From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 940C8C43465 for ; Mon, 21 Sep 2020 14:20:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 087732084C for ; Mon, 21 Sep 2020 14:20:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BDtfsmwF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 087732084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MIBHuwkJFr/6MEFdCxl7wVNFI7Bm4hBFj2zCdaePU5Q=; b=BDtfsmwFEHb9Wxx7ZU/sFeYLx 7OI00weaLzSmmy8AF5sj2L00XvzkCFtPnW0HdB30yARZS9HJQKol97YGZ1tbS0HXo4X90dHMYD0f7 GemK3uUdtNTyrxVoBgyS0Hu7IGW2LH1y70q6y+RQJ+2mQ4+aggUC3kZBmNM0gAYRZ+R6uf4mDyobq 1a/Oa1BfcdjidR0DfXZxN0IK+A489pgZH29wFzCt9Fzu5hXiNZTDF4wOUOoYNPEG5FImVzT8C3mEC K4+bHZh7NVUeBHDXT/NS5jOcAU7cHkKpXEm/Guh4rRG36qKZKtUNmm2GQHq9+hQA+pbx5CMPx9fnY ZNNRikF/g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKMeB-0000am-HB; Mon, 21 Sep 2020 14:18:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKMe8-0000Zq-8g for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 14:18:25 +0000 Received: from gaia (unknown [31.124.44.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1DF020BED; Mon, 21 Sep 2020 14:18:21 +0000 (UTC) Date: Mon, 21 Sep 2020 15:18:19 +0100 From: Catalin Marinas To: Amit Daniel Kachhap Subject: Re: [PATCH 1/6] kselftest/arm64: Add utilities and a test to validate mte memory Message-ID: <20200921141817.GC13882@gaia> References: <20200901092719.9918-1-amit.kachhap@arm.com> <20200901092719.9918-2-amit.kachhap@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200901092719.9918-2-amit.kachhap@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_101824_380972_51397D7E X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shuah Khan , linux-kernel@vger.kernel.org, Gabor Kertesz , linux-kselftest@vger.kernel.org, Vincenzo Frascino , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 01, 2020 at 02:57:14PM +0530, Amit Daniel Kachhap wrote: > diff --git a/tools/testing/selftests/arm64/mte/mte_helper.S b/tools/testing/selftests/arm64/mte/mte_helper.S > new file mode 100644 > index 000000000000..91af6d1293f8 > --- /dev/null > +++ b/tools/testing/selftests/arm64/mte/mte_helper.S > @@ -0,0 +1,116 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright (C) 2020 ARM Limited */ > + > +#include "mte_def.h" > + > +#define ENTRY(name) \ > + .globl name ;\ > + .p2align 2;\ > + .type name, @function ;\ > +name: > + > +#define ENDPROC(name) \ > + .size name, .-name ; > + > + .text > +/* > + * mte_insert_random_tag: Insert random tag and different from > + * the orginal tag if source pointer has it. > + * Input: > + * x0 - source pointer with a tag/no-tag > + * Return: > + * x0 - pointer with random tag > + */ > +ENTRY(mte_insert_random_tag) > + mov x1, #0x0 > + gmi x1, x0, x1 > + irg x0, x0, x1 > + ret > +ENDPROC(mte_insert_random_tag) What was the reason for gmi here? The test fails when you have an include mask of 0x8000 (exclude mask 0x7fff) and x0 has tag 0xf. In this case we exclude the only allowed tag here, so the CPU falls back to the default tag 0. You can (a) stop the check_multiple_included_tags() earlier to have two allowed tags here, (b) clear the pointer old tag so that you don't end up in this scenario or (c) simply remove the gmi. My preference is the latter, we don't test the hardware here, we only want to check whether the kernel sets the GCR_EL1 correctly. BTW, you also remove mov x1, #0, just: irg x0, x0, xzr -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel