From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB72C43468 for ; Mon, 21 Sep 2020 14:54:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AC0F2220C for ; Mon, 21 Sep 2020 14:54:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WLFKtaIy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="HDivceJo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AC0F2220C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j0Xk2XqZk8QpblShp8q2C1QsZqvONkwuLIs2vU4Mr+s=; b=WLFKtaIyb0GPsEyrPDsf3cmnD 2B1LEGs1OqrGiiJ9mvuDjUmXPUBwh8jkDd8cIWGRfKPjDyXsvCDiNoqaysHsNdi1QSYdyNJiK1JWS zgd5NR3aMJSikUuOnjbZ1EVN0tgcK9gP45LkrPRn6/26Sh7zMo8TLEXOtoRcUzX3cjGYHxGBzxHnc E1eQUDSZDXwd2XD162OaKbIt/0Hcq0CeRn3zRXZyFkPphszQP4JSSp8VYBAlGchU0Je7+/fUZJKd/ 0FqhqXVWhmYIKEcseezfZkhPjx1QkxZtJxtwelKFRVnD+Sk8a46AXtkU36gV93lU6EdQNCwNAkLqb sdj8NsR4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKNC2-0002QL-2v; Mon, 21 Sep 2020 14:53:26 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKNC0-0002Pp-1a for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 14:53:24 +0000 Received: by mail-wr1-x441.google.com with SMTP id z1so13106949wrt.3 for ; Mon, 21 Sep 2020 07:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZLIpTokF5jH+Cz9jMCvpZNnuTjedIPem/C8z7mI3oKI=; b=HDivceJohFIuElY1wucrL0+CCkoN3NxC4fZ2p+cpfAhTpCX8Ba1gW2mU/mb9AZnrVy sh5JgT47h6unJ4NIwLvXXd+mYlgzOTkWD8+V0qr254r533XNstBtXXjf2BUt0Buf/c94 QhK6X5z4cXqkxdrcdWiT+f0jXSBZkeho3CHQfFTh/xnM+R0Zwca4UumZUkUmi9OKwKFa utiKl2UGXR17nPOg6w9G9eKfMfQ4F9o2VimjLOHh6XoS8VegLhy6trOFMCAQAGONr9/i t9IKGkdrn6clTQLtqBtZlvnvEJjYBqz9b12iH0Vj+gzNP23jYjxlfLO5q4/04R2TNUhh d3Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZLIpTokF5jH+Cz9jMCvpZNnuTjedIPem/C8z7mI3oKI=; b=HhSg+xGSDkNm17dkYti7cZ0gncsaOj8+TkIo+vrOQL76NikJhDfdTDCrPOtOcsBSH/ 3vPznYKxWsqK+mQM6ftxW5q5xxil5O2Wwyqsk/mOSNlEreyW8jkgyon5TXnAbRvpZ452 +lEE6ysW+6L4k9H+b93a5eSvrOeIn2Y0cCUHEgxaQaNFuAPqN339VxBR+YkbWTEPLEMc 0q2kAAsCFQev3jBlRJHQmpHn+MnhCghr2yGFlCTcD+d4q7FBrCWtcYlQRHe2FTN0FReC aZsnIALx/IETikzfxNcEY5ccOcAwEXFuEZA1bXml55ft2bH2vaaufNR5Ps+s0GstiI/E PU6Q== X-Gm-Message-State: AOAM533SjPlJTpTyYMqOlRI249FrcCms+m+HGzENmbTf3tKv860OG8ct EewnapW/babLyOa22GjHlOGfjQ== X-Google-Smtp-Source: ABdhPJzLD5pzZxn6lfDyHx+GkKqw6AZgDKziMzh+yFRg4+M/CAMHQNV666TSafzDoBpxyLcZibJWTw== X-Received: by 2002:a5d:444e:: with SMTP id x14mr119183wrr.235.1600700002841; Mon, 21 Sep 2020 07:53:22 -0700 (PDT) Received: from google.com ([2a01:4b00:8523:2d03:e5b6:fa6a:5f89:97d3]) by smtp.gmail.com with ESMTPSA id m10sm19281942wmi.9.2020.09.21.07.53.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 07:53:22 -0700 (PDT) Date: Mon, 21 Sep 2020 15:53:20 +0100 From: David Brazdil To: Will Deacon Subject: Re: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu Message-ID: <20200921145320.2b2ipdj6w4morjc3@google.com> References: <20200916173439.32265-1-dbrazdil@google.com> <20200916173439.32265-6-dbrazdil@google.com> <20200918090533.GE30834@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200918090533.GE30834@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_105324_111101_09E5C9A5 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Marc Zyngier , Tejun Heo , Dennis Zhou , Christoph Lameter , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, Julien Thierry , Andrew Scull Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, > Cosmetic, but I think it would be cleaner just to define two variants of the > macro here: > > #if defined(__KVM_NVHE_HYPERVISOR__) || defined(__KVM_VHE_HYPERVISOR__) > .macro this_cpu_offset, dst > mrs \dst, tpidr_el2 > .endm > #else > .macro this_cpu_offset, dst > alternative_if_not ARM64_HAS_VIRT_HOST_EXTN > mrs \dst, tpidr_el1 > alternative_else > mrs \dst, tpidr_el2 > alternative_endif > .endm > #endif Sure. > (and should we have a shorthand __HYPERVISOR define to avoid the NVHE || VHE > logic?) Happy to add this but let's agree on the details. * name: just __HYPERVISOR or __KVM_HYPERVISOR__? * defined where? I'm wary of defining it in a header file because then sombody will forget to add it and 'ifdef HYP' will be skipped. So I'd put this as another '-D__HYPERVISOR' in the build rules. Do you agree? David _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel