From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD49C4346B for ; Mon, 21 Sep 2020 15:21:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 586F3207C3 for ; Mon, 21 Sep 2020 15:21:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xhHxwZjH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 586F3207C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bsrH0eOdfJO/yx2HfRdX4im5Q/7kqkCMZWVXTSUHSYk=; b=xhHxwZjHTNyiWMo+Y4SDBXGDX ckLPGv7mh0GzyvsWEbS6w3ZRkuM1VCqIuO73aEIQR7PU6ZRzh5bjXkaWAPk8f81sn+J2PgVP1p2Pz DruY7FvN3vFRyPj3dGXPYeSIFH6YejTBC4j/bORIyfxLA2wMSzRWAj3uG89cfMwSKviUmnsuN9gtk bvNjEmVBivqoN+c2QBin9at45OzrvNdOHQn5IkL9ePcrdWuKNRH6hCFtGyMwSdVHPoM4tcuIVHAA2 vJh8DULiuVjRxnbqXRBj7OPYMV88Ir8Ge0DoiKs0+vsjVUfvzgwen1OjOb3GyeiFnElAnXcKcUuK9 PLqXkoFYg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKNbu-0007KE-GS; Mon, 21 Sep 2020 15:20:10 +0000 Received: from [2002:c35c:fd02::1] (helo=ZenIV.linux.org.uk) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKNbs-0007Jk-7C for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 15:20:08 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKNbm-003CHu-Vt; Mon, 21 Sep 2020 15:20:03 +0000 Date: Mon, 21 Sep 2020 16:20:02 +0100 From: Al Viro To: Christoph Hellwig Subject: Re: [PATCH 06/11] iov_iter: handle the compat case in import_iovec Message-ID: <20200921152002.GW3421308@ZenIV.linux.org.uk> References: <20200921143434.707844-1-hch@lst.de> <20200921143434.707844-7-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200921143434.707844-7-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_112008_276793_1AA409DA X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aio@kvack.org, linux-mips@vger.kernel.org, David Howells , linux-mm@kvack.org, keyrings@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Arnd Bergmann , linux-block@vger.kernel.org, io-uring@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Axboe , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, David Laight , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 21, 2020 at 04:34:29PM +0200, Christoph Hellwig wrote: > Use in compat_syscall to import either native or the compat iovecs, and > remove the now superflous compat_import_iovec, which removes the need for > special compat logic in most callers. Only io_uring needs special > treatment given that it can call import_iovec from kernel threads acting > on behalf of native or compat syscalls. Expose the low-level > __import_iovec helper and use it in io_uring to explicitly pick a iovec > layout. fs/aio.c part is not obvious... Might be better to use __import_iovec() there as well and leave the rest of aio.c changes to followup. > --- a/lib/iov_iter.c > +++ b/lib/iov_iter.c > @@ -1683,7 +1683,7 @@ static int compat_copy_iovecs_from_user(struct iovec *iov, > return ret; > } > > -static ssize_t __import_iovec(int type, const struct iovec __user *uvector, > +ssize_t __import_iovec(int type, const struct iovec __user *uvector, > unsigned nr_segs, unsigned fast_segs, struct iovec **iovp, > struct iov_iter *i, bool compat) > { Don't make it static in the first place, perhaps? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel