From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 183A4C43468 for ; Mon, 21 Sep 2020 17:16:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0F182085B for ; Mon, 21 Sep 2020 17:16:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ma3dp8S2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZryhrD87" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0F182085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V8aFBkbHlxE9bppBL3bNJUcOrlhKaELoQJLxtmADfvw=; b=ma3dp8S2cgHrShru1q7uN4nbi GlkcLqB5vcfkbrWkfKRG+8HPsRBc6ShbyxdVb85sTpcgl16SDewpJDeL9FMOQXX6boaMLewnjtZlH kTuuGMGCBCOeQDuT5g9hBTz4GjIJNc58BYdENv9uAmdpXJjO3TcI3ZxZ/bqMK5pkU4mfkwTQ9NNMG LWNWjNGJpf3dIdIkqkirzJdavCuxBhv8KO28wcKUQTdJGF8HV7ceKVguTn02WmsuSWzBQ4WV0w5zZ GLczG/XbL4czyS6pYRKQ+OwveU6fFykzjmZmmPRPWqNULarbNA4ngYQ7L8p96JGuhVJArKv61OOUp Ntop+Mtbw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKPPF-0007wO-SL; Mon, 21 Sep 2020 17:15:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKPPD-0007vi-Fb for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 17:15:12 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63B7A20758; Mon, 21 Sep 2020 17:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600708510; bh=oNl21GKbETxspIUiGd6NDudHCGJOD0WlSYjrtXePsT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZryhrD874sShofTk0rTnQKhsxe5vhXg2Uc0l76zhVlL43CNGinRt1Tmca5p4p5c88 k+nRlUPhwlqlluWbpD3RsHOc4PubKpcwCDazHBD6eda+rgc8HupCJTCIharrUtuNGS pRqj+BOsrJtKboJxXSxVPfvrZfqAaXVX6vqw1/rs= Date: Mon, 21 Sep 2020 18:15:05 +0100 From: Will Deacon To: David Brazdil Subject: Re: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu Message-ID: <20200921171503.GB2822@willie-the-truck> References: <20200916173439.32265-1-dbrazdil@google.com> <20200916173439.32265-6-dbrazdil@google.com> <20200918090533.GE30834@willie-the-truck> <20200921145320.2b2ipdj6w4morjc3@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200921145320.2b2ipdj6w4morjc3@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_131511_601670_3CC74E4F X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Marc Zyngier , Tejun Heo , Dennis Zhou , Christoph Lameter , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, Julien Thierry , Andrew Scull Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 21, 2020 at 03:53:20PM +0100, David Brazdil wrote: > > Cosmetic, but I think it would be cleaner just to define two variants of the > > macro here: > > > > #if defined(__KVM_NVHE_HYPERVISOR__) || defined(__KVM_VHE_HYPERVISOR__) > > .macro this_cpu_offset, dst > > mrs \dst, tpidr_el2 > > .endm > > #else > > .macro this_cpu_offset, dst > > alternative_if_not ARM64_HAS_VIRT_HOST_EXTN > > mrs \dst, tpidr_el1 > > alternative_else > > mrs \dst, tpidr_el2 > > alternative_endif > > .endm > > #endif > > Sure. Ta. > > (and should we have a shorthand __HYPERVISOR define to avoid the NVHE || VHE > > logic?) > > Happy to add this but let's agree on the details. > * name: just __HYPERVISOR or __KVM_HYPERVISOR__? Hey, I leave the hard decisions to others! > * defined where? I'm wary of defining it in a header file because then sombody > will forget to add it and 'ifdef HYP' will be skipped. So I'd put this as > another '-D__HYPERVISOR' in the build rules. Do you agree? Hmm, that's a good point. Leave that part as-is for now then and we can tackle it separately if it comes up again. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel