linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] ARM: dts: imx6q-logicpd: Add a specific board compatible string
@ 2020-09-13 16:29 Fabio Estevam
  2020-09-13 16:29 ` [PATCH 2/4] dt-bindings: arm: fsl: Add an entry for the i.MX6 LogicPD board Fabio Estevam
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-09-13 16:29 UTC (permalink / raw)
  To: shawnguo; +Cc: Fabio Estevam, aford173, linux-arm-kernel

It is standard practice to have a specific board compatible string, so
pass "logicpd,imx6q-logicpd".

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/imx6q-logicpd.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
index 8f94364ba484..46a4ddedb423 100644
--- a/arch/arm/boot/dts/imx6q-logicpd.dts
+++ b/arch/arm/boot/dts/imx6q-logicpd.dts
@@ -9,7 +9,7 @@
 
 / {
 	model = "Logic PD i.MX6QD SOM-M3";
-	compatible = "fsl,imx6q";
+	compatible = "logicpd,imx6q-logicpd", "fsl,imx6q";
 
 	backlight: backlight-lvds {
 		compatible = "pwm-backlight";
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/4] dt-bindings: arm: fsl: Add an entry for the i.MX6 LogicPD board
  2020-09-13 16:29 [PATCH 1/4] ARM: dts: imx6q-logicpd: Add a specific board compatible string Fabio Estevam
@ 2020-09-13 16:29 ` Fabio Estevam
  2020-09-13 16:29 ` [PATCH 3/4] ARM: imx: dts: Add an entry for imx6q-logicpd.dtb Fabio Estevam
  2020-09-13 16:29 ` [PATCH 4/4] ARM: dts: imx6q-logicpd: Use GPIO chipselect Fabio Estevam
  2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-09-13 16:29 UTC (permalink / raw)
  To: shawnguo; +Cc: Fabio Estevam, aford173, linux-arm-kernel

Add an entry for the i.MX6 LogicPD board.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 71acf14da715..6c87a92fd6f5 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -120,6 +120,7 @@ properties:
               - fsl,imx6q-sabrelite
               - fsl,imx6q-sabresd
               - kontron,imx6q-samx6i      # Kontron i.MX6 Dual/Quad SMARC Module
+              - logicpd,imx6q-logicpd
               - prt,prti6q                # Protonic PRTI6Q board
               - prt,prtwd2                # Protonic WD2 board
               - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/4] ARM: imx: dts: Add an entry for imx6q-logicpd.dtb
  2020-09-13 16:29 [PATCH 1/4] ARM: dts: imx6q-logicpd: Add a specific board compatible string Fabio Estevam
  2020-09-13 16:29 ` [PATCH 2/4] dt-bindings: arm: fsl: Add an entry for the i.MX6 LogicPD board Fabio Estevam
@ 2020-09-13 16:29 ` Fabio Estevam
  2020-09-22  2:14   ` Shawn Guo
  2020-09-13 16:29 ` [PATCH 4/4] ARM: dts: imx6q-logicpd: Use GPIO chipselect Fabio Estevam
  2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2020-09-13 16:29 UTC (permalink / raw)
  To: shawnguo; +Cc: Fabio Estevam, aford173, linux-arm-kernel

Add an entry for imx6q-logicpd.dtb so that it can be built by default.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 4a4e92d12395..081abdfe7c17 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -532,6 +532,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-icore-ofcap12.dtb \
 	imx6q-icore-rqs.dtb \
 	imx6q-kp-tpc.dtb \
+	imx6q-logicpd.dtb \
 	imx6q-marsboard.dtb \
 	imx6q-mccmon6.dtb \
 	imx6q-nitrogen6x.dtb \
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 4/4] ARM: dts: imx6q-logicpd: Use GPIO chipselect
  2020-09-13 16:29 [PATCH 1/4] ARM: dts: imx6q-logicpd: Add a specific board compatible string Fabio Estevam
  2020-09-13 16:29 ` [PATCH 2/4] dt-bindings: arm: fsl: Add an entry for the i.MX6 LogicPD board Fabio Estevam
  2020-09-13 16:29 ` [PATCH 3/4] ARM: imx: dts: Add an entry for imx6q-logicpd.dtb Fabio Estevam
@ 2020-09-13 16:29 ` Fabio Estevam
  2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-09-13 16:29 UTC (permalink / raw)
  To: shawnguo; +Cc: Fabio Estevam, aford173, linux-arm-kernel

Using the native SPI chipselect on i.MX6 is known to be problematic.

Doing it on a imx6q-sabresd causes the SPI NOR probe to fail:

[    5.388704] spi-nor spi0.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00

Use the GPIO chipselect to avoid such problem.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
index 9e027b9a5f91..665d63765cdc 100644
--- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
+++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
@@ -212,6 +212,7 @@
 &ecspi1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_ecspi1>;
+	cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>;
 	status = "disabled";
 };
 
@@ -383,7 +384,7 @@
 			MX6QDL_PAD_KEY_COL0__ECSPI1_SCLK	0x100b1
 			MX6QDL_PAD_KEY_ROW0__ECSPI1_MOSI	0x100b1
 			MX6QDL_PAD_KEY_COL1__ECSPI1_MISO	0x100b1
-			MX6QDL_PAD_KEY_ROW1__ECSPI1_SS0		0x100b1
+			MX6QDL_PAD_KEY_ROW1__GPIO4_IO09		0x1b0b0
 		>;
 	};
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 3/4] ARM: imx: dts: Add an entry for imx6q-logicpd.dtb
  2020-09-13 16:29 ` [PATCH 3/4] ARM: imx: dts: Add an entry for imx6q-logicpd.dtb Fabio Estevam
@ 2020-09-22  2:14   ` Shawn Guo
  0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2020-09-22  2:14 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: aford173, linux-arm-kernel

On Sun, Sep 13, 2020 at 01:29:12PM -0300, Fabio Estevam wrote:
> Add an entry for imx6q-logicpd.dtb so that it can be built by default.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Subject prefix should be 'ARM: dts: imx: ...'

I fixed it up and applied the series.

Shawn

> ---
>  arch/arm/boot/dts/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 4a4e92d12395..081abdfe7c17 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -532,6 +532,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>  	imx6q-icore-ofcap12.dtb \
>  	imx6q-icore-rqs.dtb \
>  	imx6q-kp-tpc.dtb \
> +	imx6q-logicpd.dtb \
>  	imx6q-marsboard.dtb \
>  	imx6q-mccmon6.dtb \
>  	imx6q-nitrogen6x.dtb \
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-09-22  2:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-13 16:29 [PATCH 1/4] ARM: dts: imx6q-logicpd: Add a specific board compatible string Fabio Estevam
2020-09-13 16:29 ` [PATCH 2/4] dt-bindings: arm: fsl: Add an entry for the i.MX6 LogicPD board Fabio Estevam
2020-09-13 16:29 ` [PATCH 3/4] ARM: imx: dts: Add an entry for imx6q-logicpd.dtb Fabio Estevam
2020-09-22  2:14   ` Shawn Guo
2020-09-13 16:29 ` [PATCH 4/4] ARM: dts: imx6q-logicpd: Use GPIO chipselect Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).