From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00088C4346E for ; Tue, 22 Sep 2020 03:00:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B7D8239CF for ; Tue, 22 Sep 2020 03:00:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mOiW1k+t"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tkH+HRlJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B7D8239CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D3ay9kgpxVVkb/1Axy7NB5u4ZWLeMr4zhM8nN8usW2k=; b=mOiW1k+tiC28PCDcb6Awwlh79 jc6ax0n4sbwjelMXGbTP8TBR4SaPa/eO+dGB75Ibz3g+RdNhqWLjmeqgti9Qdzm8epSts6VREGbkw tBWwx6ET5807V4oAi0/RdQFa0RcraW2hID0nI2uXyt/dVQc9Nc27898+oYyRCIvLEbVXp9IOwac+w LG9KrQq1ZHw8sGLIVGpLfaqJnX716FkEgjc6zR6RZIrCCCy2fash4bkvD0QzGMt1hZSdlldLSzEOW jcC5QZnkNB22BEtVLB6D8nv/Ds2NhxfycWG9CrenKOe8eP1AHMmX9YEVExd/J8KxuR0KHHrznvitG kVlK+VO7w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKYWU-0005Ft-0T; Tue, 22 Sep 2020 02:59:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKYWR-0005FE-AV for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 02:59:16 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5A63F239A1; Tue, 22 Sep 2020 02:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600743554; bh=b2qwnEFh+ba+rThRPVC7+mIXVik4Np6wC8ogIy5np/E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tkH+HRlJL6TKGegQlflvBRnj+TIfWuAQPjXVI8pWBtpZOXwhNMefqNKGTU0bpuMVw DD6Ga0B1wscRBHHGKEVoH5uyZqzR4yY2wu+W2k4UwMKfHbrxS9AtdUUgF6f1ZMGon/ YGWy+3a3BE7LVRfsD2XXyK7tnl3j5p/XgI+sKie8= Date: Tue, 22 Sep 2020 10:59:05 +0800 From: Shawn Guo To: Michael Walle Subject: Re: [PATCH v10 11/13] arm64: dts: freescale: sl28: enable LED support Message-ID: <20200922025904.GX25109@dragon> References: <20200914214341.14268-1-michael@walle.cc> <20200914214341.14268-12-michael@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200914214341.14268-12-michael@walle.cc> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_225915_503244_B37C2443 X-CRM114-Status: GOOD ( 24.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Catalin Marinas , Linus Walleij , Thierry Reding , Pavel Machek , Lee Jones , Jason Cooper , Andy Shevchenko , Marc Zyngier , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Guenter Roeck , linux-pwm@vger.kernel.org, Jean Delvare , linux-watchdog@vger.kernel.org, Will Deacon , linux-gpio@vger.kernel.org, Mark Brown , Thomas Gleixner , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Li Yang , Rob Herring Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 11:43:39PM +0200, Michael Walle wrote: > Now that we have support for GPIO lines of the SMARC connector, enable > LED support on the KBox A-230-LS. There are two LEDs without fixed > functions, one is yellow and one is green. Unfortunately, it is just one > multi-color LED, thus while it is possible to enable both at the same > time it is hard to tell the difference between "yellow only" and "yellow > and green". > > Signed-off-by: Michael Walle > Acked-by: Pavel Machek > --- > Changes since v9: > - none > > Changes since v8: > - none > > Changes since v7: > - use new "function" and "color" properties instead of a label > - added default-on trigger for the power-led > > Changes since v6: > - none > > Changes since v5: > - changed the label, suggested by Pavel Machek > > Changes since v4: > - none > > Changes since v3: > - see cover letter > > .../fsl-ls1028a-kontron-kbox-a-230-ls.dts | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > index 4b4cc6a1573d..dd516c0efd8b 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-kbox-a-230-ls.dts > @@ -11,11 +11,29 @@ > > /dts-v1/; > #include "fsl-ls1028a-kontron-sl28-var4.dts" > +#include > > / { > model = "Kontron KBox A-230-LS"; > compatible = "kontron,kbox-a-230-ls", "kontron,sl28-var4", > "kontron,sl28", "fsl,ls1028a"; > + > + leds { > + compatible = "gpio-leds"; > + > + alarm-led { > + function = LED_FUNCTION_ALARM; > + color = ; > + gpios = <&sl28cpld_gpio0 0 0>; > + }; > + > + power-led { > + linux,default-trigger = "default-on"; > + function = LED_FUNCTION_POWER; > + color = ; > + gpios = <&sl28cpld_gpio1 3 0>; Use GPIO_ACTIVE_HIGH for polarity to improve the readability. I fixed them up and applied patch #9 ~ #13. Shawn > + }; > + }; > }; > > &enetc_mdio_pf3 { > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel