From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DDAC4363D for ; Tue, 22 Sep 2020 06:43:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01DC123A1D for ; Tue, 22 Sep 2020 06:43:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q52o9Q8E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YDz5fyaW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01DC123A1D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GNqc9GUXyXD+fL40v4etyJ+8lTuR1ihPiT0vOS028rk=; b=Q52o9Q8EX/N4XXLGPcehSsPAM E8DkY2ix/Gtv2MsQI6Nm0KpS1vkBGiCBKvo2o+WtL4T+vW5UgwWTlSWpVH0rf1PHdE8uEXLYzgxdr ghUSFAP7/aB13SsT/ppewACOUQN+VZCsoXEg0fpxUlIclR2//4dPFrPPOfaSv3bzprRr3LHHg2duh CyRT7Df/eG5KdFCe48DHIGROVNfPxa/kPAPxA9BsTOEWFV/gCgPuuXAGDo5oih3naD6mvHcuEn2rQ OuZaqrXgq17i0pdNJMzbvyckPnLXclsfl4EOTrHUEplfSmg1RVRfz/iqZPde5GCR/Bb94U4rxMHCO W0QzvHfdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKbzC-0007nh-FF; Tue, 22 Sep 2020 06:41:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKbz9-0007n2-4n for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 06:41:08 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39915208A9; Tue, 22 Sep 2020 06:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600756866; bh=fpjEKO0HEwKVPJVEg6fnVWA4DnHuAPPahJEOFfNsJ+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YDz5fyaWjfQOOxQBPCsSpHZgxRgTp3lFkibp1h73W9J+tF4HpTSnSdTl9bJZglV15 QRbPkzsPTDR7oVY+STeBfOULnE24qqLWKkzFYPylSv0R+5gJbFwPtZTI4/6GLF0lXj lzgJZbvqm0Uem9hzkyBpix4oXzvRvEw+nVGFpzAc= Date: Tue, 22 Sep 2020 14:40:59 +0800 From: Shawn Guo To: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/4] ARM: dts: imx6qdl-gw5xxx: correct interrupt flags Message-ID: <20200922064058.GE25109@dragon> References: <20200917185449.5687-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917185449.5687-1-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_024107_629841_A6EEB95D X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Baluta , Peter Chen , Jacky Bai , Anson Huang , devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Robin Gong , Adam Ford , Tim Harvey , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2020 at 08:54:46PM +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted same > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Signed-off-by: Krzysztof Kozlowski Applied all, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel