From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D26FC4363D for ; Tue, 22 Sep 2020 06:50:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18AEE239E5 for ; Tue, 22 Sep 2020 06:50:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N6ZZnTfM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18AEE239E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S0Zbt1fIRxY1hoPbE+k24J5ng/UGZg+6c+GxBMFxZxo=; b=N6ZZnTfMPa2U6ndVPsngJI9r4 MhMxz0cYA2HlKkpA+hk4vLbWrwXgu7lEp5VGB90XH81Iwpqxqznhg1Y2QSao5MVaOf/4a04lkotb8 wMZcyi6iiZGWL5x1aCEFZ1rAFeQ0JyFJGSErmIZLC23yw6ox38oK/6qXvkF735SDxrjBhJmdqKX4L zBMXb9xkwSelBG5HnWilYV9GrDjU8iLeOWuW/AgjZmP9RR3waADLjyWRZYdOA7KQSIqPZKidpO2da MmLL8vSb3l+o8ldsWsJQF3UV7E9WZm5zMdL67F7BljMAF7L3rUr4Z8+f5rejCTLyBv4xSIbuLnmZ2 0nYFQ/wdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKc6y-0000Xq-H9; Tue, 22 Sep 2020 06:49:12 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKc6v-0000Wq-1e; Tue, 22 Sep 2020 06:49:10 +0000 X-Originating-IP: 90.65.88.165 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 02909240007; Tue, 22 Sep 2020 06:49:01 +0000 (UTC) Date: Tue, 22 Sep 2020 08:49:01 +0200 From: Alexandre Belloni To: Krzysztof Kozlowski Subject: Re: [PATCH 04/42] mfd: atmel-hlcdc: use PLATFORM_DEVID_NONE Message-ID: <20200922064901.GM9675@piout.net> References: <20200921205016.20461-1-krzk@kernel.org> <20200921205016.20461-4-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200921205016.20461-4-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_024909_296637_7AE2B426 X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Milo Kim , Tony Lindgren , Andy Shevchenko , Lee Jones , Florian Fainelli , Ludovic Desroches , Chanwoo Choi , Chen-Yu Tsai , bcm-kernel-feedback-list@broadcom.com, Bartlomiej Zolnierkiewicz , Ray Jui , linux-samsung-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Support Opensource , Scott Branden , Sangbeom Kim , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/09/2020 22:49:38+0200, Krzysztof Kozlowski wrote: > Use PLATFORM_DEVID_NONE define instead of "-1" value because: > - it brings some meaning, > - it might point attention why auto device ID was not used. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Alexandre Belloni > --- > drivers/mfd/atmel-hlcdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c > index 3c2414ba4b01..8ba13bc6fcf8 100644 > --- a/drivers/mfd/atmel-hlcdc.c > +++ b/drivers/mfd/atmel-hlcdc.c > @@ -129,7 +129,7 @@ static int atmel_hlcdc_probe(struct platform_device *pdev) > > dev_set_drvdata(dev, hlcdc); > > - return devm_mfd_add_devices(dev, -1, atmel_hlcdc_cells, > + return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, atmel_hlcdc_cells, > ARRAY_SIZE(atmel_hlcdc_cells), > NULL, 0, NULL); > } > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel