From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D108C4727D for ; Tue, 22 Sep 2020 10:27:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D117C208A9 for ; Tue, 22 Sep 2020 10:27:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IJcSBskC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D117C208A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FNQP8DxFCuBTgTy2g+tCKaXcVFeiIl3H4mntkOf+L3g=; b=IJcSBskCu71JMDCBorJh4eUpJ j13q8yO3NZ75twvKr8L8wahEUdbH5d8FV23MJRf8gt4FOp1TJiHNhyUsTKD4QpfZnrgKwcGeP5JFe JgnxISE+DMUtv13vXzZooZCwZw62YU5aTdniEdTeCz/DvKY50cYsahFNmBw5H2GH9X0pWkFsVpL7N Wh0N8+00zKHp07aeYX+PlIuRDG6FdEpsgR+jxReTsWc7F5cKas3pXngU47FvZ2hWOGMueuXWsik3T BDP/DqJmND5UWe3uvIcOHAjkvxjPWFwAMyUepEgQkebA8HCnR+00xIsFPhsBB7D8vf6vTsMJhqrLk eKGku5GTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKfV3-0002Nq-5d; Tue, 22 Sep 2020 10:26:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKfUx-0002LT-IW; Tue, 22 Sep 2020 10:26:12 +0000 Received: from gaia (unknown [31.124.44.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 348FD2086A; Tue, 22 Sep 2020 10:26:08 +0000 (UTC) Date: Tue, 22 Sep 2020 11:26:05 +0100 From: Catalin Marinas To: Arnd Bergmann Subject: Re: [PATCH v7 4/4] arm64: dts: Add Caninos Loucos Labrador v3 Message-ID: <20200922102605.GE15643@gaia> References: <20200922024302.205062-1-matheus@castello.eng.br> <20200922024302.205062-5-matheus@castello.eng.br> <20200922061454.GA29035@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_062611_750065_EC5B06B9 X-CRM114-Status: GOOD ( 23.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Matheus Castello , linux-actions@lists.infradead.org, "linux-kernel@vger.kernel.org" , edgar.righi@lsitec.org.br, Helen Koike , Rob Herring , Manivannan Sadhasivam , Olof Johansson , igor.lima@lsitec.org.br, Will Deacon , Andreas =?iso-8859-1?Q?F=E4rber?= , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 22, 2020 at 10:32:06AM +0200, Arnd Bergmann wrote: > On Tue, Sep 22, 2020 at 8:15 AM Manivannan Sadhasivam > wrote: > > On Mon, Sep 21, 2020 at 11:43:02PM -0300, Matheus Castello wrote: > > > + /* Labrador v3 firmware does not support PSCI */ > > > > Oops. This is unfortunate... I'm not sure if this is even acceptable for > > ARM64 machines. > > > > Let me add Olof and Arnd... > > Adding Catalin and Will for additional input as well, this is more their > area than ours. > > I don't think we have formalized this as a policy, but we clearly don't > want new boards to use the spin table hack. As there are other > boards using psci on the same chip, I don't think this is a > hardware bug. I fully agree, we shouldn't allow new boards to use the spin-table method unless EL3 is missing on the CPU implementation (not the case here; only the APM hardware has this issue). Unfortunately we missed another platform with A53, see commit bc66392d8258 ("arm64: dts: fsl: Add device tree for S32V234-EVB"). The kernel relies on firmware for other things (power management, errata workarounds), so an SMC calling convention compliant firmware is highly recommended. I also don't see why it would be that hard to add PSCI. Even if you don't port something like Trusted Firmware, U-Boot has basic support for PSCI. So from my perspective, NAK on this patch. I'm tempted to also modify smp_spin_table_cpu_init() to print a big warning and return an error if this is attempted on new platforms. IOW, we make it a policy from now on. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel